Skip to content

softmmu/vl: Deprecate old and crufty display ui options

Thomas Huth qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 8 repliesIn review
  2. v13 patches 1 replySuperseded

Changes in v2 from the cover letter

- Update version numbers to 6.2
- Added Acked-bys from Peter Krempa

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3softmmu/vl: Add a "grab-mod" parameter to the -display sdl optionqemu-options.hx softmmu/vl.c+17 -40 replies
2/3softmmu/vl: Deprecate the old grab optionsdocs/about/deprecated.rst qemu-options.hx softmmu/vl.c+24 -41 reply
3/3softmmu/vl: Deprecate the -sdl and -curses optiondocs/about/deprecated.rst softmmu/vl.c+13 -06 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPeter KrempaGerd Hoffmann
SeriesR-b
1/3
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] softmmu/vl: Deprecate old and crufty display ui options

-display sdl uses a hand-crafted parser in vl.c, which is quite ugly since the other parts of -display have been QAPIfied already. A straight conversion to QAPI is not advisable since the "alt_grab" and "ctrl_grab" parameters are not the best solution anyway. So this patch series introduces a new "grab-mod" parameter as replacement instead and then deprecates the old and crufty options.

While we're at it, the third patch also suggests to deprecated the old -sdl and -curses top-level options.

v2:
- Update version numbers to 6.2
- Added Acked-bys from Peter Krempa

Thomas Huth (3):
softmmu/vl: Add a "grab-mod" parameter to the -display sdl option softmmu/vl: Deprecate the old grab options
softmmu/vl: Deprecate the -sdl and -curses option

 docs/about/deprecated.rst | 20 ++++++++++++++++++++
 qemu-options.hx           | 18 +++++++++++++-----
 softmmu/vl.c              | 24 +++++++++++++++++++++---
 3 files changed, 54 insertions(+), 8 deletions(-)
Signature · 1 line
2.27.0