Skip to content

Overwritten file detection and fixes, one more step to TLP build

Herve Codina buildroot 3 versions – Applied

Status from this message: I've applied those four python-related fixes to next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 18 repliesApplied
  2. v218 patches 0 repliesSuperseded
  3. v10 of 15 patches 0 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/16package/pkg-python: fix PKG_PYTHON_FIXUP_SYSCONFIGDATApackage/pkg-python.mk+14 -30 replies
2/16package/pkg-python: invalidate precompiled _sysconfigdata*.pycpackage/pkg-python.mk+3 -10 replies
3/16package/pkg-generic.mk: move python fixup to generic package infrastructurepackage/pkg-generic.mk package/pkg-python.mk+23 -240 replies
4/16package/owfs: remove Python sysconfigdata fixuppackage/owfs/owfs.mk+0 -90 replies
5/16qt5: Fix sporadic build failure during top-level parallel buildpackage/qt5/qt5.mk+1 -03 replies
6/16package/pkg-qmake.mk: Move QT5_QT_CONF_FIXUP to post-prepare hookpackage/pkg-qmake.mk+2 -11 reply
7/16package/pkg-generic.mk: detect files overwritten in TARGET_DIR and HOST_DIRpackage/pkg-generic.mk+23 -08 replies
8/16package/pkg-generic.mk: generate final rsync exclude file listpackage/pkg-generic.mk+28 -00 replies
9/16Makefile: rsync global {TARGET, HOST}_DIR using exclusion file listMakefile+32 -20 replies
10/16Makefile: breaks hardlinks in global {TARGET, HOST}_DIR on per-package buildMakefile+1 -13 replies
11/16package/pkg-generic.mk: fix per-package <pkg>-{reconfigure, rebuild, reinstall}package/pkg-generic.mk+30 -100 replies
12/16package/pkg-generic.mk: remove .files-final-rsync.before temporary filepackage/pkg-generic.mk+1 -00 replies
13/16support/testing/infra: add log_file_path() functionsupport/testing/infra/__init__.py+6 -51 reply
14/16support/testing/tests: add test for check_bin_archsupport/testing/tests/core/br2-external/detect-bad-arch/Config.in support/testing/tests/core/br2-external/detect-bad-arch/external.desc support/testing/tests/core/br2-external/detect-bad-arch/external.mk +3 more+41 -01 reply
15/16support/testing/tests: add test for file overwrite detectionsupport/testing/tests/core/br2-external/detect-overwrite/Config.in support/testing/tests/core/br2-external/detect-overwrite/external.desc support/testing/tests/core/br2-external/detect-overwrite/external.mk +3 more+75 -00 replies
16/16package/pkg-generic.mk: move fixup-libtool-files to post-prepare hookpackage/pkg-generic.mk+12 -80 replies

Reviews trailers per patch

3 of 16 patches have a Reviewed-by or Acked-by.

PatchYann E. MORINHerve Codina
1/16
2/16
3/16
4/16R-b
5/16R-b
6/16
7/16
8/16
9/16
10/16R-b
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Buildroot] [PATCH v3 00/16] Overwritten file detection and fixes, one more step to TLP build

Hi,

This v3 series adds a new patch (patch 1) to fix a find failure already present in PKG_PYTHON_FIXUP_SYSCONFIG that was highlighted in the previous version of this series.
It also reworks the python fixup according to previous review (patches 2 and 3) and fixes the test given in patch 12.

Two patches are added related to Qt5. The first one (patch 5) was previously sent by Andreas Naumann and fixes a Qt5 overwrite.
https://lore.kernel.org/buildroot/[email protected]/
https://lore.kernel.org/buildroot/[email protected]/
The second one (patch 6) moves the fixup function to the post-prepare hooks.

One more patch was added in this serie (patch 14) to move fixup-libtool-file to the post-prepare hooks. This was mentionned during the review of the first version of this series (https://lore.kernel.org/buildroot/20210625092704.GJ2852@scaer/).

More changes details are given in each individual patches.

Best regards,
Hervé Codina

Andreas Naumann (1):
qt5: Fix sporadic build failure during top-level parallel build

Herve Codina (11):
package/pkg-python: fix PKG_PYTHON_FIXUP_SYSCONFIGDATA package/pkg-python: invalidate precompiled _sysconfigdata*.pyc package/pkg-generic.mk: move python fixup to generic package
infrastructure
package/owfs: remove Python sysconfigdata fixup package/pkg-qmake.mk: Move QT5_QT_CONF_FIXUP to post-prepare hook package/pkg-generic.mk: generate final rsync exclude file list
Makefile: rsync global {TARGET,HOST}_DIR using exclusion file list
Makefile: breaks hardlinks in global {TARGET,HOST}_DIR on per-package
build
package/pkg-generic.mk: fix per-package

    <pkg>-{reconfigure,rebuild,reinstall}

package/pkg-generic.mk: remove .files-final-rsync.before temporary
file
package/pkg-generic.mk: move fixup-libtool-files to post-prepare hook

Thomas Petazzoni (4):
package/pkg-generic.mk: detect files overwritten in TARGET_DIR and
HOST_DIR
support/testing/infra: add log_file_path() function support/testing/tests: add test for check_bin_arch support/testing/tests: add test for file overwrite detection

 Makefile                                      |  34 ++++-
 package/owfs/owfs.mk                          |   9 --
 package/pkg-generic.mk                        | 125 ++++++++++++++++--
 package/pkg-python.mk                         |  10 --
 package/pkg-qmake.mk                          |   3 +-
 package/qt5/qt5.mk                            |   1 +
 support/testing/infra/__init__.py             |  11 +-
 .../br2-external/detect-bad-arch/Config.in    |   1 +
 .../detect-bad-arch/external.desc             |   1 +
 .../br2-external/detect-bad-arch/external.mk  |   1 +
 .../package/detect-bad-arch/Config.in         |   4 +
 .../detect-bad-arch/detect-bad-arch.mk        |  15 +++
 .../br2-external/detect-overwrite/Config.in   |   1 +
 .../detect-overwrite/external.desc            |   1 +
 .../br2-external/detect-overwrite/external.mk |   1 +
 .../package/detect-overwrite/Config.in        |   5 +
 .../detect-overwrite/detect-overwrite.mk      |  19 +++
 support/testing/tests/core/test_bad_arch.py   |  19 +++
 .../testing/tests/core/test_file_overwrite.py |  48 +++++++
 19 files changed, 269 insertions(+), 40 deletions(-)
 create mode 100644 support/testing/tests/core/br2-external/detect-bad-arch/Config.in
 create mode 100644 support/testing/tests/core/br2-external/detect-bad-arch/external.desc
 create mode 100644 support/testing/tests/core/br2-external/detect-bad-arch/external.mk
 create mode 100644 support/testing/tests/core/br2-external/detect-bad-arch/package/detect-bad-arch/Config.in
 create mode 100644 support/testing/tests/core/br2-external/detect-bad-arch/package/detect-bad-arch/detect-bad-arch.mk
 create mode 100644 support/testing/tests/core/br2-external/detect-overwrite/Config.in
 create mode 100644 support/testing/tests/core/br2-external/detect-overwrite/external.desc
 create mode 100644 support/testing/tests/core/br2-external/detect-overwrite/external.mk
 create mode 100644 support/testing/tests/core/br2-external/detect-overwrite/package/detect-overwrite/Config.in
 create mode 100644 support/testing/tests/core/br2-external/detect-overwrite/package/detect-overwrite/detect-overwrite.mk
 create mode 100644 support/testing/tests/core/test_bad_arch.py
 create mode 100644 support/testing/tests/core/test_file_overwrite.py
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot