Skip to content

replication: Bugfix and properly attach children

Lukas Straub qemu-devel 5 versions – Applied

Status from this message: I've applied the series to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 2 repliesApplied
  2. v55 patches 2 repliesSuperseded
  3. v44 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v34 patches8 repliesSuperseded
v11 patch3 repliesSuperseded

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/4replication: Remove s->active_diskblock/replication.c+17 -171 reply
2/4replication: Reduce usage of s->hidden_disk and s->secondary_diskblock/replication.c+28 -170 replies
3/4replication: Properly attach childrenblock/replication.c+27 -30 replies
4/4replication: Remove workaroundblock/replication.c+1 -110 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyZhang Chen
1/4R-b R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/4] replication: Bugfix and properly attach children

Hello Everyone,
A while ago Kevin noticed that the replication driver doesn't properly attach the children it wants to use. Instead, it directly copies the BdrvChilds from it's backing file, which is wrong. Ths Patchset fixes the problem, fixes a potential crash in replication_co_writev due to missing permissions and removes a workaround that was put in place back then.

Tested with full COLO-migration setup in my COLO testsuite.

Regards,
Lukas Straub

Changes:

-v6:
-Drop "replication: Assert that children are writable" -Added Reviewed-by tags

-v5:
-Assert that children are writable where it's needed

-v4:
-minor style fixes
-clarify why children areguaranteed to be writable in
"replication: Remove workaround"
-Added Reviewed-by tags

-v3:
-Split up into multiple patches
-Remove s->active_disk
-Clarify child permissions in commit message

-v2: Test for BDRV_CHILD_PRIMARY in replication_child_perm, since

     bs->file might not be set yet. (Vladimir)

Lukas Straub (4):
replication: Remove s->active_disk
replication: Reduce usage of s->hidden_disk and s->secondary_disk
replication: Properly attach children
replication: Remove workaround

 block/replication.c | 111 +++++++++++++++++++++++++++-----------------
 1 file changed, 68 insertions(+), 43 deletions(-)

--
2.20.1