Skip to content

submodule add: partial conversion to C

Atharva Raykar git 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesNew
  2. v24 patches 4 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Changes in v3 from the cover letter

* In 2/4, the prefix 'fatal' is left out of the gettext functions so that it will not create new translatable items for the translators.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4t7400: test failure to add submodule in tracked patht/t7400-submodule-basic.sh+11 -00 replies
2/4submodule: prefix die messages with 'fatal'git-submodule.sh t/t7400-submodule-basic.sh t/t7406-submodule-update.sh+26 -260 replies
3/4submodule--helper: refactor module_clone()builtin/submodule--helper.c+128 -1130 replies
4/4submodule--helper: introduce add-clone subcommandbuiltin/submodule--helper.c git-submodule.sh+178 -3714 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchChristian CouderShourya ShuklaPrathamesh ChavanĐoàn Trần Công Danh
1/4Mentored-by Based-on-patch-by Mentored-by
2/4Mentored-by Mentored-by
3/4Mentored-by Mentored-by
4/4Mentored-by Mentored-by Based-on-patch-by Based-on-patch-by Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [GSoC] [PATCH v3 0/4] submodule add: partial conversion to C

Changes since v2:
* In 2/4, the prefix 'fatal' is left out of the gettext functions so that it will not create new translatable items for the translators.

Atharva Raykar (4):
t7400: test failure to add submodule in tracked path
submodule: prefix die messages with 'fatal'
submodule--helper: refactor module_clone()
submodule--helper: introduce add-clone subcommand

 builtin/submodule--helper.c | 418 ++++++++++++++++++++++++++----------
 git-submodule.sh            |  76 ++-----
 t/t7400-submodule-basic.sh  |  13 +-
 t/t7406-submodule-update.sh |  10 +-
 4 files changed, 342 insertions(+), 175 deletions(-)
Signature · 1 line
2.32.0