Skip to content

virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

David Hildenbrand qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2migration/postcopy-ram: define type for "struct PostcopyNotifyData"hw/virtio/vhost-user.c migration/postcopy-ram.c migration/postcopy-ram.h+4 -41 reply
2/2virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINThw/virtio/virtio-balloon.c include/hw/virtio/virtio-balloon.h+27 -016 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchPankaj Gupta
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

Working on getting migration for virtio-mem completely right [1] I realized that virtio-balloon with VIRTIO_BALLOON_F_FREE_PAGE_HINT paired with postcopy might be shaky. Actually testing it, I directly found two issues, one of both being far from trivial to fix.

Let's disallow postcopy with "free-page-hint=on".

[1] https://lkml.kernel.org/r/[email protected]

David Hildenbrand (2):
migration/postcopy-ram: define type for "struct PostcopyNotifyData"
virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

 hw/virtio/vhost-user.c             |  2 +-
 hw/virtio/virtio-balloon.c         | 26 ++++++++++++++++++++++++++
 include/hw/virtio/virtio-balloon.h |  1 +
 migration/postcopy-ram.c           |  2 +-
 migration/postcopy-ram.h           |  4 ++--
 5 files changed, 31 insertions(+), 4 deletions(-)
Signature · 1 line
2.31.1