Skip to content

fpga: fpga-mgr: move compat_id from fpga_mgr to dfl

[email protected] linux-doc linux-fpga lkml oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 8 repliesIn review
  2. v11 patch 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fpga: region: introduce fpga_region_opsDocumentation/driver-api/fpga/fpga-region.rst drivers/fpga/dfl-fme-pr.c drivers/fpga/dfl-fme-region.c +3 more+53 -210 replies
2/4fpga: region: introduce compat_id_show opdrivers/fpga/fpga-region.c include/linux/fpga/fpga-region.h+5 -00 replies
3/4fpga: dfl: implement the compat_id_show region opdrivers/fpga/dfl-fme-mgr.c drivers/fpga/dfl-fme-region.c drivers/fpga/dfl.h+41 -31 reply
4/4fpga: remove compat_id from fpga_manager and fpga_regiondrivers/fpga/dfl-fme-mgr.c drivers/fpga/dfl-fme-region.c drivers/fpga/fpga-region.c +2 more+1 -296 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] fpga: fpga-mgr: move compat_id from fpga_mgr to dfl

From: Tom Rix <[email protected]>

A followup to
https://lore.kernel.org/linux-fpga/[email protected]/
The current storing of compat_id in fpga_manager is dfl specific. This makes the refactoring of the release()'s complicated because there is a dfl specific flavor of register().

Keeping the compat_id sysfs abi, each implementation through the new compat_id_show() fpga_region op can print out whatever value they need to the sysfs. Currently only dfl does.

Since there are now two ops for fpga_region, give fpga_region its own ops table. Add a wrapper for get_bridges().

Changes from
v1
Completely written to keep sysfs abi

Tom Rix (4):
fpga: region: introduce fpga_region_ops
fpga: region: introduce compat_id_show op
fpga: dfl: implement the compat_id_show region op
fpga: remove compat_id from fpga_manager and fpga_region

 Documentation/driver-api/fpga/fpga-region.rst |  6 ++-
 drivers/fpga/dfl-fme-mgr.c                    | 23 ++++++-----
 drivers/fpga/dfl-fme-pr.c                     |  2 +-
 drivers/fpga/dfl-fme-region.c                 | 21 +++++++++-
 drivers/fpga/dfl.h                            | 14 +++++++
 drivers/fpga/fpga-region.c                    | 40 ++++++++++---------
 drivers/fpga/of-fpga-region.c                 |  6 ++-
 include/linux/fpga/fpga-mgr.h                 | 13 ------
 include/linux/fpga/fpga-region.h              | 26 +++++++++---
 9 files changed, 99 insertions(+), 52 deletions(-)
Signature · 1 line
2.26.3