Skip to content

Let 'qemu-img convert --bitmaps' skip inconsistent bitmaps

Eric Blake qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 10 repliesIn review
  2. v12 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3iotests: Improve and rename test 291 to qemu-img-bitmapblock/dirty-bitmap.c tests/qemu-iotests/tests/qemu-img-bitmaps tests/qemu-iotests/tests/qemu-img-bitmaps.out+66 -32 replies
2/3qemu-img: Fail fast on convert --bitmaps with inconsistent bitmapqemu-img.c tests/qemu-iotests/tests/qemu-img-bitmaps tests/qemu-iotests/tests/qemu-img-bitmaps.out+29 -234 replies
3/3qemu-img: Add --skip-broken-bitmaps for 'convert --bitmaps'docs/tools/qemu-img.rst qemu-img.c tests/qemu-iotests/tests/qemu-img-bitmaps +1 more+69 -64 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyNir Soffer
1/3R-b R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Let 'qemu-img convert --bitmaps' skip inconsistent bitmaps

In v2:
- patch 1: clean up leftover file [Vladimir]
- patch 2: new, to fix badness with leaving corrupt destination on failed bitmap copy [Vladimir]
- patch 3: spell new option --skip-broken-bitmaps (note that --skip-broken as an abbreviation still works) [Vladimir]

Eric Blake (3):
iotests: Improve and rename test 291 to qemu-img-bitmap
qemu-img: Fail fast on convert --bitmaps with inconsistent bitmap
qemu-img: Add --skip-broken-bitmaps for 'convert --bitmaps'

 docs/tools/qemu-img.rst                       |  8 ++-
 block/dirty-bitmap.c                          |  2 +-
 qemu-img.c                                    | 50 +++++++++++++--
 .../{291 => tests/qemu-img-bitmaps}           | 27 +++++++-
 .../{291.out => tests/qemu-img-bitmaps.out}   | 63 ++++++++++++++++++-
 5 files changed, 141 insertions(+), 9 deletions(-)
 rename tests/qemu-iotests/{291 => tests/qemu-img-bitmaps} (82%)
 rename tests/qemu-iotests/{291.out => tests/qemu-img-bitmaps.out} (69%)
Signature · 1 line
2.31.1