Skip to content

virtio-balloon: don't start free page hinting if postcopy is possible

David Hildenbrand qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 1 replyIn review

Changes in v2 from the cover letter

- "virtio-balloon: don't start free page hinting if postcopy is possible" -- Instead of bailing out when starting postcopy, don't start free page hinting if the postcopy capability is enabled and we might see the switch to postcopy for the current migration (where we might mess with the dirty bitmap)
- "virtio-balloon: free page hinting cleanups"
-- Added

[1] https://lkml.kernel.org/r/[email protected]
[2] https://lkml.kernel.org/r/[email protected]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio-balloon: don't start free page hinting if postcopy is possiblehw/virtio/virtio-balloon.c+13 -01 reply
2/2virtio-balloon: free page hinting cleanupshw/virtio/virtio-balloon.c+8 -200 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchPeter Xu
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] virtio-balloon: don't start free page hinting if postcopy is possible

This is the follow up on [1]:
[PATCH v1 0/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

Working on getting migration for virtio-mem completely right [2] I realized that virtio-balloon with VIRTIO_BALLOON_F_FREE_PAGE_HINT paired with postcopy might be shaky. Actually testing it, I directly found two issues, one of both being far from trivial to fix.

Let's not start free page hinting if postcopy is possible.

v1 -> v2:
- "virtio-balloon: don't start free page hinting if postcopy is possible" -- Instead of bailing out when starting postcopy, don't start free page hinting if the postcopy capability is enabled and we might see the switch to postcopy for the current migration (where we might mess with the dirty bitmap)
- "virtio-balloon: free page hinting cleanups"
-- Added

[1] https://lkml.kernel.org/r/[email protected]
[2] https://lkml.kernel.org/r/[email protected]

David Hildenbrand (2):
virtio-balloon: don't start free page hinting if postcopy is possible
virtio-balloon: free page hinting cleanups

 hw/virtio/virtio-balloon.c | 41 +++++++++++++++++++-------------------
 1 file changed, 21 insertions(+), 20 deletions(-)
Signature · 1 line
2.31.1