Skip to content

Replace usage of sprintf with sysfs_emit in swsmu powerplay

Darren Powell amd-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v13 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3amdgpu/pm: Replace navi10 usage of sprintf with sysfs_emitdrivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c+35 -320 replies
2/3amdgpu/pm: Replace smu11 usage of sprintf with sysfs_emitdrivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c+53 -530 replies
3/3amdgpu/pm: Replace smu12/13 usage of sprintf with sysfs_emitdrivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c+27 -280 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlex Deucher
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Replace usage of sprintf with sysfs_emit in swsmu powerplay

=== Description ===
Replace usage of sprintf with sysfs_emit in swsmu powerplay

v2: rebased on 2f56b0d631eb

=== Test System ===
* DESKTOP(AMD FX-8350 + NAVI10(731F/ca), BIOS: F2)
+ ISO(Ubuntu 20.04.2 LTS)
+ Kernel(5.13.0-gb1d634be9673-fdoagd5f)

=== Patch Summary ===
linux: ([email protected]:agd5f) origin/amd-staging-drm-next @ 2f56b0d631eb
+ c4a20b3363cd amdgpu/pm: Replace navi10 usage of sprintf with sysfs_emit
+ cd2e3983959b amdgpu/pm: Replace smu11 usage of sprintf with sysfs_emit
+ bd82d29a9635 amdgpu/pm: Replace smu12/13 usage of sprintf with sysfs_emit

=== General Test for each platform ===
AMDGPU_PCI_ADDR=lspci -nn | grep "VGA\|Display" | cut -d " " -f 1 AMDGPU_HWMON=ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}' HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON} LOGFILE=pp_printf.test.log

lspci -nn | grep "VGA\|Display" > $LOGFILE
FILES="pp_dpm_sclk
pp_sclk_od
pp_mclk_od
pp_dpm_pcie
pp_od_clk_voltage
pp_power_profile_mode "

for f in $FILES
do
echo === $f === >> $LOGFILE
cat $HWMON_DIR/device/$f >> $LOGFILE
done
cat $LOGFILE

Darren Powell (3):
amdgpu/pm: Replace navi10 usage of sprintf with sysfs_emit amdgpu/pm: Replace smu11 usage of sprintf with sysfs_emit amdgpu/pm: Replace smu12/13 usage of sprintf with sysfs_emit

 .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 26 ++++----
 .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c   | 61 ++++++++++---------
 .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c   | 34 +++++------
 .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c  | 46 +++++++-------
 .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c   | 20 +++---
 .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c    | 21 +++----
 .../drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c  | 14 ++---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c        |  6 +-
 8 files changed, 115 insertions(+), 113 deletions(-)

base-commit: 2f56b0d631eba0e76cfc789d85cc5632256ad42d

Signature · 1 line
2.32.0