hw/nvme: fix mmio read
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest5 patches 2 repliesIn review
- v55 patches 7 repliesSuperseded
- v45 patches 1 replySuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 5 patches | 11 replies | Superseded | |
| v2 | 5 patches | 5 replies | Superseded | |
| v1 | 1 patch | 6 replies | Superseded |
Changes in v6 from the cover letter
* "hw/nvme: split pmrmsc register into upper and lower"
- Remove unnecessary masking (Peter)
- Missing shift (Peter)
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | hw/nvme: split pmrmsc register into upper and lowerhw/ include/ | +22 | 2 replies | |
| 2/5 | hw/nvme: use symbolic names for registershw/ include/ | +50 | 0 replies | |
| 3/5 | hw/nvme: fix out-of-bounds readshw/ | +15 | 0 replies | |
| 4/5 | hw/nvme: fix mmio readhw/ | +162 | 0 replies | |
| 5/5 | tests/qtest/nvme-test: add mmio read testtests/ | +26 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Gollu Appalanaidu | Philippe Mathieu-Daudé | Keith Busch | Peter Maydell | Stefan Hajnoczi |
|---|---|---|---|---|---|
| 1/5 | R-b | ||||
| 2/5 | R-b | R-b | R-b | ||
| 3/5 | R-b | R-b | |||
| 4/5 | R-b | ||||
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v6 0/5] hw/nvme: fix mmio read
From: Klaus Jensen <[email protected]>
Fix mmio read issues on big-endian hosts. The core issue is that values in the BAR is not stored in little endian as required.
Fix that and add a regression test for this. This required a bit of cleanup, so it blew up into a series.
v6:
* "hw/nvme: split pmrmsc register into upper and lower"
- Remove unnecessary masking (Peter)
- Missing shift (Peter)
v5:
* "hw/nvme: fix mmio read"
- Hurried the changes a bit. Fixed.
v4:
* "hw/nvme: split pmrmsc register into upper and lower"
- Fix missing left-shift (Peter)
* "hw/nvme: fix mmio read"
- Remove unnecessary masking (Peter)
- Keep existing behaviour and do not zero the register fields doing initialization (Peter)
v3:
* "hw/nvme: use symbolic names for registers"
Use offsetof(NvmeBar, reg) instead of explicit offsets (Philippe)
* "hw/nvme: fix mmio read"
Use the st/ld API instead of cpu_to_X (Philippe)
Klaus Jensen (5):
hw/nvme: split pmrmsc register into upper and lower hw/nvme: use symbolic names for registers hw/nvme: fix out-of-bounds reads
hw/nvme: fix mmio read tests/qtest/nvme-test: add mmio read test
include/block/nvme.h | 60 +++++-- hw/nvme/ctrl.c | 352 ++++++++++++++++++++++------------------ tests/qtest/nvme-test.c | 26 +++ 3 files changed, 265 insertions(+), 173 deletions(-)
Signature · 1 line
2.32.0