Skip to content

aspeed: Support secure boot chain with FIT image verification

Chia-Wei Wang u-boot 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest12 patches 2 repliesIn review
  2. v712 patches 21 repliesSuperseded
  3. v612 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v512 patches2 repliesSuperseded
v411 patches2 repliesSuperseded
v314 patches6 repliesSuperseded
v214 patches0 repliesSuperseded
v114 patches0 repliesSuperseded

Changes in v8 from the cover letter

- include reviewers' tag
- address comments suggested by Joel
- move this patch series back to the master branch as DM_HASH has been merged

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12image: fit: Fix parameter name for hash algorithmcommon/image-fit.c+2 -21 reply
2/12aspeed: ast2600: Enlarge SRAM sizearch/arm/include/asm/arch-aspeed/platform.h+1 -10 replies
3/12clk: ast2600: Add YCLK control for HACEarch/arm/include/asm/arch-aspeed/scu_ast2600.h drivers/clk/aspeed/clk_ast2600.c+25 -20 replies
4/12crypto: aspeed: Add AST2600 HACE supportdrivers/crypto/Kconfig drivers/crypto/Makefile drivers/crypto/aspeed/Kconfig +3 more+403 -01 reply
5/12ARM: dts: ast2600: Add HACE to device treearch/arm/dts/ast2600-evb.dts arch/arm/dts/ast2600.dtsi+13 -00 replies
6/12clk: ast2600: Add RSACLK control for ACRYarch/arm/include/asm/arch-aspeed/scu_ast2600.h drivers/clk/aspeed/clk_ast2600.c+25 -00 replies
7/12crypto: aspeed: Add AST2600 ACRY supportdrivers/crypto/aspeed/Kconfig drivers/crypto/aspeed/Makefile drivers/crypto/aspeed/aspeed_acry.c +1 more+210 -10 replies
8/12ARM: dts: ast2600: Add ACRY to device treearch/arm/dts/ast2600-evb.dts arch/arm/dts/ast2600.dtsi+14 -00 replies
9/12ast2600: spl: Locate load buffer in DRAM spacearch/arm/mach-aspeed/ast2600/spl.c+1 -80 replies
10/12configs: ast2600-evb: Enable SPL FIT supportconfigs/evb-ast2600_defconfig+17 -30 replies
11/12configs: aspeed: Make EXTRA_ENV_SETTINGS board specificinclude/configs/aspeed-common.h include/configs/evb_ast2500.h include/configs/evb_ast2600.h+14 -90 replies
12/12configs: ast2600: Boot kernel FIT in DRAMconfigs/evb-ast2600_defconfig include/configs/evb_ast2600.h+8 -10 replies

Reviews trailers per patch

6 of 12 patches have a Reviewed-by or Acked-by.

PatchJoel StanleySimon Glass
1/12R-b R-b
2/12R-b
3/12
4/12R-b
5/12
6/12
7/12
8/12R-b
9/12R-b
10/12R-b
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 00/12] aspeed: Support secure boot chain with FIT image verification

This patch series intends to provide a secure boot chain from SPL to Linux kernel based on the hash and signature verification of FIT image paradigm.

To improve the performance and save code size (SPL is limited to 64KB due to HW-RoT), the drviers of two HW crypto engine HACE and ACRY are also added for AST26xx SoCs.

As HACE and ACRY can only access to DRAM space, additional configuration and boot command are also updated according to move each FIT image before its booting.

In addition, the common code of FIT image hash algorithm lookup is also revised to leverage the HW accelerated calculation.

v8:
- include reviewers' tag
- address comments suggested by Joel
- move this patch series back to the master branch as DM_HASH has been merged

v7:
- fix missing interrupt status clear for ACRY RSA operation

v6:
- fix parameter comment for v5 update

v5:
- fix inconsistent parameter name due to parallel patch work

v4:
- add new DM_HASH based driver for Aspeed HACE
- remove SPL board init, which was originally used to probe non-DM HACE driver
- fix typo of ARCY to ACRY
- refactor defconfig based on the new Kconfig of U-Boot next branch

v3:
- add SW work around for HACE HW DMA issue by resetting HACE
- add reset control for HACE device tree node
- sync all of the HACE error message to use debug()

v2:
- update commit authors

Chia-Wei Wang (9):
image: fit: Fix parameter name for hash algorithm
aspeed: ast2600: Enlarge SRAM size
clk: ast2600: Add RSACLK control for ACRY
crypto: aspeed: Add AST2600 ACRY support
ARM: dts: ast2600: Add ACRY to device tree
ast2600: spl: Locate load buffer in DRAM space
configs: ast2600-evb: Enable SPL FIT support
configs: aspeed: Make EXTRA_ENV_SETTINGS board specific
configs: ast2600: Boot kernel FIT in DRAM

Joel Stanley (2):
clk: ast2600: Add YCLK control for HACE
ARM: dts: ast2600: Add HACE to device tree

Johnny Huang (1):
crypto: aspeed: Add AST2600 HACE support

 arch/arm/dts/ast2600-evb.dts                  |  10 +
 arch/arm/dts/ast2600.dtsi                     |  17 +
 arch/arm/include/asm/arch-aspeed/platform.h   |   2 +-
 .../arm/include/asm/arch-aspeed/scu_ast2600.h |   6 +-
 arch/arm/mach-aspeed/ast2600/spl.c            |   9 +-
 common/image-fit.c                            |   4 +-
 configs/evb-ast2600_defconfig                 |  22 +-
 drivers/clk/aspeed/clk_ast2600.c              |  46 +++
 drivers/crypto/Kconfig                        |   2 +
 drivers/crypto/Makefile                       |   1 +
 drivers/crypto/aspeed/Kconfig                 |  20 +
 drivers/crypto/aspeed/Makefile                |   2 +
 drivers/crypto/aspeed/aspeed_acry.c           | 190 +++++++++
 drivers/crypto/aspeed/aspeed_hace.c           | 381 ++++++++++++++++++
 drivers/crypto/hash/Kconfig                   |   8 +
 include/configs/aspeed-common.h               |   9 -
 include/configs/evb_ast2500.h                 |   7 +
 include/configs/evb_ast2600.h                 |  14 +
 lib/rsa/Kconfig                               |  10 +-
 19 files changed, 733 insertions(+), 27 deletions(-)
 create mode 100644 drivers/crypto/aspeed/Kconfig
 create mode 100644 drivers/crypto/aspeed/Makefile
 create mode 100644 drivers/crypto/aspeed/aspeed_acry.c
 create mode 100644 drivers/crypto/aspeed/aspeed_hace.c
Signature · 1 line
2.25.1