btrfs: support idmapped mounts
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest21 patches 10 repliesIn review
- v321 patches 6 repliesSuperseded
- v221 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 24 patches | 6 replies | Superseded |
Patches in v4 No applies recorded yet
Reviews trailers per patch
20 of 21 patches have a Reviewed-by or Acked-by.
| Patch | Josef Bacik | Qu Wenruo | Christoph Hellwig |
|---|---|---|---|
| 1/21 | R-b | R-b | |
| 2/21 | R-b | ||
| 3/21 | R-b | ||
| 4/21 | R-b | ||
| 5/21 | R-b | ||
| 6/21 | R-b | ||
| 7/21 | R-b | ||
| 8/21 | R-b | ||
| 9/21 | R-b | ||
| 10/21 | R-b | ||
| 11/21 | R-b | ||
| 12/21 | R-b | ||
| 13/21 | R-b | ||
| 14/21 | R-b | R-b | |
| 15/21 | R-b | R-b | |
| 16/21 | R-b | ||
| 17/21 | R-b | ||
| 18/21 | R-b | ||
| 19/21 | R-b | ||
| 20/21 | R-b | ||
| 21/21 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 00/21] btrfs: support idmapped mounts
From: Christian Brauner <[email protected]>
Hey everyone,
/* v4 */
Rename new helper to lookup_one() and add new Reviewed-bys.
This series enables the creation of idmapped mounts on btrfs. On the list of filesystems btrfs was pretty high-up and requested quite often from userspace (cf. [1]). This series requires just a few changes to the vfs for specific lookup helpers that btrfs relies on to perform permission checking when looking up an inode. The changes are required to port some other filesystem as well.
The conversion of the necessary btrfs internals was fairly straightforward. No invasive changes were needed. I've decided to split up the patchset into very small individual patches. This hopefully makes the series more readable and fairly easy to review. The overall changeset is quite small.
All non-filesystem wide ioctls that peform permission checking based on inodes can be supported on idmapped mounts. There are really just a few restrictions. This should really only affect the deletion of subvolumes by subvolume id which can be used to delete any subvolume in the filesystem even though the caller might not even be able to see the subvolume under their mount. Other than that behavior on idmapped and non-idmapped mounts is identical for all enabled ioctls. People interested in idmappings on idmapped mounts should read [2].
The changeset has an associated new testsuite specific to btrfs. The core vfs operations that btrfs implements are covered by the generic idmapped mount testsuite. For the ioctls a new testsuite was added. It is sent alongside this patchset for ease of review but will very likely be merged independent of it.
All patches are based on v5.14-rc3.
The series can be pulled from:
https://git.kernel.org/brauner/h/fs.idmapped.btrfs
https://github.com/brauner/linux/tree/fs.idmapped.btrfs
The xfstests can be pulled from:
https://git.kernel.org/brauner/xfstests-dev/h/fs.idmapped.btrfs
https://github.com/brauner/xfstests/tree/fs.idmapped.btrfs
Note, the new btrfs xfstests patch is on top of a branch of mine containing a few more preliminary patches. So if you want to run the tests, please simply pull the branch and build from there.
The series has been tested with xfstests including the newly added btrfs specific test. All tests pass.
There were three unrelated failures that I observed: btrfs/219, btrfs/2020 and btrfs/235. All three also fail on earlier kernels without the patch series applied.
Thanks!
Christian
[1]: https://github.com/systemd/systemd/pull/19438#discussion_r622807165
[2]: https://lore.kernel.org/linux-fsdevel/[email protected]
Summary changelog. Please individual patches for full changelogs.
/* v3 */
- base: v5.14-rc3
- Added Josef's Reviewed-by's (Thank you!)
- Switched subvolume/snapshot deletion error code (David)
Christian Brauner (20):
namei: add mapping aware lookup helper
btrfs/inode: handle idmaps in btrfs_new_inode() btrfs/inode: allow idmapped rename iop
btrfs/inode: allow idmapped getattr iop
btrfs/inode: allow idmapped mknod iop
btrfs/inode: allow idmapped create iop
btrfs/inode: allow idmapped mkdir iop
btrfs/inode: allow idmapped symlink iop
btrfs/inode: allow idmapped tmpfile iop
btrfs/inode: allow idmapped setattr iop
btrfs/inode: allow idmapped permission iop
btrfs/ioctl: check whether fs{g,u}id are mapped during subvolume
creation
btrfs/inode: allow idmapped BTRFS_IOC_{SNAP,SUBVOL}_CREATE{_V2} ioctl btrfs/ioctl: allow idmapped BTRFS_IOC_SNAP_DESTROY{_V2} ioctl btrfs/ioctl: relax restrictions for BTRFS_IOC_SNAP_DESTROY_V2 with
subvolids
btrfs/ioctl: allow idmapped BTRFS_IOC_SET_RECEIVED_SUBVOL{_32} ioctl btrfs/ioctl: allow idmapped BTRFS_IOC_SUBVOL_SETFLAGS ioctl btrfs/ioctl: allow idmapped BTRFS_IOC_INO_LOOKUP_USER ioctl btrfs/acl: handle idmapped mounts
btrfs/super: allow idmapped btrfs
fs/btrfs/acl.c | 11 ++--- fs/btrfs/ctree.h | 3 +- fs/btrfs/inode.c | 62 +++++++++++++++------------- fs/btrfs/ioctl.c | 94 ++++++++++++++++++++++++++++--------------- fs/btrfs/super.c | 2 +- fs/namei.c | 43 +++++++++++++++++--- include/linux/namei.h | 2 + 7 files changed, 145 insertions(+), 72 deletions(-)
base-commit: ff1176468d368232b684f75e82563369208bc371
Signature · 1 line
2.30.2