Skip to content

perf cs-etm: Support TRBE (unformatted decoding)

James Clark linux-arm-kernel linux-perf-users lkml 2 versions – Applied

Status from this message: Thanks, applied to perf/core.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 2 repliesApplied
  2. v16 patches 8 repliesSuperseded

Changes in v2 from the cover letter

* Change 'decoders_per_cpu' variable name to 'decoders' and add a comment
* Add a warning that piped mode is best effort, suggested by Suzuki

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6perf cs-etm: Refactor initialisation of kernel start addresstools/perf/util/cs-etm.c+1 -50 replies
2/6perf cs-etm: Split setup and timestamp search functionstools/perf/util/cs-etm.c+29 -120 replies
3/6perf cs-etm: Only setup queues when they are modifiedtools/perf/util/cs-etm.c+14 -400 replies
4/6perf cs-etm: Suppress printing when resetting decodertools/perf/util/cs-etm-decoder/cs-etm-decoder.c+7 -30 replies
5/6perf cs-etm: Use existing decoder instead of resetting ittools/perf/util/cs-etm.c+7 -300 replies
6/6perf cs-etm: Pass unformatted flag to decodertools/perf/util/cs-etm-decoder/cs-etm-decoder.c tools/perf/util/cs-etm.c+42 -152 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchMathieu Poirier
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] perf cs-etm: Support TRBE (unformatted decoding)

This patchset consists of refactoring to allow the decoder to be created in advance when the AUX records are iterated over. The AUX record flags are used to communicate whether the data is formatted or not which is the reason this refactoring is required.

These changes result in some simplifications, removal of early exit conditions etc.

A change was also made to --dump-raw-trace code to allow the formatted/unformatted status to persist and for the decoder to not be continually deleted and recreated.

The changes apply on top of the previous patchset "[PATCH v7 0/2] perf
cs-etm: Split Coresight decode by aux records".

Changes since v1:
* Change 'decoders_per_cpu' variable name to 'decoders' and add a comment
* Add a warning that piped mode is best effort, suggested by Suzuki

James Clark (6):
perf cs-etm: Refactor initialisation of kernel start address perf cs-etm: Split setup and timestamp search functions perf cs-etm: Only setup queues when they are modified perf cs-etm: Suppress printing when resetting decoder perf cs-etm: Use existing decoder instead of resetting it perf cs-etm: Pass unformatted flag to decoder

 .../perf/util/cs-etm-decoder/cs-etm-decoder.c |  14 +-
 tools/perf/util/cs-etm.c                      | 185 +++++++++---------
 2 files changed, 97 insertions(+), 102 deletions(-)
Signature · 1 line
2.28.0