Skip to content

plugins/cache: multicore cache modelling and minor tweaks

Mahmoud Mandour qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 1 replyIn review
  2. v25 patches 0 repliesSuperseded
  3. v16 patches 10 repliesApplied

Changes in v3 from the cover letter

1. Included the link of the patch solving the race.
2. Fixed the title so that the series appears in Patchew.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5plugins/cache: Fixed a bug with destroying FIFO metadatacontrib/plugins/cache.c+1 -10 replies
2/5plugins/cache: limited the scope of a mutex lockcontrib/plugins/cache.c+1 -20 replies
3/5plugins/cache: Supported multicore cache modellingcontrib/plugins/cache.c+119 -350 replies
4/5docs/devel/tcg-plugins: added cores arg to cache plugindocs/devel/tcg-plugins.rst+8 -50 replies
5/5plugins/cache: Fixed "function decl. is not a prototype" warningscontrib/plugins/cache.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] plugins/cache: multicore cache modelling and minor tweaks

Hello,

This series introduce some minor improvements/bug fixes in the cache plugins and multicore cache modelling.

Multi-core cache modelling is handled such that for full-system emulation, a private L1 cache is maintained to each core available to the system. For multi-threaded userspace emulation, a static number of cores is maintained for the overall system, and every memory access go through one of these, even if the number of fired threads is more than that number.

Also, raising the levels of warnings induced some warnings, this is fixed in it's own patch.

Patches that still need review (other patches are already queued):
1. plugins/cache: Supported multicore cache modelling
2. docs/devel/tcg-plugins: added cores arg to cache plugin

v2 -> v3:
1. Included the link of the patch solving the race.
2. Fixed the title so that the series appears in Patchew.

v1 -> v2:
1. Dropped the patch with mitigating the use-after-free bug since it's not needed anymore (fixed by Alex Bennée here <[email protected]> with patch name:
tcg/plugins: implement a qemu_plugin_user_exit helper)
2. Summed cache performance data as a post-processing step.
3. Refactored appending core data to it's own function

Mahmoud Mandour (5):
plugins/cache: Fixed a bug with destroying FIFO metadata plugins/cache: limited the scope of a mutex lock plugins/cache: Supported multicore cache modelling docs/devel/tcg-plugins: added cores arg to cache plugin plugins/cache: Fixed "function decl. is not a prototype" warnings

 contrib/plugins/cache.c    | 165 ++++++++++++++++++++++++++++---------
 docs/devel/tcg-plugins.rst |  13 +--
 2 files changed, 132 insertions(+), 46 deletions(-)
Signature · 1 line
2.25.1