Skip to content

RFC Simplify the print format string with new '%pD'

Jia He linux-ext4 linux-fsdevel linux-mm linux-nfs linux-raid linux-s390 linux-unionfs linux-usb linux-xfs lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest13 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13s390/hmcdrv: remove the redundant directory path in format stringdrivers/s390/char/hmcdrv_dev.c+5 -50 replies
2/13afs: Remove the number postfix of '%pD' in format stringfs/afs/mntpt.c+1 -10 replies
3/13fs: Remove the number postfix of '%pD' in format stringfs/exec.c fs/ioctl.c fs/read_write.c +1 more+4 -40 replies
4/13NFS: Remove the number postfix of '%pD' in format stringfs/nfs/dir.c fs/nfs/direct.c fs/nfs/file.c +2 more+23 -230 replies
5/13NFSD: Remove the number postfix of '%pD' in format stringfs/nfsd/nfs4state.c+1 -10 replies
6/13ovl: remove the number postfix of '%pD' in format stringfs/overlayfs/file.c+1 -10 replies
7/13iomap: simplify iomap_swapfile_fail() with '%pD' specifierfs/iomap/direct-io.c fs/iomap/swapfile.c+2 -83 replies
8/13fs/coredump: simplify the printing with '%pD' and '%pd' specifierfs/coredump.c+4 -220 replies
9/13mm/filemap: simplify the printing with '%pD' specifiermm/filemap.c+1 -60 replies
10/13usb: gadget: simplify the printing with '%pD' specifierdrivers/usb/gadget/function/f_mass_storage.c+11 -172 replies
11/13md/bitmap: simplify the printing with '%pD' specifierdrivers/md/md-bitmap.c+2 -112 replies
12/13mm: simplify the printing with '%pd' specifiermm/memory.c+6 -100 replies
13/13ext4: simplify the printing with '%pD' specifierfs/ext4/super.c+4 -80 replies

Reviews trailers per patch

3 of 13 patches have a Reviewed-by or Acked-by.

PatchFelipe BalbiGreg Kroah-HartmanDarrick J. WongSong Liu
1/13
2/13
3/13
4/13
5/13
6/13
7/13A-b
8/13
9/13
10/13A-b R-b
11/13A-b
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH RFC 00/13] Simplify the print format string with new '%pD'

This is the followup work after changing the behavior of '%pD' to print the full path of file.

Background
==========
Linus suggested printing the full path of file instead of printing the components as '%pd'.

This series is based on my patch series of making '%pD' print the full path of file [1], which is stable now.

[1]: https://lkml.org/lkml/2021/7/14/1519

Test
====
I only tested it with basic compilation and booting. All the changed codes are compiled and built successfully on Arm64. Therefore set it as RFC.

Patch details
=============
Patches 01 to 06 with minor changes are easy for review. They are to remove the hard coding and the postfix number of previous '%pD'. This should be removed after the '%pD' behavior is changed.

Patches 07 to 13 are changed to simplify the printing helpers.

Jia He (13):
s390/hmcdrv: remove the redundant directory path in format string
afs: Remove the number postfix of '%pD' in format string
fs: Remove the number postfix of '%pD' in format string
NFS: Remove the number postfix of '%pD' in format string
NFSD: Remove the number postfix of '%pD' in format string
ovl: remove the number postfix of '%pD' in format string
iomap: simplify iomap_swapfile_fail() with '%pD' specifier fs/coredump: simplify the printing with '%pD' and '%pd' specifier mm/filemap: simplify the printing with '%pD' specifier
usb: gadget: simplify the printing with '%pD' specifier md/bitmap: simplify the printing with '%pD' specifier
mm: simplify the printing with '%pd' specifier
ext4: simplify the printing with '%pD' specifier

 drivers/md/md-bitmap.c                       | 13 ++-------
 drivers/s390/char/hmcdrv_dev.c               | 10 +++----
 drivers/usb/gadget/function/f_mass_storage.c | 28 ++++++++------------
 fs/afs/mntpt.c                               |  2 +-
 fs/coredump.c                                | 26 +++---------------
 fs/exec.c                                    |  2 +-
 fs/ext4/super.c                              | 12 +++------
 fs/ioctl.c                                   |  2 +-
 fs/iomap/direct-io.c                         |  2 +-
 fs/iomap/swapfile.c                          |  8 +-----
 fs/nfs/dir.c                                 | 12 ++++-----
 fs/nfs/direct.c                              |  4 +--
 fs/nfs/file.c                                | 26 +++++++++---------
 fs/nfs/nfs4file.c                            |  2 +-
 fs/nfs/write.c                               |  2 +-
 fs/nfsd/nfs4state.c                          |  2 +-
 fs/overlayfs/file.c                          |  2 +-
 fs/read_write.c                              |  2 +-
 fs/splice.c                                  |  2 +-
 mm/filemap.c                                 |  7 +----
 mm/memory.c                                  | 16 +++++------
 21 files changed, 65 insertions(+), 117 deletions(-)
Signature · 1 line
2.17.1