Skip to content

drm/msm: Add Display Stream Compression Support

Vinod Koul dri-devel linux-arm-msm lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest14 patches 1 replyIn review
  2. v614 patches 4 repliesSuperseded
  3. v513 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v4 posting 2/213 patches50 repliesSuperseded
v4 posting 1/213 patches1 replySuperseded
v313 patches26 repliesSuperseded
v211 patches23 repliesSuperseded
v111 patches27 repliesSuperseded

Changes in v7 from the cover letter

- Fix warning reported by kbuild bot
- Add r-b by Dmitry

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/msm/dsi: add support for dsc datadrivers/gpu/drm/msm/dsi/dsi_host.c drivers/gpu/drm/msm/msm_drv.h+136 -00 replies
2/14drm/msm/dsi: Pass DSC params to drm_paneldrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c drivers/gpu/drm/msm/dsi/dsi.c +4 more+45 -00 replies
3/14drm/msm/disp/dpu1: Add support for DSCdrivers/gpu/drm/msm/Makefile drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c +2 more+322 -00 replies
4/14drm/msm/disp/dpu1: Add support for DSC in pingpong blockdrivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h+46 -00 replies
5/14drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalogdrivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c+20 -00 replies
6/14drm/msm/disp/dpu1: Add DSC support in hw_ctldrivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h+12 -10 replies
7/14drm/msm/disp/dpu1: Add support for DSC in encoderdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h+135 -10 replies
8/14drm/msm/dpu: don't use merge_3d if DSC merge topology is useddrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h+25 -11 reply
9/14drm/msm: Add missing num_dspp field documentationdrivers/gpu/drm/msm/msm_drv.h+1 -00 replies
10/14drm/msm/disp/dpu1: Add support for DSC in topologydrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/msm_drv.h+15 -00 replies
11/14drm/msm/disp/dpu1: Add DSC support in RMdrivers/gpu/drm/msm/disp/dpu1/dpu_kms.h drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h+58 -00 replies
12/14drm/msm/dsi: add mode valid callback for dsi_mgrdrivers/gpu/drm/msm/dsi/dsi.h drivers/gpu/drm/msm/dsi/dsi_host.c drivers/gpu/drm/msm/dsi/dsi_manager.c+40 -00 replies
13/14drm/msm: Update generated headersdrivers/gpu/drm/msm/dsi/dsi.xml.h+80 -00 replies
14/14drm/msm/dsi: Add support for DSC configurationdrivers/gpu/drm/msm/dsi/dsi_host.c+97 -10 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchDmitry BaryshkovAbhinav Kumar
1/14R-b R-b
2/14R-b
3/14R-b
4/14R-b R-b
5/14R-b R-b
6/14R-b R-b
7/14R-b R-b
8/14R-b
9/14R-b R-b
10/14R-b
11/14R-b R-b
12/14R-b R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 00/14] drm/msm: Add Display Stream Compression Support

Display Stream Compression (DSC) compresses the display stream in host which is later decoded by panel. This series enables this for Qualcomm msm driver. This was tested on Google Pixel3 phone which use LGE SW43408 panel.

The changes include DSC data and hardware block enabling for DPU1 then support in encoder. We also add support in DSI and introduce required topology changes.

In order for panel to set the DSC parameters we add dsc in drm_panel and pass the dsc configuration from the panel driver

Complete changes which enable this for Pixel3 along with panel driver (not part of this series) and DT changes can be found at:
git.linaro.org/people/vinod.koul/kernel.git pixel/dsc_v7

Comments welcome!

Changes since v6:
- Fix warning reported by kbuild bot
- Add r-b by Dmitry

Changes since v5:
- rebase on msm-next
- use generated header patch from mesa for dsc registers
- use generated header macros for dsc register calculation
- remove msm dsc struct (Dmitry)

Changes since v4:
- Use new apprach based on Abhinav suggestion for dsc with 3d-merge
- Make common function for dsc timing caln and call that from video and cmd mode
- update description for patch "Pass DSC params to drm_panel"
- update couple of typos as pointed by Marijn
- drop dpu_encoder_dsc_pclk_param_calc() as that was duplicating the caln done in dsi timing
- Update copyright to 2022 to new files
- Update Abhinav's email to new quic one

Changes since v3:
- Merge changes from Dmitry to have dsc per encoder instance
- add warning for dsc and mode3d enabled together
- set dsc in dpu_encoder_phys_vid as well
- remove dsc hardcoded mask
- use devm_kzalloc for memory allocation for dsc

Changes since v2:
- Fix comments by Dimitry except the dsc being global.
- Move RM patch later for dependency on topology now
- Add patch for mode valid callback for dsi_mgr
- Add missing structure documentation patch
- Fix errors in mode_3d changes
- Rebase on v5.16-rc1 and test

Changes since v1:
- Fix various issues spotted by kbuildbot
- Rebase to v5.15-rc3
- Remove unused fields and duplicate defines
- Enable DSC blocks only when DSC is enabled
- remove sdm845 feature mask, use 0
- Check for DSC in hw_ctl

Changes since RFC:
- Drop the DT binding patch as we derive the configuration from panel
- Drop the drm api patch as we no longer need it (use pps drm api)
- Fix comments raised by Dimitry
- Add dsc parameters calculation from downstream

Dmitry Baryshkov (1):
drm/msm/dpu: don't use merge_3d if DSC merge topology is used

Vinod Koul (13):
drm/msm/dsi: add support for dsc data drm/msm/dsi: Pass DSC params to drm_panel drm/msm/disp/dpu1: Add support for DSC drm/msm/disp/dpu1: Add support for DSC in pingpong block drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog drm/msm/disp/dpu1: Add DSC support in hw_ctl drm/msm/disp/dpu1: Add support for DSC in encoder drm/msm: Add missing num_dspp field documentation drm/msm/disp/dpu1: Add support for DSC in topology drm/msm/disp/dpu1: Add DSC support in RM drm/msm/dsi: add mode valid callback for dsi_mgr drm/msm: Update generated headers
drm/msm/dsi: Add support for DSC configuration

 drivers/gpu/drm/msm/Makefile                  |   1 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   | 157 +++++++++-
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h   |   8 +
 .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h  |  12 +-
 .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    |  20 ++
 .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h    |  13 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c    |  11 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h    |   2 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c    | 215 ++++++++++++++
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h    |  80 +++++
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h   |  13 +
 .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c   |  32 ++
 .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h   |  14 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |   2 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h       |   1 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c        |  56 ++++
 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h        |   1 +
 drivers/gpu/drm/msm/dsi/dsi.c                 |   5 +
 drivers/gpu/drm/msm/dsi/dsi.h                 |   3 +
 drivers/gpu/drm/msm/dsi/dsi.xml.h             |  80 +++++
 drivers/gpu/drm/msm/dsi/dsi_host.c            | 276 +++++++++++++++++-
 drivers/gpu/drm/msm/dsi/dsi_manager.c         |  12 +
 drivers/gpu/drm/msm/msm_drv.h                 |  15 +
 include/drm/drm_panel.h                       |   7 +
 24 files changed, 1032 insertions(+), 4 deletions(-)
 create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c
 create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h
Signature · 1 line
2.34.1