i3c: master: svc: some bug fixes and add runtime pm support
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest8 patches 2 repliesApplied
- v48 patches 5 repliesSuperseded
- v35 patches 0 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 5 patches | 2 replies | Superseded | |
| v1 | 4 patches | 8 replies | Superseded |
Changes in v5 from the cover letter
- i3c: master: svc: add support for slave to stop returning data
- remove <%s> in logs
- add some spaces
- !SVC_I3C_MSTATUS_STATE(reg) -> SVC_I3C_MSTATUS_STATE_IDLE(reg)
- i3c: master: svc: add runtime pm support
- create svc_i3c_master_prepare_clks() and svc_i3c_master_unprepare_clks()
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | i3c: master: svc: move module reset behind clk enabledrivers/ | +2 | 0 replies | |
| 2/8 | i3c: master: svc: fix atomic issuedrivers/ | +15 | 0 replies | |
| 3/8 | i3c: master: svc: separate err, fifo and disable interrupt of reset functiondrivers/ | +34 | 0 replies | |
| 4/8 | i3c: master: svc: add support for slave to stop returning datadrivers/ | +40 | 1 reply | |
| 5/8 | i3c: master: svc: set ODSTOP to let I2C device see the STOP signaldrivers/ | +5 | 0 replies | |
| 6/8 | i3c: master: svc: add runtime pm supportdrivers/ | +156 | 0 replies | |
| 7/8 | i3c: master: svc: add the missing module device tabledrivers/ | +1 | 0 replies | |
| 8/8 | i3c: master: svc: enable the interrupt in the enable ibi functiondrivers/ | +4 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Miquel Raynal | Jun Li |
|---|---|---|
| 1/8 | R-b | R-b |
| 2/8 | R-b | R-b |
| 3/8 | R-b | R-b |
| 4/8 | R-b | R-b |
| 5/8 | R-b | R-b |
| 6/8 | R-b | R-b |
| 7/8 | R-b | R-b |
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH V5 0/8] i3c: master: svc: some bug fixes and add runtime pm support
Hi Miquel,
Currently, only the fourth patch needs to be reviewed, and the rest have been added with your review tag.
Thank you very much for your comments! :)
V5 changes:
- i3c: master: svc: add support for slave to stop returning data
- remove <%s> in logs
- add some spaces
- !SVC_I3C_MSTATUS_STATE(reg) -> SVC_I3C_MSTATUS_STATE_IDLE(reg)
- i3c: master: svc: add runtime pm support
- create svc_i3c_master_prepare_clks() and svc_i3c_master_unprepare_clks()
V4 changes:
- New patches:
- i3c: master: svc: separate err, fifo and disable interrupt of reset function
- i3c: master: svc: add the missing module device table
- i3c: master: svc: enable the interrupt in the enable ibi function
- i3c: master: svc: add support for slave to stop returning data
- Only use COMPLETE flag in the read function.
- Add a reset before each transfer.
- i3c: master: svc: add runtime pm support
- error path emit_stop only used in svc_i3c_master_do_daa() for one time, so remove it. Or it needs another goto command at the end of the function to skip it and to go to rpm_out.
V3 changes:
- i3c: master: svc: add runtime pm support:
- restore the error path of probe function
- enable runtime pm just before i3c module reset
V2 changes:
- align the parameters of the function in the second patch
- add a new patch to support runtime PM.
Clark Wang (8):
i3c: master: svc: move module reset behind clk enable
i3c: master: svc: fix atomic issue
i3c: master: svc: separate err, fifo and disable interrupt of reset
function
i3c: master: svc: add support for slave to stop returning data
i3c: master: svc: set ODSTOP to let I2C device see the STOP signal
i3c: master: svc: add runtime pm support
i3c: master: svc: add the missing module device table
i3c: master: svc: enable the interrupt in the enable ibi function
drivers/i3c/master/svc-i3c-master.c | 341 ++++++++++++++++++++-------- 1 file changed, 250 insertions(+), 91 deletions(-)
Signature · 1 line
2.25.1