Skip to content

RFC block: enhance use of GENHD_FL_UP

Luis Chamberlain linux-block lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6genhd: update docs for GENHD_FL_UPinclude/linux/genhd.h+1 -12 replies
2/6block: add flag for add_disk() completion notationblock/genhd.c include/linux/genhd.h+18 -14 replies
3/6md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken()drivers/md/md.h+1 -13 replies
4/6mmc/core/block: replace GENHD_FL_UP with GENHD_FL_DISK_ADDEDdrivers/mmc/core/block.c+1 -11 reply
5/6nvme: replace GENHD_FL_UP with GENHD_FL_DISK_ADDEDdrivers/nvme/host/core.c drivers/nvme/host/multipath.c+3 -31 reply
6/6fs/block_dev: replace GENHD_FL_UP with GENHD_FL_DISK_ADDEDfs/block_dev.c+3 -20 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchHannes Reinecke
1/6R-b
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/6] block: enhance use of GENHD_FL_UP

This is the second group of patches which I'd like some review on as part of the *add_disk*() error handling conversion. While converting drivers to add error handling, I noticed some were using the flag GENHD_FL_UP to see if a block device is ready, or for bringing a device down, so to call del_gendisk() safely. This first group of patches just address the few areas where the flag is used directly.

Direct use of the flag GENHD_FL_UP is useful but incorrect as we can add the flag in a gendisk left half built. Instead, add a flag to actually represent the desired goal.

The next group will deal with the use of the flag for del_gendisk().

Luis Chamberlain (6):
genhd: update docs for GENHD_FL_UP
block: add flag for add_disk() completion notation
md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken() mmc/core/block: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED
nvme: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED fs/block_dev: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED

 block/genhd.c                 |  8 ++++++++
 drivers/md/md.h               |  2 +-
 drivers/mmc/core/block.c      |  2 +-
 drivers/nvme/host/core.c      |  4 ++--
 drivers/nvme/host/multipath.c |  2 +-
 fs/block_dev.c                |  5 +++--
 include/linux/genhd.h         | 13 +++++++++++--
 7 files changed, 27 insertions(+), 9 deletions(-)
Signature · 1 line
2.27.0