RFC block: enhance use of GENHD_FL_UP
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest6 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | genhd: update docs for GENHD_FL_UPinclude/ | +1 | 2 replies | |
| 2/6 | block: add flag for add_disk() completion notationblock/ include/ | +18 | 4 replies | |
| 3/6 | md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken()drivers/ | +1 | 3 replies | |
| 4/6 | mmc/core/block: replace GENHD_FL_UP with GENHD_FL_DISK_ADDEDdrivers/ | +1 | 1 reply | |
| 5/6 | nvme: replace GENHD_FL_UP with GENHD_FL_DISK_ADDEDdrivers/ drivers/ | +3 | 1 reply | |
| 6/6 | fs/block_dev: replace GENHD_FL_UP with GENHD_FL_DISK_ADDEDfs/ | +3 | 0 replies |
Reviews trailers per patch
1 of 6 patches has a Reviewed-by or Acked-by.
| Patch | Hannes Reinecke |
|---|---|
| 1/6 | R-b |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC 0/6] block: enhance use of GENHD_FL_UP
This is the second group of patches which I'd like some review on as part of the *add_disk*() error handling conversion. While converting drivers to add error handling, I noticed some were using the flag GENHD_FL_UP to see if a block device is ready, or for bringing a device down, so to call del_gendisk() safely. This first group of patches just address the few areas where the flag is used directly.
Direct use of the flag GENHD_FL_UP is useful but incorrect as we can add the flag in a gendisk left half built. Instead, add a flag to actually represent the desired goal.
The next group will deal with the use of the flag for del_gendisk().
Luis Chamberlain (6):
genhd: update docs for GENHD_FL_UP
block: add flag for add_disk() completion notation
md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken() mmc/core/block: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED
nvme: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED fs/block_dev: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED
block/genhd.c | 8 ++++++++ drivers/md/md.h | 2 +- drivers/mmc/core/block.c | 2 +- drivers/nvme/host/core.c | 4 ++-- drivers/nvme/host/multipath.c | 2 +- fs/block_dev.c | 5 +++-- include/linux/genhd.h | 13 +++++++++++-- 7 files changed, 27 insertions(+), 9 deletions(-)
Signature · 1 line
2.27.0