Skip to content

OCC: fsi and hwmon: Set sequence number in submit interface

Eddie James linux-hwmon lkml openbmc 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- fix 0day warnings and errors.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fsi: occ: Force sequence numbering per OCCdrivers/fsi/fsi-occ.c+37 -170 replies
2/3hwmon: (occ) Remove sequence numbering and checksum calculationdrivers/hwmon/occ/common.c drivers/hwmon/occ/common.h drivers/hwmon/occ/p8_i2c.c +1 more+24 -280 replies
3/3fsi: occ: Add dynamic debug to dump command and responsedrivers/fsi/fsi-occ.c+45 -00 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchJoel StanleyGuenter Roeck
1/3R-b
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] OCC: fsi and hwmon: Set sequence number in submit interface

Conflicting sequence numbers have resulted in users of the OCC interface getting the wrong response. For example, both the hwmon driver and an application might send a transfer near the same time with the same sequence number, and then one or both will get an incorrect respnse, but cannot tell because the sequence number looks correct.
Perform the sequence numbering in the submit interface to make sure each transfer has a unique sequence number. This also requires that the submit interface perform the checksum calculation for the command. Adjust the hwmon driver accordingly too.

Changes since v1:
- fix 0day warnings and errors.

Eddie James (3):
fsi: occ: Force sequence numbering per OCC
hwmon: (occ) Remove sequence numbering and checksum calculation
fsi: occ: Add dynamic debug to dump command and response

 drivers/fsi/fsi-occ.c      | 99 +++++++++++++++++++++++++++++++-------
 drivers/hwmon/occ/common.c | 30 +++++-------
 drivers/hwmon/occ/common.h |  3 +-
 drivers/hwmon/occ/p8_i2c.c | 15 +++---
 drivers/hwmon/occ/p9_sbe.c |  4 +-
 5 files changed, 106 insertions(+), 45 deletions(-)
Signature · 1 line
2.27.0