Skip to content

GuC submission support

Matthew Brost dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest51 patches 58 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/51drm/i915/guc: Add new GuC interface defines and structuresdrivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h+55 -00 replies
2/51drm/i915/guc: Remove GuC stage descriptor, add LRC descriptordrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+25 -1160 replies
3/51drm/i915/guc: Add LRC descriptor context lookup arraydrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+35 -20 replies
4/51drm/i915/guc: Implement GuC submission taskletdrivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+127 -1173 replies
5/51drm/i915/guc: Add bypass tasklet submission path to GuCdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+29 -80 replies
6/51drm/i915/guc: Implement GuC context operations for new intefacedrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/intel_lrc_reg.h +5 more+685 -557 replies
7/51drm/i915/guc: Insert fence on context when deregisteringdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 more+63 -20 replies
8/51drm/i915/guc: Defer context unpin until scheduling is disableddrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_context_types.h +3 more+181 -40 replies
9/51drm/i915/guc: Disable engine barriers with GuC during unpindrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/selftest_context.c+11 -10 replies
10/51drm/i915/guc: Extend deregistration fence to schedule disabledrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+33 -70 replies
11/51drm/i915: Disable preempt busywait when using GuC schedulingdrivers/gpu/drm/i915/gt/gen8_engine_cs.c+4 -20 replies
12/51drm/i915/guc: Ensure request ordering via completion fencesdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/i915_request.c+10 -33 replies
13/51drm/i915/guc: Disable semaphores when using GuC schedulingdrivers/gpu/drm/i915/gem/i915_gem_context.c+4 -21 reply
14/51drm/i915/guc: Ensure G2H response has space in bufferdrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h +2 more+99 -260 replies
15/51drm/i915/guc: Update intel_gt_wait_for_idle to work with GuCdrivers/gpu/drm/i915/gem/i915_gem_mman.c drivers/gpu/drm/i915/gt/intel_gt.c drivers/gpu/drm/i915/gt/intel_gt.h +10 more+129 -283 replies
16/51drm/i915/guc: Update GuC debugfs to support new GuCdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h drivers/gpu/drm/i915/gt/uc/intel_guc_debugfs.c +2 more+107 -11 reply
17/51drm/i915/guc: Add several request trace pointsdrivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/i915_request.c drivers/gpu/drm/i915/i915_trace.h+45 -42 replies
18/51drm/i915: Add intel_context tracingdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/i915_trace.h+164 -00 replies
19/51drm/i915/guc: GuC virtual enginesdrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gem/i915_gem_context.h drivers/gpu/drm/i915/gt/intel_context_types.h +7 more+308 -354 replies
20/51drm/i915: Track 'serial' counts for virtual enginesdrivers/gpu/drm/i915/gt/intel_engine_types.h drivers/gpu/drm/i915/gt/intel_execlists_submission.c drivers/gpu/drm/i915/gt/intel_ring_submission.c +3 more+39 -13 replies
21/51drm/i915: Hold reference to intel_context over life of i915_requestdrivers/gpu/drm/i915/i915_request.c+23 -320 replies
22/51drm/i915/guc: Disable bonding extension with GuC submissiondrivers/gpu/drm/i915/gem/i915_gem_context.c+5 -00 replies
23/51drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbsdrivers/gpu/drm/i915/gt/intel_breadcrumbs.c drivers/gpu/drm/i915/gt/intel_breadcrumbs.h drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h +6 more+133 -373 replies
24/51drm/i915: Add i915_sched_engine destroy vfuncdrivers/gpu/drm/i915/i915_scheduler.c drivers/gpu/drm/i915/i915_scheduler.h drivers/gpu/drm/i915/i915_scheduler_types.h+8 -42 replies
25/51drm/i915: Move active request tracking to a vfuncdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/intel_engine_types.h +6 more+147 -371 reply
26/51drm/i915/guc: Reset implementation for new GuC interfacedrivers/gpu/drm/i915/gt/intel_gt_pm.c drivers/gpu/drm/i915/gt/intel_reset.c drivers/gpu/drm/i915/gt/uc/intel_guc.c +4 more+515 -1342 replies
27/51drm/i915: Reset GPU immediately if submission is disableddrivers/gpu/drm/i915/gt/intel_engine_heartbeat.c drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +3 more+80 -130 replies
28/51drm/i915/guc: Add disable interrupts to guc sanitizedrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_uc.c+19 -180 replies
29/51drm/i915/guc: Suspend/resume implementation for new interfacedrivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h drivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2 more+54 -510 replies
30/51drm/i915/guc: Handle context reset notificationdrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 more+51 -02 replies
31/51drm/i915/guc: Handle engine reset failure notificationdrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+48 -00 replies
32/51drm/i915/guc: Enable the timer expired interrupt for GuCdrivers/gpu/drm/i915/gt/intel_rps.c+4 -00 replies
33/51drm/i915/guc: Provide mmio list to be saved/restored on engine resetdrivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/gt/intel_workarounds_types.h drivers/gpu/drm/i915/gt/uc/intel_guc.h +2 more+222 -261 reply
34/51drm/i915/guc: Don't complain about reset racesdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_uc.c drivers/gpu/drm/i915/gt/uc/intel_uc.h+9 -10 replies
35/51drm/i915/guc: Enable GuC engine resetdrivers/gpu/drm/i915/gt/uc/intel_guc_ads.c+1 -20 replies
36/51drm/i915/guc: Capture error state on context resetdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_engine.h +4 more+91 -260 replies
37/51drm/i915/guc: Fix for error capture after full GPU reset with GuCdrivers/gpu/drm/i915/gt/intel_engine.h drivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c +6 more+229 -470 replies
38/51drm/i915/guc: Hook GuC scheduling policies updrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+49 -50 replies
39/51drm/i915/guc: Connect reset modparam updates to GuC policy flagsdrivers/gpu/drm/i915/gt/uc/intel_guc_ads.c drivers/gpu/drm/i915/i915_debugfs_params.c+32 -11 reply
40/51drm/i915/guc: Include scheduling policies in the debugfs state dumpdrivers/gpu/drm/i915/gt/uc/intel_guc_ads.c drivers/gpu/drm/i915/gt/uc/intel_guc_ads.h drivers/gpu/drm/i915/gt/uc/intel_guc_debugfs.c+19 -00 replies
41/51drm/i915/guc: Add golden context to GuC ADSdrivers/gpu/drm/i915/gt/intel_gt.c drivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc.h +4 more+199 -303 replies
42/51drm/i915/guc: Implement banned contexts for GuC submissiondrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_context_types.h +5 more+195 -371 reply
43/51drm/i915/guc: Support request cancellationdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_context_types.h +3 more+211 -132 replies
44/51drm/i915/selftest: Better error reporting from hangcheck selftestdrivers/gpu/drm/i915/gt/selftest_hangcheck.c+72 -171 reply
45/51drm/i915/selftest: Fix workarounds selftest for GuC submissiondrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gt/selftest_workarounds.c drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c +1 more+201 -341 reply
46/51drm/i915/selftest: Fix MOCS selftest for GuC submissiondrivers/gpu/drm/i915/gt/selftest_mocs.c+35 -141 reply
47/51drm/i915/selftest: Increase some timeouts in live_requestsdrivers/gpu/drm/i915/selftests/i915_request.c+2 -22 replies
48/51drm/i915/selftest: Fix hangcheck self test for GuC submissiondrivers/gpu/drm/i915/gt/intel_engine_types.h drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.h +6 more+237 -711 reply
49/51drm/i915/selftest: Bump selftest timeouts for hangcheckdrivers/gpu/drm/i915/gt/selftest_hangcheck.c drivers/gpu/drm/i915/selftests/igt_flush_test.c drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c+3 -32 replies
50/51drm/i915/guc: Implement GuC priority managementdrivers/gpu/drm/i915/gt/intel_breadcrumbs.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/intel_engine_user.c +7 more+274 -64 replies
51/51drm/i915/guc: Unblock GuC submission on Gen11+drivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 more+18 -70 replies

Reviews trailers per patch

44 of 51 patches have a Reviewed-by or Acked-by.

PatchJohn HarrisonMatthew Brost
1/51R-b
2/51R-b
3/51R-b
4/51
5/51R-b
6/51
7/51R-b
8/51R-b
9/51R-b
10/51R-b
11/51R-b
12/51
13/51R-b
14/51R-b
15/51R-b
16/51R-b
17/51R-b
18/51R-b
19/51
20/51R-b
21/51R-b
22/51R-b
23/51R-b
24/51R-b
25/51R-b
26/51
27/51R-b
28/51R-b
29/51R-b
30/51R-b
31/51R-b
32/51R-b
33/51R-b
34/51R-b
35/51R-b
36/51R-b
37/51R-b
38/51R-b
39/51R-b
40/51R-b
41/51R-b
42/51R-b
43/51
44/51R-b
45/51R-b
46/51R-b
47/51R-b
48/51R-b
49/51R-b
50/51
51/51R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/51] GuC submission support

As discussed in [1], [2] we are enabling GuC submission support in the i915. This is a subset of the patches in step 5 described in [1], basically it is absolute to enable CI with GuC submission on gen11+ platforms.

This series itself will likely be broken down into smaller patch sets to merge. Likely into CTBs changes, basic submission, virtual engines, and resets.

A following series will address the missing patches remaining from [1].

Locally tested on TGL machine and basic tests seem to be passing.

v2: Address all review comments in [3], include several more patches to make CI [4] happy.

[1] https://patchwork.freedesktop.org/series/89844/
[2] https://patchwork.freedesktop.org/series/91417/
[3] https://patchwork.freedesktop.org/series/91840/
[4] https://patchwork.freedesktop.org/series/91885/

Daniele Ceraolo Spurio (1):
drm/i915/guc: Unblock GuC submission on Gen11+

John Harrison (12):
drm/i915: Track 'serial' counts for virtual engines drm/i915/guc: Provide mmio list to be saved/restored on engine reset drm/i915/guc: Don't complain about reset races drm/i915/guc: Enable GuC engine reset
drm/i915/guc: Fix for error capture after full GPU reset with GuC drm/i915/guc: Hook GuC scheduling policies up drm/i915/guc: Connect reset modparam updates to GuC policy flags drm/i915/guc: Include scheduling policies in the debugfs state dump drm/i915/guc: Add golden context to GuC ADS drm/i915/selftest: Better error reporting from hangcheck selftest drm/i915/selftest: Fix hangcheck self test for GuC submission drm/i915/selftest: Bump selftest timeouts for hangcheck

Matthew Brost (36):
drm/i915/guc: Add new GuC interface defines and structures drm/i915/guc: Remove GuC stage descriptor, add LRC descriptor drm/i915/guc: Add LRC descriptor context lookup array drm/i915/guc: Implement GuC submission tasklet drm/i915/guc: Add bypass tasklet submission path to GuC drm/i915/guc: Implement GuC context operations for new inteface drm/i915/guc: Insert fence on context when deregistering drm/i915/guc: Defer context unpin until scheduling is disabled drm/i915/guc: Disable engine barriers with GuC during unpin drm/i915/guc: Extend deregistration fence to schedule disable drm/i915: Disable preempt busywait when using GuC scheduling drm/i915/guc: Ensure request ordering via completion fences drm/i915/guc: Disable semaphores when using GuC scheduling drm/i915/guc: Ensure G2H response has space in buffer drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC drm/i915/guc: Update GuC debugfs to support new GuC drm/i915/guc: Add several request trace points
drm/i915: Add intel_context tracing
drm/i915/guc: GuC virtual engines
drm/i915: Hold reference to intel_context over life of i915_request drm/i915/guc: Disable bonding extension with GuC submission drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbs drm/i915: Add i915_sched_engine destroy vfunc
drm/i915: Move active request tracking to a vfunc drm/i915/guc: Reset implementation for new GuC interface drm/i915: Reset GPU immediately if submission is disabled drm/i915/guc: Add disable interrupts to guc sanitize drm/i915/guc: Suspend/resume implementation for new interface drm/i915/guc: Handle context reset notification drm/i915/guc: Handle engine reset failure notification drm/i915/guc: Enable the timer expired interrupt for GuC drm/i915/guc: Capture error state on context reset drm/i915/guc: Implement banned contexts for GuC submission drm/i915/guc: Support request cancellation drm/i915/selftest: Increase some timeouts in live_requests drm/i915/guc: Implement GuC priority management

Rahul Kumar Singh (2):
drm/i915/selftest: Fix workarounds selftest for GuC submission drm/i915/selftest: Fix MOCS selftest for GuC submission

 drivers/gpu/drm/i915/Makefile                 |    1 +
 drivers/gpu/drm/i915/gem/i915_gem_context.c   |   21 +-
 drivers/gpu/drm/i915/gem/i915_gem_context.h   |    1 +
 drivers/gpu/drm/i915/gem/i915_gem_mman.c      |    3 +-
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c      |    6 +-
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c   |   44 +-
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.h   |   16 +-
 .../gpu/drm/i915/gt/intel_breadcrumbs_types.h |    7 +
 drivers/gpu/drm/i915/gt/intel_context.c       |   50 +-
 drivers/gpu/drm/i915/gt/intel_context.h       |   50 +-
 drivers/gpu/drm/i915/gt/intel_context_types.h |   63 +-
 drivers/gpu/drm/i915/gt/intel_engine.h        |   54 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  182 +-
 .../gpu/drm/i915/gt/intel_engine_heartbeat.c  |   71 +-
 .../gpu/drm/i915/gt/intel_engine_heartbeat.h  |    4 +
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |   13 +-
 drivers/gpu/drm/i915/gt/intel_engine_user.c   |    4 +
 .../drm/i915/gt/intel_execlists_submission.c  |   95 +-
 .../drm/i915/gt/intel_execlists_submission.h  |    4 -
 drivers/gpu/drm/i915/gt/intel_gt.c            |   21 +
 drivers/gpu/drm/i915/gt/intel_gt.h            |    2 +
 drivers/gpu/drm/i915/gt/intel_gt_pm.c         |    6 +-
 drivers/gpu/drm/i915/gt/intel_gt_requests.c   |   21 +-
 drivers/gpu/drm/i915/gt/intel_gt_requests.h   |    7 +-
 drivers/gpu/drm/i915/gt/intel_lrc_reg.h       |    1 -
 drivers/gpu/drm/i915/gt/intel_reset.c         |   50 +-
 .../gpu/drm/i915/gt/intel_ring_submission.c   |   48 +
 drivers/gpu/drm/i915/gt/intel_rps.c           |    4 +
 drivers/gpu/drm/i915/gt/intel_workarounds.c   |   46 +-
 .../gpu/drm/i915/gt/intel_workarounds_types.h |    1 +
 drivers/gpu/drm/i915/gt/mock_engine.c         |   40 +-
 drivers/gpu/drm/i915/gt/selftest_context.c    |   10 +
 .../drm/i915/gt/selftest_engine_heartbeat.c   |   22 +
 .../drm/i915/gt/selftest_engine_heartbeat.h   |    2 +
 drivers/gpu/drm/i915/gt/selftest_execlists.c  |   12 +-
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c  |  314 +-
 drivers/gpu/drm/i915/gt/selftest_mocs.c       |   50 +-
 .../gpu/drm/i915/gt/selftest_workarounds.c    |  132 +-
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   15 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   82 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |  101 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |  461 ++-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.h    |    4 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |  132 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h     |   16 +-
 .../gpu/drm/i915/gt/uc/intel_guc_debugfs.c    |   25 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h   |   88 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 2776 +++++++++++++++--
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h |   18 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |  101 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.h         |   11 +
 drivers/gpu/drm/i915/i915_debugfs_params.c    |   31 +
 drivers/gpu/drm/i915/i915_gem_evict.c         |    1 +
 drivers/gpu/drm/i915/i915_gpu_error.c         |   25 +-
 drivers/gpu/drm/i915/i915_reg.h               |    2 +
 drivers/gpu/drm/i915/i915_request.c           |  174 +-
 drivers/gpu/drm/i915/i915_request.h           |   29 +
 drivers/gpu/drm/i915/i915_scheduler.c         |   16 +-
 drivers/gpu/drm/i915/i915_scheduler.h         |   10 +-
 drivers/gpu/drm/i915/i915_scheduler_types.h   |   22 +
 drivers/gpu/drm/i915/i915_trace.h             |  219 +-
 drivers/gpu/drm/i915/selftests/i915_request.c |    4 +-
 .../gpu/drm/i915/selftests/igt_flush_test.c   |    2 +-
 .../gpu/drm/i915/selftests/igt_live_test.c    |    2 +-
 .../i915/selftests/intel_scheduler_helpers.c  |   89 +
 .../i915/selftests/intel_scheduler_helpers.h  |   35 +
 .../gpu/drm/i915/selftests/mock_gem_device.c  |    3 +-
 include/uapi/drm/i915_drm.h                   |    9 +
 68 files changed, 5119 insertions(+), 862 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c
 create mode 100644 drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.h
Signature · 1 line
2.28.0