KVM: Remove kvm_is_transparent_hugepage() and friends
Status from this message: Applied to next, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 7 repliesApplied
- v15 patches 12 repliesSuperseded
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | KVM: arm64: Introduce helper to retrieve a PTE and its levelarch/ arch/ | +58 | 3 replies | |
| 2/6 | KVM: arm64: Walk userspace page tables to compute the THP mapping sizearch/ | +30 | 1 reply | |
| 3/6 | KVM: arm64: Avoid mapping size adjustment on permission faultarch/ | +8 | 1 reply | |
| 4/6 | KVM: Remove kvm_is_transparent_hugepage() and PageTransCompoundMap()include/ virt/ | +0 | 0 replies | |
| 5/6 | KVM: arm64: Use get_page() instead of kvm_get_pfn()arch/ | +1 | 1 reply | |
| 6/6 | KVM: Get rid of kvm_get_pfn()include/ virt/ | +1 | 0 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Paolo Bonzini | Quentin Perret | Alexandru Elisei |
|---|---|---|---|
| 1/6 | R-b | R-b | |
| 2/6 | R-b | ||
| 3/6 | R-b | ||
| 4/6 | A-b | ||
| 5/6 | |||
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/6] KVM: Remove kvm_is_transparent_hugepage() and friends
A while ago, Willy and Sean pointed out[0] that arm64 is the last user of kvm_is_transparent_hugepage(), and that there would actually be some benefit in looking at the userspace mapping directly instead.
This small series does exactly that, although it doesn't try to support more than a PMD-sized mapping yet for THPs. We could probably look into unifying this with the huge PUD code, and there is still some potential use of the contiguous hint.
As a consequence, it removes kvm_is_transparent_hugepage(), PageTransCompoundMap() and kvm_get_pfn(), all of which have no user left after this rework.
This has been lightly tested on an Altra box (VHE) and on a SC2A11 system (nVHE). Although nothing caught fire, it requires some careful reviewing on the arm64 side.
* From v1 [1]:
- Move the PT helper into its own function, as both Quentin and I need it for other developments
- Fixed stupid bug introduced by a bad conflict resolution, spotted by Alexandru
- Collected Acks from Paolo, with thanks
[0] https://lore.kernel.org/r/[email protected]
[1] https://lore.kernel.org/r/[email protected]
Marc Zyngier (6):
KVM: arm64: Introduce helper to retrieve a PTE and its level
KVM: arm64: Walk userspace page tables to compute the THP mapping size
KVM: arm64: Avoid mapping size adjustment on permission fault
KVM: Remove kvm_is_transparent_hugepage() and PageTransCompoundMap()
KVM: arm64: Use get_page() instead of kvm_get_pfn()
KVM: Get rid of kvm_get_pfn()
arch/arm64/include/asm/kvm_pgtable.h | 19 ++++++++++++ arch/arm64/kvm/hyp/pgtable.c | 39 ++++++++++++++++++++++++ arch/arm64/kvm/mmu.c | 45 +++++++++++++++++++++++----- include/linux/kvm_host.h | 1 - include/linux/page-flags.h | 37 ----------------------- virt/kvm/kvm_main.c | 19 +----------- 6 files changed, 97 insertions(+), 63 deletions(-)
Signature · 1 line
2.30.2