Skip to content

Add support for ast2600 ADC

Billy Tsai linux-arm-kernel linux-aspeed linux-devicetree linux-iio lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest11 patches 1 replyIn review
  2. v611 patches 2 repliesSuperseded
  3. v515 patches 11 repliesApplied
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v4 posting 2/215 patches13 repliesSuperseded
v4 posting 1/29 of 15 patches3 repliesSuperseded
v39 of 15 patches1 replySuperseded
v28 patches12 repliesSuperseded
v17 patches1 replySuperseded

Changes in v7 from the cover letter

aspeed_adc.c:
- Fix the parameter error for aspeed_adc_unregister_fixed_divider.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11iio: adc: aspeed: Keep model data to driver data.drivers/iio/adc/aspeed_adc.c+7 -130 replies
2/11iio: adc: aspeed: Restructure the model datadrivers/iio/adc/aspeed_adc.c+15 -50 replies
3/11iio: adc: aspeed: Add vref config functiondrivers/iio/adc/aspeed_adc.c+17 -10 replies
4/11iio: adc: aspeed: Use model_data to set clk scaler.drivers/iio/adc/aspeed_adc.c+27 -160 replies
5/11iio: adc: aspeed: Use devm_add_action_or_reset.drivers/iio/adc/aspeed_adc.c+55 -580 replies
6/11iio: adc: aspeed: Support ast2600 adc.drivers/iio/adc/aspeed_adc.c+96 -50 replies
7/11iio: adc: aspeed: Fix the calculate error of clock.drivers/iio/adc/aspeed_adc.c+27 -00 replies
8/11iio: adc: aspeed: Add func to set sampling rate.drivers/iio/adc/aspeed_adc.c+39 -190 replies
9/11iio: adc: aspeed: Add compensation phase.drivers/iio/adc/aspeed_adc.c+53 -10 replies
10/11iio: adc: aspeed: Support battery sensing.drivers/iio/adc/aspeed_adc.c+78 -30 replies
11/11iio: adc: aspeed: Get and set trimming data.drivers/iio/adc/aspeed_adc.c+71 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [v7 00/11] Add support for ast2600 ADC

This patch serials make aspeed_adc.c can support ast2600 and backward compatible.

Change since v6:
aspeed_adc.c:
- Fix the parameter error for aspeed_adc_unregister_fixed_divider.

Change since v5:
aspeed_adc.c:
- Use devm_clk_hw_register_divider()
- Enabling and setting the ADC to normal mode is a necessary flow, so take it out of the condition.

Change since v4:
dt-bindings:
- Add clocks maxItems.
- Rename the property to meet the property-units.yaml.
- Add the description for the difference between adc0 and adc1.
aspeed_adc.c:
- Use new property name to get internal reference voltage: units from mv to uv.
- Fix -Wnonnull warning caused by snprintf parameters.
- Add suffix mv to the vref parameters.
- Use ARRAY_SIZE instead of 32.
- Add a reset action for ADC power down and Use devm_iio_device_register.
- Fix typo error.
- Separate the offset interface of ch7 when battery sensing enable

Change since v3:
dt-bindings:
- Fix properties:aspeed,int_vref_mv type error.

Change since v2:
dt-bindings:
- Create a new dt-bindings for ast2600 adc
aspeed_adc.c:
- Splits the patch for more details
- Remove version enum and use the flags in model data to distinguish hardware feature
- Support trimming data get and set.
- Use devm_add_action_or_reset to simplify probe error handling.

Changes since v1:
dt-bindings:
- Fix the aspeed,adc.yaml check error.
- Add battery-sensing property.
aspeed_adc.c:
- Change the init flow:
Clock and reference voltage setting should be completed before adc engine enable.
- Change the default sampling rate to meet most user case.
- Add patch #8 to suppoert battery sensing mode.

Billy Tsai (11):
iio: adc: aspeed: Keep model data to driver data.
iio: adc: aspeed: Restructure the model data
iio: adc: aspeed: Add vref config function
iio: adc: aspeed: Use model_data to set clk scaler.
iio: adc: aspeed: Use devm_add_action_or_reset.
iio: adc: aspeed: Support ast2600 adc.
iio: adc: aspeed: Fix the calculate error of clock.
iio: adc: aspeed: Add func to set sampling rate.
iio: adc: aspeed: Add compensation phase.
iio: adc: aspeed: Support battery sensing.
iio: adc: aspeed: Get and set trimming data.

 drivers/iio/adc/aspeed_adc.c | 554 +++++++++++++++++++++++++++++------
 1 file changed, 459 insertions(+), 95 deletions(-)
Signature · 1 line
2.25.1