Skip to content

use compiler atomic builtins for test

Joyce Kong dpdk-dev 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest8 patches 6 repliesApplied

Changes in v3 from the cover letter

Change 'GCC atomic builtins' to 'compiler atomic builtins' as clang adopted the same syntax as GCC.<Thomas Monjalon>

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8test/ticketlock: use compiler atomics for lcores syncapp/test/test_ticketlock.c+4 -60 replies
2/8test/spinlock: use compile atomics for lcores syncapp/test/test_spinlock.c+4 -50 replies
3/8test/rwlock: use compiler atomics for lcores syncapp/test/test_rwlock.c+4 -60 replies
4/8test/mcslock: use compiler atomics for lcores syncapp/test/test_mcslock.c+6 -83 replies
5/8test/mempool: remove unused variable for lcores syncapp/test/test_mempool.c+0 -50 replies
6/8test/mempool_perf: use compiler atomics for lcores syncapp/test/test_mempool_perf.c+4 -70 replies
7/8test/service_cores: use compiler atomics for lock syncapp/test/test_service_cores.c+20 -160 replies
8/8test/rcu: use compiler atomics for data syncapp/test/test_rcu_qsbr_perf.c+49 -492 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchRuifeng WangHonnappa NagarahalliStephen Hemminger
1/8R-b R-b A-b
2/8R-b A-b
3/8R-b A-b
4/8R-b A-b
5/8R-b A-b
6/8R-b A-b
7/8R-b A-b
8/8R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/8] use compiler atomic builtins for test

Since atomic operations have been adopted in DPDK now[1], change rte_atomicNN_xxx APIs to compiler's atomic built-ins in test cases.

[1] https://www.dpdk.org/blog/2021/03/26/dpdk-adopts-the-c11-memory-model/

v3:
Change 'GCC atomic builtins' to 'compiler atomic builtins' as clang adopted the same syntax as GCC.<Thomas Monjalon>

v2:
Use rte_wait_until_equal() instead of original sync loops. <David Marchand>

v1:
The initial version.

Joyce Kong (8):
test/ticketlock: use compiler atomics for lcores sync test/spinlock: use compile atomics for lcores sync test/rwlock: use compiler atomics for lcores sync test/mcslock: use compiler atomics for lcores sync test/mempool: remove unused variable for lcores sync test/mempool_perf: use compiler atomics for lcores sync test/service_cores: use compiler atomics for lock sync test/rcu: use compiler atomics for data sync

 app/test/test_mcslock.c       | 14 +++--
 app/test/test_mempool.c       |  5 --
 app/test/test_mempool_perf.c  | 11 ++--
 app/test/test_rcu_qsbr_perf.c | 98 +++++++++++++++++------------------
 app/test/test_rwlock.c        | 10 ++--
 app/test/test_service_cores.c | 36 +++++++------
 app/test/test_spinlock.c      |  9 ++--
 app/test/test_ticketlock.c    | 10 ++--
 8 files changed, 91 insertions(+), 102 deletions(-)
Signature · 1 line
2.17.1