Skip to content

Various error handling fixes and cleanups

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 34 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16error: Use error_fatal to simplify obvious fatal errors (again)hw/s390x/ipl.c migration/migration.c qemu-img.c +7 more+13 -564 replies
2/16spapr: Plug memory leak when we can't add a migration blockerhw/ppc/spapr_events.c+1 -22 replies
3/16spapr: Explain purpose of ->fwnmi_migration_blocker more clearlyhw/ppc/spapr_events.c+9 -81 reply
4/16multi-process: Fix pci_proxy_dev_realize() error handlinghw/remote/proxy.c+9 -12 replies
5/16vhost-scsi: Plug memory leak on migrate_add_blocker() failurehw/scsi/vhost-scsi.c+2 -20 replies
6/16i386: Never free migration blocker objects instead of sometimestarget/i386/kvm/kvm.c+0 -30 replies
7/16vfio: Avoid error_propagate() after migrate_add_blocker()hw/vfio/migration.c+2 -44 replies
8/16whpx nvmm: Drop useless migrate_del_blocker()target/i386/nvmm/nvmm-all.c target/i386/whpx/whpx-all.c+0 -21 reply
9/16migration: Unify failure check for migrate_add_blocker()backends/tpm/tpm_emulator.c hw/display/qxl.c hw/virtio/vhost.c +3 more+11 -141 reply
10/16migration: Handle migration_incoming_setup() errors consistentlymigration/migration.c+9 -186 replies
11/16microvm: Drop dead error handling in microvm_machine_state_init()hw/i386/microvm.c+0 -53 replies
12/16vhost: Clean up how VhostOpts method vhost_get_config() failshw/virtio/vhost-user.c hw/virtio/vhost.c+4 -83 replies
13/16vhost: Clean up how VhostOpts method vhost_backend_init() failshw/virtio/vhost-user.c hw/virtio/vhost.c+6 -41 reply
14/16Remove superfluous ERRP_GUARD()hw/remote/mpqemu-link.c qga/commands-posix-ssh.c qga/commands-win32.c +2 more+0 -231 reply
15/16vl: Clean up -smp error handlingsoftmmu/vl.c+5 -41 reply
16/16vl: Don't continue after -smp help.softmmu/vl.c+1 -12 replies

Reviews trailers per patch

13 of 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSergio LopezEric BlakeDavid GibsonPeter XuPhilippe Mathieu-DaudéJagannathan RamanPankaj GuptaReinoud ZandijkMichael S. Tsirkin
SeriesA-b
1/16R-b R-b R-b
2/16A-b R-b
3/16A-b
4/16R-b A-b
5/16
6/16
7/16R-b
8/16R-b
9/16R-b
10/16R-b R-b
11/16R-b R-b R-b
12/16R-b
13/16R-b
14/16
15/16R-b
16/16R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v1 thread

Cover letter [PATCH 00/16] Various error handling fixes and cleanups

I doubt the fixes are 6.1 material at this late stage. If you disagree, let me know.

Cc Alex Williamson <[email protected]>
Cc Aravinda Prasad <[email protected]>
Cc Cornelia Huck <[email protected]>
Cc Daniel P. Berrangé <[email protected]>
Cc David Gibson <[email protected]>
Cc Dr. David Alan Gilbert <[email protected]>
Cc Eduardo Habkost <[email protected]>
Cc Elena Ufimtseva <[email protected]>
Cc Ganesh Goudar <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Jagannathan Raman <[email protected]>
Cc John G Johnson <[email protected]>
Cc Juan Quintela <[email protected]>
Cc Kamil Rytarowski <[email protected]>
Cc Kevin Wolf <[email protected]>
Cc Kirti Wankhede <[email protected]>
Cc Marc-André Lureau <[email protected]>
Cc Marcelo Tosatti <[email protected]>
Cc Michael S. Tsirkin <[email protected]>
Cc Paolo Bonzini <[email protected]>
Cc Peter Xu <[email protected]>
Cc Reinoud Zandijk <[email protected]>
Cc Sergio Lopez <[email protected]>
Cc Stefan Hajnoczi <[email protected]>
Cc Sunil Muthuswamy <[email protected]>
Cc Thomas Huth <[email protected]>

Markus Armbruster (16):
error: Use error_fatal to simplify obvious fatal errors (again)
spapr: Plug memory leak when we can't add a migration blocker
spapr: Explain purpose of ->fwnmi_migration_blocker more clearly
multi-process: Fix pci_proxy_dev_realize() error handling
vhost-scsi: Plug memory leak on migrate_add_blocker() failure
i386: Never free migration blocker objects instead of sometimes
vfio: Avoid error_propagate() after migrate_add_blocker() whpx nvmm: Drop useless migrate_del_blocker()
migration: Unify failure check for migrate_add_blocker()
migration: Handle migration_incoming_setup() errors consistently
microvm: Drop dead error handling in microvm_machine_state_init()
vhost: Clean up how VhostOpts method vhost_get_config() fails
vhost: Clean up how VhostOpts method vhost_backend_init() fails Remove superfluous ERRP_GUARD()
vl: Clean up -smp error handling
vl: Don't continue after -smp help.

 backends/tpm/tpm_emulator.c |  3 +--
 hw/display/qxl.c            |  8 ++++----
 hw/i386/microvm.c           |  5 -----
 hw/ppc/spapr_events.c       | 20 ++++++++++----------
 hw/remote/mpqemu-link.c     |  3 ---
 hw/remote/proxy.c           | 10 +++++++++-
 hw/s390x/ipl.c              |  6 +-----
 hw/scsi/vhost-scsi.c        |  4 ++--
 hw/vfio/migration.c         |  6 ++----
 hw/virtio/vhost-user.c      |  8 ++++++++
 hw/virtio/vhost.c           | 16 +++-------------
 migration/migration.c       | 34 ++++++++++------------------------
 qemu-img.c                  |  6 +-----
 qemu-io.c                   |  6 +-----
 qemu-nbd.c                  |  5 +----
 qga/commands-posix-ssh.c    | 17 -----------------
 qga/commands-win32.c        |  1 -
 scsi/qemu-pr-helper.c       | 11 +++--------
 softmmu/vl.c                | 19 +++++++------------
 target/i386/kvm/kvm.c       |  9 +++------
 target/i386/nvmm/nvmm-all.c |  4 +---
 target/i386/sev.c           |  8 +-------
 target/i386/whpx/whpx-all.c |  4 +---
 ui/console.c                |  7 ++-----
 ui/spice-core.c             |  7 +------
 25 files changed, 72 insertions(+), 155 deletions(-)
Signature · 1 line
2.31.1