Skip to content

drm/bridge: Make panel and bridge probe order consistent

Maxime Ripard dri-devel linux-arm-msm linux-samsung-soc lkml 6 versions – Applied

Status from this message: Applied to drm/drm-misc (drm-misc-next).

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest21 patches 26 repliesApplied
  2. v521 patches 7 repliesSuperseded
  3. v424 patches 30 repliesApplied
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v38 patches6 repliesSuperseded
v28 patches4 repliesSuperseded
v110 patches16 repliesSuperseded

Changes in v6 from the cover letter

- Collected more tags
- Fixed a compilation error for ps8640

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/21drm/bridge: adv7533: Switch to devm MIPI-DSI helpersdrivers/gpu/drm/bridge/adv7511/adv7511.h drivers/gpu/drm/bridge/adv7511/adv7511_drv.c drivers/gpu/drm/bridge/adv7511/adv7533.c+4 -191 reply
2/21drm/bridge: adv7511: Register and attach our DSI device at probedrivers/gpu/drm/bridge/adv7511/adv7511_drv.c+10 -35 replies
3/21drm/bridge: anx7625: Switch to devm MIPI-DSI helpersdrivers/gpu/drm/bridge/analogix/anx7625.c+5 -151 reply
4/21drm/bridge: anx7625: Register and attach our DSI device at probedrivers/gpu/drm/bridge/analogix/anx7625.c+14 -61 reply
5/21drm/bridge: lt8912b: Switch to devm MIPI-DSI helpersdrivers/gpu/drm/bridge/lontium-lt8912b.c+4 -161 reply
6/21drm/bridge: lt8912b: Register and attach our DSI device at probedrivers/gpu/drm/bridge/lontium-lt8912b.c+7 -41 reply
7/21drm/bridge: lt9611: Switch to devm MIPI-DSI helpersdrivers/gpu/drm/bridge/lontium-lt9611.c+4 -201 reply
8/21drm/bridge: lt9611: Register and attach our DSI device at probedrivers/gpu/drm/bridge/lontium-lt9611.c+19 -191 reply
9/21drm/bridge: lt9611uxc: Switch to devm MIPI-DSI helpersdrivers/gpu/drm/bridge/lontium-lt9611uxc.c+8 -301 reply
10/21drm/bridge: lt9611uxc: Register and attach our DSI device at probedrivers/gpu/drm/bridge/lontium-lt9611uxc.c+19 -121 reply
11/21drm/bridge: ps8640: Switch to devm MIPI-DSI helpersdrivers/gpu/drm/bridge/parade-ps8640.c+5 -101 reply
12/21drm/bridge: ps8640: Register and attach our DSI device at probedrivers/gpu/drm/bridge/parade-ps8640.c+55 -431 reply
13/21drm/bridge: sn65dsi83: Fix bridge removaldrivers/gpu/drm/bridge/ti-sn65dsi83.c+1 -11 reply
14/21drm/bridge: sn65dsi83: Switch to devm MIPI-DSI helpersdrivers/gpu/drm/bridge/ti-sn65dsi83.c+3 -91 reply
15/21drm/bridge: sn65dsi83: Register and attach our DSI device at probedrivers/gpu/drm/bridge/ti-sn65dsi83.c+46 -341 reply
16/21drm/bridge: sn65dsi86: Switch to devm MIPI-DSI helpersdrivers/gpu/drm/bridge/ti-sn65dsi86.c+7 -151 reply
17/21drm/bridge: sn65dsi86: Register and attach our DSI device at probedrivers/gpu/drm/bridge/ti-sn65dsi86.c+40 -371 reply
18/21drm/bridge: tc358775: Switch to devm MIPI-DSI helpersdrivers/gpu/drm/bridge/tc358775.c+4 -91 reply
19/21drm/bridge: tc358775: Register and attach our DSI device at probedrivers/gpu/drm/bridge/tc358775.c+25 -121 reply
20/21drm/kirin: dsi: Adjust probe orderdrivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c+33 -192 replies
21/21drm/msm/dsi: Adjust probe orderdrivers/gpu/drm/msm/dsi/dsi.c drivers/gpu/drm/msm/dsi/dsi.h drivers/gpu/drm/msm/dsi/dsi_host.c +2 more+43 -391 reply

Reviews trailers per patch

20 of 21 patches have a Reviewed-by or Acked-by.

PatchSam RavnborgJohn StultzMarek VasutLaurent PinchartAmit PundirCaleb Connolly
1/21A-b T-b
2/21A-b T-b
3/21A-b
4/21A-b
5/21A-b
6/21A-b
7/21A-b T-b
8/21A-b T-b
9/21A-b
10/21A-b
11/21A-b
12/21A-b
13/21A-b R-b
14/21A-b T-b
15/21A-b T-b
16/21A-b
17/21A-b
18/21A-b
19/21A-b
20/21T-b A-b
21/21T-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/21] drm/bridge: Make panel and bridge probe order consistent

Hi,

We've encountered an issue with the RaspberryPi DSI panel that prevented the whole display driver from probing.

The issue is described in detail in the commit 7213246a803f ("drm/vc4: dsi:
Only register our component once a DSI device is attached"), but the basic idea is that since the panel is probed through i2c, there's no synchronization between its probe and the registration of the MIPI-DSI host it's attached to.

We initially moved the component framework registration to the MIPI-DSI Host attach hook to make sure we register our component only when we have a DSI device attached to our MIPI-DSI host, and then use lookup our DSI device in our bind hook.

However, all the DSI bridges controlled through i2c are only registering their associated DSI device in their bridge attach hook, meaning with our change above, we never got that far, and therefore ended up in the same situation than the one we were trying to fix for panels.

The best practice to avoid those issues is to register its functions only after all its dependencies are live. We also shouldn't wait any longer than we should to play nice with the other components that are waiting for us, so in our case that would mean moving the DSI device registration to the bridge probe.

This has been tested on vc4 (with sn65dsi83 and ps8640), msm (sn65dsi86, lt9611), kirin (adv7511) and exynos.

Let me know what you think,
Maxime

---

Changes from v5:
- Collected more tags
- Fixed a compilation error for ps8640

Changes from v4:
- Rebased on current drm-misc-next
- Collected the various tags
- Fix for Kirin
- Added conversion patch for msm

Changes from v3:
- Converted exynos and kirin
- Converted all the affected bridge drivers
- Reworded the documentation a bit

Changes from v2:
- Changed the approach as suggested by Andrzej, and aligned the bridge on the panel this time.
- Fixed some typos

Changes from v1:
- Change the name of drm_of_get_next function to drm_of_get_bridge
- Mention the revert of 87154ff86bf6 and squash the two patches that were reverting that commit
- Add some documentation
- Make drm_panel_attach and _detach succeed when no callback is there

Maxime Ripard (20):
drm/bridge: adv7533: Switch to devm MIPI-DSI helpers drm/bridge: adv7511: Register and attach our DSI device at probe drm/bridge: anx7625: Switch to devm MIPI-DSI helpers drm/bridge: anx7625: Register and attach our DSI device at probe drm/bridge: lt8912b: Switch to devm MIPI-DSI helpers drm/bridge: lt8912b: Register and attach our DSI device at probe drm/bridge: lt9611: Switch to devm MIPI-DSI helpers drm/bridge: lt9611: Register and attach our DSI device at probe drm/bridge: lt9611uxc: Switch to devm MIPI-DSI helpers drm/bridge: lt9611uxc: Register and attach our DSI device at probe drm/bridge: ps8640: Switch to devm MIPI-DSI helpers drm/bridge: ps8640: Register and attach our DSI device at probe drm/bridge: sn65dsi83: Fix bridge removal
drm/bridge: sn65dsi83: Switch to devm MIPI-DSI helpers drm/bridge: sn65dsi83: Register and attach our DSI device at probe drm/bridge: sn65dsi86: Switch to devm MIPI-DSI helpers drm/bridge: sn65dsi86: Register and attach our DSI device at probe drm/bridge: tc358775: Switch to devm MIPI-DSI helpers drm/bridge: tc358775: Register and attach our DSI device at probe drm/kirin: dsi: Adjust probe order

Rob Clark (1):
drm/msm/dsi: Adjust probe order

 drivers/gpu/drm/bridge/adv7511/adv7511.h     |   1 -
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c |  15 ++-
 drivers/gpu/drm/bridge/adv7511/adv7533.c     |  20 +---
 drivers/gpu/drm/bridge/analogix/anx7625.c    |  40 ++++---
 drivers/gpu/drm/bridge/lontium-lt8912b.c     |  31 ++----
 drivers/gpu/drm/bridge/lontium-lt9611.c      |  62 ++++-------
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c   |  65 +++++-------
 drivers/gpu/drm/bridge/parade-ps8640.c       | 105 ++++++++++---------
 drivers/gpu/drm/bridge/tc358775.c            |  50 +++++----
 drivers/gpu/drm/bridge/ti-sn65dsi83.c        |  88 ++++++++--------
 drivers/gpu/drm/bridge/ti-sn65dsi86.c        | 101 +++++++++---------
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c |  52 +++++----
 drivers/gpu/drm/msm/dsi/dsi.c                |  50 +++++----
 drivers/gpu/drm/msm/dsi/dsi.h                |   2 +-
 drivers/gpu/drm/msm/dsi/dsi_host.c           |  22 ++--
 drivers/gpu/drm/msm/dsi/dsi_manager.c        |   6 +-
 drivers/gpu/drm/msm/msm_drv.h                |   2 +
 17 files changed, 348 insertions(+), 364 deletions(-)
Signature · 1 line
2.31.1