Skip to content

Support ETE decoding

James Clark linux-arm-kernel linux-perf-users lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 42 repliesIn review
  2. v16 patches 26 repliesSuperseded

Changes in v2 from the cover letter

* Re-implement with a new magic number instead of piggybacking on ETMv4
* Improve comments and function name around cs_etm_decoder__get_etmv4_arch_ver()
* Add a warning for unrecognised magic numbers
* Split typo fix into new commit
* Add Leo's reviewed-by tags
* Create a new struct for ETE config (cs_ete_trace_params) instead of re-using ETMv4 config

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9perf cs-etm: Refactor initialisation of decoder params.tools/perf/util/cs-etm-decoder/cs-etm-decoder.c+25 -743 replies
2/9perf cs-etm: Initialise architecture based on TRCIDR1tools/perf/util/cs-etm-decoder/cs-etm-decoder.c+15 -14 replies
3/9perf cs-etm: Refactor out ETMv4 header savingtools/perf/arch/arm/util/cs-etm.c+23 -233 replies
4/9perf cs-etm: Save TRCDEVARCH registertools/perf/arch/arm/util/cs-etm.c tools/perf/util/cs-etm.c tools/perf/util/cs-etm.h+68 -74 replies
5/9perf cs-etm: Fix typotools/perf/arch/arm/util/cs-etm.c+1 -13 replies
6/9perf cs-etm: Update OpenCSD decoder for ETEtools/build/feature/test-libopencsd.c tools/perf/util/cs-etm-decoder/cs-etm-decoder.c+2 -43 replies
7/9perf cs-etm: Create ETE decodertools/perf/util/cs-etm-decoder/cs-etm-decoder.c tools/perf/util/cs-etm-decoder/cs-etm-decoder.h tools/perf/util/cs-etm.c+50 -05 replies
8/9perf cs-etm: Print the decoder nametools/perf/util/cs-etm-decoder/cs-etm-decoder.c tools/perf/util/cs-etm-decoder/cs-etm-decoder.h tools/perf/util/cs-etm.c+14 -84 replies
9/9perf cs-etm: Show a warning for an unknown magic numbertools/perf/util/cs-etm.c+5 -011 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchLeo YanSuzuki K PouloseMike Leach
1/9R-b A-b R-b
2/9R-b R-b
3/9R-b A-b R-b
4/9R-b R-b
5/9R-b A-b R-b
6/9R-b A-b R-b
7/9R-b A-b R-b
8/9R-b R-b R-b
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/9] Support ETE decoding

Changes since v1:
* Re-implement with a new magic number instead of piggybacking on ETMv4
* Improve comments and function name around cs_etm_decoder__get_etmv4_arch_ver()
* Add a warning for unrecognised magic numbers
* Split typo fix into new commit
* Add Leo's reviewed-by tags
* Create a new struct for ETE config (cs_ete_trace_params) instead of re-using ETMv4 config

Applies to perf/core f3c33cbd922
Also available at https://gitlab.arm.com/linux-arm/linux-jc/-/tree/james-ete-v2

James Clark (9):
perf cs-etm: Refactor initialisation of decoder params. perf cs-etm: Initialise architecture based on TRCIDR1 perf cs-etm: Refactor out ETMv4 header saving perf cs-etm: Save TRCDEVARCH register
perf cs-etm: Fix typo
perf cs-etm: Update OpenCSD decoder for ETE perf cs-etm: Create ETE decoder
perf cs-etm: Print the decoder name
perf cs-etm: Show a warning for an unknown magic number

 tools/build/feature/test-libopencsd.c         |   4 +-
 tools/perf/arch/arm/util/cs-etm.c             |  97 ++++++++----
 .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 148 ++++++++----------
 .../perf/util/cs-etm-decoder/cs-etm-decoder.h |  13 ++
 tools/perf/util/cs-etm.c                      |  43 ++++-
 tools/perf/util/cs-etm.h                      |  10 ++
 6 files changed, 200 insertions(+), 115 deletions(-)
Signature · 1 line
2.28.0