Skip to content

perf tools: Add PMU alias support

Jin Yao linux-perf-users lkml 7 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest2 patches 5 repliesApplied
  2. v62 patches 4 repliesSuperseded
  3. v52 patches 2 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v42 patches6 repliesSuperseded
v32 patches2 repliesSuperseded
v22 patches5 repliesSuperseded
v11 patch3 repliesSuperseded

Changes in v7 from the cover letter

---
1. Create 'struct perf_pmu_alias_name' constructor/destructor.
2. Return '-errno' if opendir() is failed.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/2perf pmu: Add PMU alias supporttools/perf/arch/x86/util/pmu.c tools/perf/util/parse-events.y tools/perf/util/pmu.c +1 more+198 -54 replies
2/2perf tests: Test for PMU aliastools/perf/tests/parse-events.c+92 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAndi Kleen
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/2] perf tools: Add PMU alias support

A perf uncore PMU may have two PMU names, a real name and an alias name. With this patch set, the perf tool can monitor the PMU with either the real name or the alias.

Use the real name,

 $ perf stat -e uncore_cha_2/event=1/ -x,
   4044879584,,uncore_cha_2/event=1/,2528059205,100.00,,

Use the alias,

 $ perf stat -e uncore_type_0_2/event=1/ -x,
   3659675336,,uncore_type_0_2/event=1/,2287306455,100.00,,

v7:
---
1. Create 'struct perf_pmu_alias_name' constructor/destructor.
2. Return '-errno' if opendir() is failed.

v6:
---
1. Call setup_pmu_alias_list in pmu_find_alias_name.
2. Check pmu->name and pmu->alias_name after strdup in pmu_lookup.

v5:
---
1. Don't use strdup in find functions (pmu_find_real_name and pmu_find_alias_name). Just return name and keep the 'pmu->name = strdup(name);' in pmu_lookup.

2. Remove invalid comment for alias_name in struct perf_pmu.

v4:
---
1. Fix memory leaks in pmu_lookup.
2. Rebase to perf/core.

v3:
---
1. Use fgets() to replace fscanf().
2. Resource cleanup.

v2:
---
Add test case to verify the real name and alias name having same effect.

Jin Yao (1):
perf tests: Test for PMU alias

Kan Liang (1):
perf pmu: Add PMU alias support

 tools/perf/arch/x86/util/pmu.c  | 155 +++++++++++++++++++++++++++++++-
 tools/perf/tests/parse-events.c |  92 +++++++++++++++++++
 tools/perf/util/parse-events.y  |   3 +-
 tools/perf/util/pmu.c           |  40 ++++++++-
 tools/perf/util/pmu.h           |   5 ++
 5 files changed, 290 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1