Skip to content

Replace AV by AH in UD sends

Bob Pearson linux-rdma 4 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 1 replyApplied
  2. v56 patches 9 repliesSuperseded
  3. v46 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v36 patches2 repliesSuperseded

Changes in v6 from the cover letter

Rebase to 5.15.0-rc4
Reduced the max number of AH objects from 1M to 32K.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/6RDMA/rxe: Move AV from rxe_send_wqe to rxe_send_wrdrivers/infiniband/sw/rxe/rxe_av.c drivers/infiniband/sw/rxe/rxe_verbs.c include/uapi/rdma/rdma_user_rxe.h+6 -30 replies
2/6RDMA/rxe: Change AH objects to indexeddrivers/infiniband/sw/rxe/rxe_param.h drivers/infiniband/sw/rxe/rxe_pool.c+6 -20 replies
3/6RDMA/rxe: Create AH index and return to user spacedrivers/infiniband/sw/rxe/rxe_verbs.c drivers/infiniband/sw/rxe/rxe_verbs.h include/uapi/rdma/rdma_user_rxe.h+39 -20 replies
4/6RDMA/rxe: Replace ah->pd by ah->ibah.pddrivers/infiniband/sw/rxe/rxe_verbs.h+5 -10 replies
5/6RDMA/rxe: Lookup kernel AH from ah index in UD WQEsdrivers/infiniband/sw/rxe/rxe_av.c drivers/infiniband/sw/rxe/rxe_req.c+24 -40 replies
6/6RDMA/rxe: Convert kernel UD post send to use ah_numdrivers/infiniband/sw/rxe/rxe_verbs.c+3 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH for-next v6 0/6] Replace AV by AH in UD sends

Currently the rdma_rxe driver and its user space provider exchange addressing information for UD sends by having the provider compute an address vector (AV) and send it with each WQE. This is not the way that the RDMA verbs API was intended to operate.

This series of patches modifies the way UD send WQEs work by exchanging an index identifying the AH replacing the 88 byte AV by a 4 byte AH index. In order to not break compatibility with the existing API the rdma_rxe driver will recognise when an older version of the provider is not sending an index (i.e. it is 0) and will use the AV instead.

This series of patches is rebased to

    commit: 286dba65a4a65a6d5de011767061f6ffa6e10389 (for-next)

---
v6:
Rebase to 5.15.0-rc4
Reduced the max number of AH objects from 1M to 32K.

v5:
Rebase to 5.15.0-rc2+

v4:
Rebase to 5.15.0-rc1+

v3:
Split up commits into smaller steps.

v2:
Rearranged AV in rxe_send_wqe to be in the ud struct but padded to the same offset as the original preserving ABI compatibility.

Bob Pearson (6):
RDMA/rxe: Move AV from rxe_send_wqe to rxe_send_wr RDMA/rxe: Change AH objects to indexed RDMA/rxe: Create AH index and return to user space RDMA/rxe: Replace ah->pd by ah->ibah.pd RDMA/rxe: Lookup kernel AH from ah index in UD WQEs RDMA/rxe: Convert kernel UD post send to use ah_num

 drivers/infiniband/sw/rxe/rxe_av.c    | 20 +++++++++++++-
 drivers/infiniband/sw/rxe/rxe_param.h |  4 ++-
 drivers/infiniband/sw/rxe/rxe_pool.c  |  4 ++-
 drivers/infiniband/sw/rxe/rxe_req.c   |  8 +++---
 drivers/infiniband/sw/rxe/rxe_verbs.c | 39 ++++++++++++++++++++++-----
 drivers/infiniband/sw/rxe/rxe_verbs.h |  8 +++++-
 include/uapi/rdma/rdma_user_rxe.h     | 10 ++++++-
 7 files changed, 79 insertions(+), 14 deletions(-)
Signature · 1 line
2.30.2