Skip to content

cxl_region and cxl_memdev drivers

Ben Widawsky linux-cxl 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest23 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23cxl: Move cxl_core to new directoryDocumentation/driver-api/cxl/memory-devices.rst drivers/cxl/Makefile drivers/cxl/core/Makefile +1 more+9 -60 replies
2/23cxl/core: Improve CXL core kernel docsdrivers/cxl/core/bus.c+9 -20 replies
3/23cxl/core: Extract register and pmem functionalityDocumentation/driver-api/cxl/memory-devices.rst drivers/cxl/Makefile drivers/cxl/core/Makefile +4 more+467 -4330 replies
4/23cxl/mem: Move character device region creationdrivers/cxl/core/bus.c drivers/cxl/mem.h drivers/cxl/pci.c+15 -130 replies
5/23cxl: Pass fops and shutdown to memdev creationdrivers/cxl/mem.h drivers/cxl/pci.c+17 -80 replies
6/23cxl/core: Move memdev management to coredrivers/cxl/Makefile drivers/cxl/core/Makefile drivers/cxl/core/memdev.c +2 more+237 -2230 replies
7/23cxl/pci: Ignore unknown register block typesdrivers/cxl/pci.c+12 -80 replies
8/23cxl/pci: Simplify register setupdrivers/cxl/cxl.h drivers/cxl/pci.c drivers/cxl/pci.h+13 -270 replies
9/23cxl/pci: Retain map information in cxl_mem_probedrivers/cxl/pci.c+6 -40 replies
10/23cxl/decoder: Support parentless decodersdrivers/cxl/acpi.c drivers/cxl/core/bus.c drivers/cxl/cxl.h+34 -231 reply
11/23cxl: Enable an endpoint decoder typedrivers/cxl/acpi.c drivers/cxl/core/bus.c drivers/cxl/cxl.h+75 -220 replies
12/23cxl/region: Add region creation ABIDocumentation/ABI/testing/sysfs-bus-cxl Documentation/driver-api/cxl/memory-devices.rst drivers/cxl/Makefile +6 more+307 -13 replies
13/23cxl/region: Introduce concept of region configurationDocumentation/ABI/testing/sysfs-bus-cxl drivers/cxl/core/memdev.c drivers/cxl/core/region.c +1 more+259 -50 replies
14/23cxl: Convert driver id to an enumdrivers/cxl/cxl.h+6 -40 replies
15/23cxl/region: Introduce a cxl_region driverDocumentation/driver-api/cxl/memory-devices.rst drivers/cxl/Makefile drivers/cxl/core/bus.c +6 more+178 -90 replies
16/23cxl/core: Convert decoder range to resourcedrivers/cxl/core/bus.c drivers/cxl/core/region.c drivers/cxl/cxl.h+6 -100 replies
17/23cxl/region: Handle region's address space allocationdrivers/cxl/core/bus.c drivers/cxl/cxl.h drivers/cxl/region.c+51 -20 replies
18/23cxl/region: Only allow CXL capable targetsdrivers/cxl/mem.h drivers/cxl/region.c+12 -10 replies
19/23cxl/mem: Introduce CXL mem driverdrivers/cxl/Makefile drivers/cxl/core/bus.c drivers/cxl/core/memdev.c +3 more+57 -10 replies
20/23cxl/memdev: Determine CXL.mem capabilitydrivers/cxl/acpi.c drivers/cxl/core/bus.c drivers/cxl/core/memdev.c +3 more+65 -220 replies
21/23cxl/mem: Check that the device is CXL.mem capabledrivers/cxl/core/bus.c drivers/cxl/core/core.h drivers/cxl/mem.c +2 more+49 -240 replies
22/23cxl/mem: Add device as a portdrivers/cxl/core/bus.c drivers/cxl/mem.c+13 -40 replies
23/23cxl/core: Map component registers for portsdrivers/cxl/core/bus.c drivers/cxl/core/regs.c drivers/cxl/cxl.h +3 more+56 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFCish 00/23] cxl_region and cxl_memdev drivers

I will be going on vacation for the next two weeks so I'm sending out everything I have, even though it's not fully baked so that folks who might want to continue it while I'm gone, can do so. Many of these patches have already been sent as separate series, or RFC.

The ultimate goal of this series is to create two new driver types, cxl_region, and cxl_memdev. The cxl_region driver is responsible for region creation and configuration, and the cxl_memdev driver is responsible for handling the CXL specific (non-PCI) parts of CXL endpoints. In order to establish that in a clean way, the cxl_core driver needed quite a bit of rework. The next step is to complete the HDM decoder programming.

What's specifically not fully baked is the cxl_pci driver claims part of the component register space, but the cxl_memdev driver also wants this resource. Better coordination here needs to happen, most likely the cxl_pci driver must relinquish any resources it won't be needing. Some of the patches started to enable making that easy, but it's not complete and as a result I believe these patches will OOPS (there may be other issues as well).

If you feel like reviewing any of these patches, that'd be great, but I'm equally happy to resubmit when I'm back and have things fully working.

Patch breakdown
1-11: cxl_core reorganization
12-18: cxl_region driver
19-23: cxl_memdev driver

These patches can be obtained from my gitlab as well:
https://gitlab.com/bwidawsk/linux/-/tree/cxl_memdrver2

Ben Widawsky (23):
cxl: Move cxl_core to new directory cxl/core: Improve CXL core kernel docs cxl/core: Extract register and pmem functionality cxl/mem: Move character device region creation
cxl: Pass fops and shutdown to memdev creation cxl/core: Move memdev management to core cxl/pci: Ignore unknown register block types cxl/pci: Simplify register setup
cxl/pci: Retain map information in cxl_mem_probe cxl/decoder: Support parentless decoders
cxl: Enable an endpoint decoder type cxl/region: Add region creation ABI cxl/region: Introduce concept of region configuration
cxl: Convert driver id to an enum cxl/region: Introduce a cxl_region driver cxl/core: Convert decoder range to resource cxl/region: Handle region's address space allocation cxl/region: Only allow CXL capable targets cxl/mem: Introduce CXL mem driver cxl/memdev: Determine CXL.mem capability cxl/mem: Check that the device is CXL.mem capable cxl/mem: Add device as a port
cxl/core: Map component registers for ports

 Documentation/ABI/testing/sysfs-bus-cxl       |  53 ++
 .../driver-api/cxl/memory-devices.rst         |  25 +-
 drivers/cxl/Makefile                          |   9 +-
 drivers/cxl/acpi.c                            |  44 +-
 drivers/cxl/core/Makefile                     |   5 +
 drivers/cxl/{core.c => core/bus.c}            | 711 +++++++-----------
 drivers/cxl/core/core.h                       |  22 +
 drivers/cxl/core/memdev.c                     | 230 ++++++
 drivers/cxl/core/pmem.c                       | 201 +++++
 drivers/cxl/core/region.c                     | 389 ++++++++++
 drivers/cxl/core/regs.c                       | 235 ++++++
 drivers/cxl/cxl.h                             |  67 +-
 drivers/cxl/mem.c                             |  94 +++
 drivers/cxl/mem.h                             |  19 +
 drivers/cxl/pci.c                             | 325 ++------
 drivers/cxl/pci.h                             |   8 +-
 drivers/cxl/region.c                          | 134 ++++
 drivers/cxl/region.h                          |  34 +
 drivers/cxl/trace.h                           |  33 +
 19 files changed, 1867 insertions(+), 771 deletions(-)
 create mode 100644 drivers/cxl/core/Makefile
 rename drivers/cxl/{core.c => core/bus.c} (55%)
 create mode 100644 drivers/cxl/core/core.h
 create mode 100644 drivers/cxl/core/memdev.c
 create mode 100644 drivers/cxl/core/pmem.c
 create mode 100644 drivers/cxl/core/region.c
 create mode 100644 drivers/cxl/core/regs.c
 create mode 100644 drivers/cxl/mem.c
 create mode 100644 drivers/cxl/region.c
 create mode 100644 drivers/cxl/region.h
 create mode 100644 drivers/cxl/trace.h
Signature · 1 line
2.32.0