RFC Modify and/or delete SIS_PROP
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest9 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | sched/fair: Track efficiency of select_idle_siblingkernel/ kernel/ kernel/ +1 more | +29 | 0 replies | |
| 2/9 | sched/fair: Track efficiency of task recent_used_cpukernel/ kernel/ kernel/ +1 more | +24 | 0 replies | |
| 3/9 | sched/fair: Track efficiency of select_idle_corekernel/ kernel/ kernel/ +1 more | +10 | 0 replies | |
| 4/9 | sched/fair: Use prev instead of new target as recent_used_cpukernel/ | +1 | 0 replies | |
| 5/9 | sched/fair: Avoid a second scan of target in select_idle_cpukernel/ | +1 | 0 replies | |
| 6/9 | sched/fair: Make select_idle_cpu() proportional to coreskernel/ kernel/ kernel/ | +23 | 0 replies | |
| 7/9 | sched/fair: Enforce proportional scan limits when scanning for an idle corekernel/ | +19 | 2 replies | |
| 8/9 | sched/fair: select idle cpu from idle cpumask for task wakeupinclude/ kernel/ kernel/ +3 more | +71 | 7 replies | |
| 9/9 | sched/core: Delete SIS_PROP and rely on the idle cpu maskkernel/ kernel/ kernel/ +1 more | +8 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/9] Modify and/or delete SIS_PROP
When scanning for an idle CPU, SIS_PROP limits the scan based on an average estimated idle time for a domain but it's a somewhat inconsistent and fuzzy heuristic. Idle time of a CPU does not necessarily correlate with idle time of a domain, scanning for an idle core is not throttled at all and successful scans are not accounted for.
The first three patches are accounting patches to put some numbers on the scan efficiency. Ultimately, they may not be merged but they are useful for determining if a patch works as advertised.
Patch 4 improves recent_used_cpu to reduce the amount of scanning that is done in absolute terms.
Patch 5 notes that the target CPU has already been scanned with select_idle_cpu starts and therefore should be skipped.
Patches 6-9 replace SIS_PROP with a scheme based on partially tracking idle CPUs, first proposed by Aubrey Li and modified by this series. It is likely to be the most controversial, not necessary a win, but the possibility was discussed. The series is likely to be split with one series being patches 4-5 and a second being patches 6-9.
The series is not a univeral win or loss but there are some improvements and overall, scan efficiencies are improved. A limiting factor in the evaluation is that tracking the statistics is expensive on its own and all tests were run with schedstat enabled.
Depending on how this RFC is received, testing would be done without schedstat and the series may be split.
include/linux/sched/topology.h | 13 +++ kernel/sched/core.c | 7 +- kernel/sched/debug.c | 8 ++ kernel/sched/fair.c | 149 ++++++++++++++++++--------------- kernel/sched/features.h | 5 -- kernel/sched/idle.c | 5 ++ kernel/sched/sched.h | 17 +++- kernel/sched/stats.c | 10 ++- kernel/sched/topology.c | 3 +- 9 files changed, 133 insertions(+), 84 deletions(-)
Signature · 1 line
2.26.2