Skip to content

fs: dlm: misc and tracing

Alexander Aring cluster-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/24 patches 0 repliesNew
  2. v1 posting 1/21 patch 0 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fs: dlm: implement delayed ack handlingfs/dlm/lowcomms.c fs/dlm/lowcomms.h fs/dlm/midcomms.c+50 -80 replies
2/4fs: dlm: fix return -EINTR on recovery stoppedfs/dlm/dir.c fs/dlm/member.c fs/dlm/recoverd.c+9 -30 replies
3/4fs: dlm: initial support for tracepointsfs/dlm/ast.c fs/dlm/lock.c fs/dlm/main.c +1 more+229 -00 replies
4/4fs: dlm: trace socket handlingfs/dlm/lowcomms.c include/trace/events/dlm.h+44 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Cluster-devel] [PATCH RESEND dlm/next 0/4] fs: dlm: misc and tracing

Hi,

this series is a resend of my pending patches which I sent some days ago. For the recent dlm tracepoint patches I did some changes, see below.

changes in "fs: dlm: initial support for tracepoints":

- switch from e.g. uin32_t/u32 to __u32 in dlm tracing header as I figured out that this is common used. However it seems it really doesn't care, they are not uapi headers.
- switch from %d to %x printout for lkb_id as it is used for dlm debugfs. The lockspace id is still %d as it is used for sysfs.
- move trace_dlm_lock_start after error, we don't trace the error and we need to garuantee that lkb pointer is not dangled.
- add tracepoint start/end for dlm_unlock aswell, otherwise there are ast callbacks which are not recognizable, especially on DLM_EUNLOCK inside the status block.
- add a note that dlm_lock/unlock_start will only be traced if ls/lkb is valid. I think it makes no sense without any reference to do any lock/unlock tracing.

- Alex

Alexander Aring (4):
fs: dlm: implement delayed ack handling
fs: dlm: fix return -EINTR on recovery stopped
fs: dlm: initial support for tracepoints
fs: dlm: trace socket handling

 fs/dlm/ast.c               |   4 +
 fs/dlm/dir.c               |   4 +-
 fs/dlm/lock.c              |  10 ++
 fs/dlm/lowcomms.c          |   5 +
 fs/dlm/lowcomms.h          |   1 +
 fs/dlm/main.c              |   3 +
 fs/dlm/member.c            |   4 +-
 fs/dlm/midcomms.c          |  56 +++++++--
 fs/dlm/recoverd.c          |   4 +-
 include/trace/events/dlm.h | 252 +++++++++++++++++++++++++++++++++++++
 10 files changed, 332 insertions(+), 11 deletions(-)
 create mode 100644 include/trace/events/dlm.h
Signature · 1 line
2.27.0