net: ipa: kill IPA_VALIDATION
Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | net: ipa: fix ipa_cmd_table_valid()drivers/ drivers/ drivers/ | +29 | 0 replies | Applied |
| 2/4 | net: ipa: always validate filter and route tablesdrivers/ drivers/ | +17 | 0 replies | Applied |
| 3/4 | net: ipa: kill the remaining conditional validation codedrivers/ drivers/ drivers/ +4 more | +1 | 0 replies | Applied |
| 4/4 | net: ipa: use WARN_ON() rather than assertionsdrivers/ drivers/ drivers/ +4 more | +53 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net-next 0/4] net: ipa: kill IPA_VALIDATION
A few months ago I proposed cleaning up some code that validates certain things conditionally, arguing that doing so once is enough, thus doing so always should not be necessary.
https://lore.kernel.org/netdev/[email protected]/
Leon Romanovsky felt strongly that this was a mistake, and in the end I agreed to change my plans.
This series finally completes what I said I would do about this, ultimately eliminating the IPA_VALIDATION symbol and conditional code entirely.
The first patch both extends and simplifies some validation done for IPA immediate commands, and performs those tests unconditionally.
The second patch fixes a bug that wasn't normally exposed because of the conditional compilation (a reason Leon was right about this). It makes filter and routing table validation occur unconditionally.
The third eliminates the remaining conditionally-defined code and removes the line in the Makefile used to enable validation.
And the fourth removes all comments containing ipa_assert() statements, replacing most of them with WARN_ON() calls.
-Alex
Alex Elder (4):
net: ipa: fix ipa_cmd_table_valid()
net: ipa: always validate filter and route tables
net: ipa: kill the remaining conditional validation code
net: ipa: use WARN_ON() rather than assertions
drivers/net/ipa/Makefile | 3 -- drivers/net/ipa/gsi.c | 2 -- drivers/net/ipa/gsi_trans.c | 34 +++++++++++----------- drivers/net/ipa/ipa_cmd.c | 51 +++++++++++++++++++-------------- drivers/net/ipa/ipa_cmd.h | 22 +------------- drivers/net/ipa/ipa_endpoint.c | 26 ++++++++++------- drivers/net/ipa/ipa_interrupt.c | 8 ++++-- drivers/net/ipa/ipa_main.c | 7 +---- drivers/net/ipa/ipa_reg.h | 12 ++++---- drivers/net/ipa/ipa_resource.c | 3 +- drivers/net/ipa/ipa_table.c | 40 ++++++++++++-------------- drivers/net/ipa/ipa_table.h | 16 ----------- 12 files changed, 96 insertions(+), 128 deletions(-)
Signature · 1 line
2.27.0