Skip to content

Remaining patches for basic GuC submission

Matthew Brost dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest33 patches 14 repliesIn review

v2 from the cover letter

(Checkpatch)
- Fix checkpatch warning (1 remaining overrulled) (Daniele)
- Use an outer lock in guc_context_block / unblock

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/33drm/i915/guc: GuC virtual enginesdrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/intel_engine.h +6 more+311 -360 replies
2/33drm/i915/guc: Make hangcheck work with GuC virtual enginesdrivers/gpu/drm/i915/gt/intel_engine_types.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/i915_request.c+17 -10 replies
3/33drm/i915: Hold reference to intel_context over life of i915_requestdrivers/gpu/drm/i915/i915_request.c+23 -321 reply
4/33drm/i915/guc: Disable bonding extension with GuC submissiondrivers/gpu/drm/i915/gem/i915_gem_context.c+5 -00 replies
5/33drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbsdrivers/gpu/drm/i915/gt/intel_breadcrumbs.c drivers/gpu/drm/i915/gt/intel_breadcrumbs.h drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h +6 more+133 -370 replies
6/33drm/i915: Add i915_sched_engine destroy vfuncdrivers/gpu/drm/i915/i915_scheduler.c drivers/gpu/drm/i915/i915_scheduler.h drivers/gpu/drm/i915/i915_scheduler_types.h+8 -40 replies
7/33drm/i915: Move active request tracking to a vfuncdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/intel_engine_types.h +6 more+147 -370 replies
8/33drm/i915/guc: Reset implementation for new GuC interfacedrivers/gpu/drm/i915/gt/intel_gt_pm.c drivers/gpu/drm/i915/gt/intel_reset.c drivers/gpu/drm/i915/gt/uc/intel_guc.c +4 more+516 -1320 replies
9/33drm/i915: Reset GPU immediately if submission is disableddrivers/gpu/drm/i915/gt/intel_engine_heartbeat.c drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +3 more+79 -130 replies
10/33drm/i915/guc: Add disable interrupts to guc sanitizedrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_uc.c+19 -180 replies
11/33drm/i915/guc: Suspend/resume implementation for new interfacedrivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h drivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2 more+54 -510 replies
12/33drm/i915/guc: Handle context reset notificationdrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +1 more+51 -00 replies
13/33drm/i915/guc: Handle engine reset failure notificationdrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+48 -00 replies
14/33drm/i915/guc: Enable the timer expired interrupt for GuCdrivers/gpu/drm/i915/gt/intel_rps.c+4 -00 replies
15/33drm/i915/guc: Provide mmio list to be saved/restored on engine resetdrivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/gt/intel_workarounds_types.h drivers/gpu/drm/i915/gt/uc/intel_guc.h +2 more+222 -260 replies
16/33drm/i915/guc: Don't complain about reset racesdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_uc.c drivers/gpu/drm/i915/gt/uc/intel_uc.h+10 -10 replies
17/33drm/i915/guc: Enable GuC engine resetdrivers/gpu/drm/i915/gt/uc/intel_guc_ads.c+1 -20 replies
18/33drm/i915/guc: Capture error state on context resetdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_engine.h +4 more+91 -260 replies
19/33drm/i915/guc: Fix for error capture after full GPU reset with GuCdrivers/gpu/drm/i915/gt/intel_engine.h drivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c +6 more+229 -470 replies
20/33drm/i915/guc: Hook GuC scheduling policies updrivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+49 -50 replies
21/33drm/i915/guc: Connect reset modparam updates to GuC policy flagsdrivers/gpu/drm/i915/gt/uc/intel_guc_ads.c drivers/gpu/drm/i915/i915_debugfs_params.c+33 -11 reply
22/33drm/i915/guc: Include scheduling policies in the debugfs state dumpdrivers/gpu/drm/i915/gt/uc/intel_guc_ads.c drivers/gpu/drm/i915/gt/uc/intel_guc_ads.h drivers/gpu/drm/i915/gt/uc/intel_guc_debugfs.c+19 -00 replies
23/33drm/i915/guc: Add golden context to GuC ADSdrivers/gpu/drm/i915/gt/intel_gt.c drivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc.h +4 more+202 -300 replies
24/33drm/i915/guc: Implement banned contexts for GuC submissiondrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_context_types.h +5 more+195 -375 replies
25/33drm/i915/guc: Support request cancellationdrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_context_types.h +4 more+251 -144 replies
26/33drm/i915/selftest: Better error reporting from hangcheck selftestdrivers/gpu/drm/i915/gt/selftest_hangcheck.c+75 -180 replies
27/33drm/i915/selftest: Fix workarounds selftest for GuC submissiondrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gt/intel_engine_types.h drivers/gpu/drm/i915/gt/selftest_workarounds.c +3 more+203 -340 replies
28/33drm/i915/selftest: Fix MOCS selftest for GuC submissiondrivers/gpu/drm/i915/gt/selftest_mocs.c+35 -140 replies
29/33drm/i915/selftest: Increase some timeouts in live_requestsdrivers/gpu/drm/i915/selftests/i915_request.c+2 -21 reply
30/33drm/i915/selftest: Fix hangcheck self test for GuC submissiondrivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.h drivers/gpu/drm/i915/gt/selftest_hangcheck.c +4 more+236 -710 replies
31/33drm/i915/selftest: Bump selftest timeouts for hangcheckdrivers/gpu/drm/i915/gt/selftest_hangcheck.c drivers/gpu/drm/i915/selftests/igt_flush_test.c drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c+3 -30 replies
32/33drm/i915/guc: Implement GuC priority managementdrivers/gpu/drm/i915/gt/intel_breadcrumbs.c drivers/gpu/drm/i915/gt/intel_context_types.h drivers/gpu/drm/i915/gt/intel_engine_user.c +7 more+282 -52 replies
33/33drm/i915/guc: Unblock GuC submission on Gen11+drivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.h +1 more+18 -70 replies

Reviews trailers per patch

All 33 patches have a Reviewed-by or Acked-by.

PatchJohn HarrisonDaniele Ceraolo SpurioMatthew Brost
1/33R-b
2/33R-b
3/33R-b
4/33R-b
5/33R-b
6/33R-b
7/33R-b
8/33R-b
9/33R-b
10/33R-b
11/33R-b
12/33R-b
13/33R-b
14/33R-b
15/33R-b
16/33R-b
17/33R-b
18/33R-b
19/33R-b
20/33R-b
21/33R-b
22/33R-b
23/33R-b
24/33R-b
25/33R-b
26/33R-b
27/33R-b
28/33R-b
29/33R-b
30/33R-b
31/33R-b
32/33R-b
33/33R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/33] Remaining patches for basic GuC submission

The remaining patches for basic GuC submission [1]. Need 1 more RB and CI results to get this merged.

v2:
(Checkpatch)
- Fix checkpatch warning (1 remaining overrulled) (Daniele)
- Use an outer lock in guc_context_block / unblock

[1] https://patchwork.freedesktop.org/series/91840/

Daniele Ceraolo Spurio (1):
drm/i915/guc: Unblock GuC submission on Gen11+

Daniele Ceraolo Spurio (1):
drm/i915/guc: Unblock GuC submission on Gen11+

John Harrison (12):
drm/i915/guc: Make hangcheck work with GuC virtual engines drm/i915/guc: Provide mmio list to be saved/restored on engine reset drm/i915/guc: Don't complain about reset races drm/i915/guc: Enable GuC engine reset
drm/i915/guc: Fix for error capture after full GPU reset with GuC drm/i915/guc: Hook GuC scheduling policies up drm/i915/guc: Connect reset modparam updates to GuC policy flags drm/i915/guc: Include scheduling policies in the debugfs state dump drm/i915/guc: Add golden context to GuC ADS drm/i915/selftest: Better error reporting from hangcheck selftest drm/i915/selftest: Fix hangcheck self test for GuC submission drm/i915/selftest: Bump selftest timeouts for hangcheck

Matthew Brost (18):
drm/i915/guc: GuC virtual engines
drm/i915: Hold reference to intel_context over life of i915_request drm/i915/guc: Disable bonding extension with GuC submission drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbs drm/i915: Add i915_sched_engine destroy vfunc
drm/i915: Move active request tracking to a vfunc drm/i915/guc: Reset implementation for new GuC interface drm/i915: Reset GPU immediately if submission is disabled drm/i915/guc: Add disable interrupts to guc sanitize drm/i915/guc: Suspend/resume implementation for new interface drm/i915/guc: Handle context reset notification drm/i915/guc: Handle engine reset failure notification drm/i915/guc: Enable the timer expired interrupt for GuC drm/i915/guc: Capture error state on context reset drm/i915/guc: Implement banned contexts for GuC submission drm/i915/guc: Support request cancellation drm/i915/selftest: Increase some timeouts in live_requests drm/i915/guc: Implement GuC priority management

Rahul Kumar Singh (2):
drm/i915/selftest: Fix workarounds selftest for GuC submission drm/i915/selftest: Fix MOCS selftest for GuC submission

 drivers/gpu/drm/i915/Makefile                 |    1 +
 drivers/gpu/drm/i915/gem/i915_gem_context.c   |   15 +-
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c   |   44 +-
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.h   |   16 +-
 .../gpu/drm/i915/gt/intel_breadcrumbs_types.h |    7 +
 drivers/gpu/drm/i915/gt/intel_context.c       |   36 +
 drivers/gpu/drm/i915/gt/intel_context.h       |   23 +
 drivers/gpu/drm/i915/gt/intel_context_types.h |   33 +-
 drivers/gpu/drm/i915/gt/intel_engine.h        |   57 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  183 +-
 .../gpu/drm/i915/gt/intel_engine_heartbeat.c  |   70 +-
 .../gpu/drm/i915/gt/intel_engine_heartbeat.h  |    4 +
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |   13 +-
 drivers/gpu/drm/i915/gt/intel_engine_user.c   |    4 +
 .../drm/i915/gt/intel_execlists_submission.c  |   89 +-
 .../drm/i915/gt/intel_execlists_submission.h  |    4 -
 drivers/gpu/drm/i915/gt/intel_gt.c            |    2 +
 drivers/gpu/drm/i915/gt/intel_gt_pm.c         |    6 +-
 drivers/gpu/drm/i915/gt/intel_reset.c         |   50 +-
 .../gpu/drm/i915/gt/intel_ring_submission.c   |   58 +
 drivers/gpu/drm/i915/gt/intel_rps.c           |    4 +
 drivers/gpu/drm/i915/gt/intel_workarounds.c   |   46 +-
 .../gpu/drm/i915/gt/intel_workarounds_types.h |    1 +
 drivers/gpu/drm/i915/gt/mock_engine.c         |   34 +-
 .../drm/i915/gt/selftest_engine_heartbeat.c   |   22 +
 .../drm/i915/gt/selftest_engine_heartbeat.h   |    2 +
 drivers/gpu/drm/i915/gt/selftest_execlists.c  |   12 +-
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c  |  322 +++-
 drivers/gpu/drm/i915/gt/selftest_mocs.c       |   50 +-
 .../gpu/drm/i915/gt/selftest_workarounds.c    |  132 +-
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |    1 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   82 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   38 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |  464 ++++-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.h    |    4 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     |   11 +-
 .../gpu/drm/i915/gt/uc/intel_guc_debugfs.c    |    2 +
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 1611 +++++++++++++++--
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h |   13 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |  101 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.h         |    6 +
 drivers/gpu/drm/i915/i915_debugfs_params.c    |   32 +
 drivers/gpu/drm/i915/i915_gpu_error.c         |   25 +-
 drivers/gpu/drm/i915/i915_reg.h               |    1 +
 drivers/gpu/drm/i915/i915_request.c           |  162 +-
 drivers/gpu/drm/i915/i915_request.h           |   21 +
 drivers/gpu/drm/i915/i915_scheduler.c         |   16 +-
 drivers/gpu/drm/i915/i915_scheduler.h         |   10 +-
 drivers/gpu/drm/i915/i915_scheduler_types.h   |   22 +
 drivers/gpu/drm/i915/i915_trace.h             |   37 +-
 drivers/gpu/drm/i915/selftests/i915_request.c |    4 +-
 .../gpu/drm/i915/selftests/igt_flush_test.c   |    2 +-
 .../i915/selftests/intel_scheduler_helpers.c  |   88 +
 .../i915/selftests/intel_scheduler_helpers.h  |   33 +
 include/uapi/drm/i915_drm.h                   |    9 +
 55 files changed, 3501 insertions(+), 634 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c
 create mode 100644 drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.h
Signature · 6 lines
2.28.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx