Skip to content

virtio-pmem: Support describing pmem as shared memory region

[email protected] virtio-comment 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest1 patch 11 repliesIn review
  2. v41 patch 2 repliesSuperseded
  3. v31 patch 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v21 patch2 repliesSuperseded

Changes from v2 from the cover letter

- Incorporated suggestions from Cornelia Huck on rewording driver initialization.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1virtio-pmem: Support describing pmem as shared memory regionconformance.tex virtio-pmem.tex+45 -911 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchPankaj Gupta
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [virtio-comment] [PATCH v5 0/1] virtio-pmem: Support describing pmem as shared memory region

From: Taylor Stark <[email protected]>

Changes from v4 [1]:
- Clarified which fields of virtio_pmem_config are valid depending on shared memory feature negotiation (suggested by Cornelia Huck).

Changes from v3 [1]:
- Rebased onto master now that the base virtio-pmem spec has been merged.

Changes from v2:
- Incorporated suggestions from Cornelia Huck on rewording driver initialization.

Changes from v1:
- Added in a feature bit (VIRTIO_PMEM_F_SHMEM_REGION) for controlling how the device indicates the guest physical address ranges to the driver. This feature directly affects control flow of the driver, since it seemed weird to have the driver indicate support for shared memory regions, and then needing to include an enum (or similar) informing the driver how the device indicated guest physical address ranges. If devices want to indicate the ranges as guest absolute addresses, they can skip negotiating the feature.
- The linux driver implementation has been updated and tested, but I'm holding off on posting the patches to get some feedback on the new approach.
- Moved some changes to proper subsections (normative subsections).

[1] https://lists.oasis-open.org/archives/virtio-comment/202111/msg00004.html

---

This patch updates the virtio-pmem spec to add support for describing the pmem region as a shared memory region. This is required to support virtio-pmem in Hyper-V, since Hyper-V only allows PCI devices to operate on memory ranges defined via BARs. When using the virtio PCI transport, shared memory regions are described via PCI BARs.

As virtio-pmem hasn't been added to the virtio spec yet (see this issue [1]), this patch is based off the RFC spec [2]. The linux driver implementation has been posted at [3].

[1] https://github.com/oasis-tcs/virtio-spec/issues/78
[2] https://lists.oasis-open.org/archives/virtio-dev/201903/msg00083.html
[3] https://lore.kernel.org/nvdimm/20210715223505.GA29329@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net

Taylor Stark (1):
virtio-pmem: Support describing pmem as shared memory region

 conformance.tex | 14 ++++++++++++--
 virtio-pmem.tex | 40 +++++++++++++++++++++++++++++++++-------
 2 files changed, 45 insertions(+), 9 deletions(-)
Signature · 18 lines
2.33.0.vfs.0.0


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/