Skip to content

RFC mirror: rework soft-cancelling READY mirror

Vladimir Sementsov-Ogievskiy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3job: add job_complete_ex with do_graph_change argumentblock/mirror.c include/qemu/job.h job.c +3 more+29 -130 replies
2/3job: use complete(do_graph_change=false) to handle soft cancelblockdev.c+10 -10 replies
3/3job: drop force argument of *job*cancelblock/backup.c block/mirror.c blockdev.c +4 more+24 -370 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/3] mirror: rework soft-cancelling READY mirror

Hi all!

That's an alternative to (part of) Max's
"[PATCH for-6.1? v2 0/7] mirror: Handle errors after READY cancel" and shows' my idea of handling soft-cancelling READY mirror case directly in qmp_block_job_cancel. And cleanup all other job cancelling functions.

That's untested draft, don't take it to heart :)

Vladimir Sementsov-Ogievskiy (3):
job: add job_complete_ex with do_graph_change argument
job: use complete(do_graph_change=false) to handle soft cancel
job: drop force argument of *job*cancel

 include/qemu/job.h               | 19 ++++++++----------
 block/backup.c                   |  2 +-
 block/mirror.c                   | 33 +++++++++++++++++---------------
 blockdev.c                       | 13 +++++++++++--
 job-qmp.c                        |  2 +-
 job.c                            | 27 ++++++++++++++------------
 tests/unit/test-bdrv-drain.c     |  2 +-
 tests/unit/test-block-iothread.c |  2 +-
 tests/unit/test-blockjob-txn.c   |  8 ++++----
 tests/unit/test-blockjob.c       |  4 ++--
 10 files changed, 62 insertions(+), 50 deletions(-)
Signature · 1 line
2.29.2