Skip to content

drm: Make DRM's IRQ helpers legacy

Thomas Zimmermann amd-gfx dri-devel linux-arm-kernel linux-arm-msm 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 15 repliesIn review
  2. v114 patches 33 repliesSuperseded

Changes in v2 from the cover letter

* drop IRQ_NOTCONNECTED test from atmel-hlcdc (Sam)
* use devm_request_irq() in atmel-hlcdc (Sam)
* unify variable names in arm/hlcdc (Sam)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/amdgpu: Convert to Linux IRQ interfacesdrivers/gpu/drm/amd/amdgpu/amdgpu_drv.c drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h+15 -90 replies
2/14drm/arm/hdlcd: Convert to Linux IRQ interfacesdrivers/gpu/drm/arm/hdlcd_drv.c drivers/gpu/drm/arm/hdlcd_drv.h+97 -781 reply
3/14drm/atmel-hlcdc: Convert to Linux IRQ interfacesdrivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c+47 -330 replies
4/14drm/fsl-dcu: Convert to Linux IRQ interfacesdrivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c+46 -320 replies
5/14drm/gma500: Convert to Linux IRQ interfacesdrivers/gpu/drm/gma500/power.c drivers/gpu/drm/gma500/psb_drv.c drivers/gpu/drm/gma500/psb_drv.h +2 more+29 -150 replies
6/14drm/kmb: Convert to Linux IRQ interfacesdrivers/gpu/drm/kmb/kmb_drv.c+20 -60 replies
7/14drm/msm: Convert to Linux IRQ interfacesdrivers/gpu/drm/msm/msm_drv.c drivers/gpu/drm/msm/msm_kms.h+69 -466 replies
8/14drm/mxsfb: Convert to Linux IRQ interfacesdrivers/gpu/drm/mxsfb/mxsfb_drv.c drivers/gpu/drm/mxsfb/mxsfb_drv.h+52 -310 replies
9/14drm/radeon: Convert to Linux IRQ interfacesdrivers/gpu/drm/radeon/radeon_drv.c drivers/gpu/drm/radeon/radeon_irq_kms.c drivers/gpu/drm/radeon/radeon_kms.h+37 -150 replies
10/14drm/tidss: Convert to Linux IRQ interfacesdrivers/gpu/drm/tidss/tidss_drv.c drivers/gpu/drm/tidss/tidss_drv.h drivers/gpu/drm/tidss/tidss_irq.c +1 more+32 -160 replies
11/14drm/tilcdc: Convert to Linux IRQ interfacesdrivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+43 -113 replies
12/14drm/vc4: Convert to Linux IRQ interfacesdrivers/gpu/drm/vc4/vc4_drv.c drivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_irq.c +1 more+53 -240 replies
13/14drm: Remove unused devm_drm_irq_install()drivers/gpu/drm/drm_irq.c include/drm/drm_irq.h+0 -330 replies
14/14drm: IRQ midlayer is now legacydrivers/gpu/drm/drm_irq.c drivers/gpu/drm/drm_legacy_misc.c drivers/gpu/drm/drm_vblank.c +9 more+27 -1550 replies

Reviews trailers per patch

8 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlex DeucherChristian KönigSam RavnborgDan SneddonTomi ValkeinenDmitry BaryshkovAbhinav KumarRob ClarkLiviu Dudau
SeriesA-b
1/14R-b A-b
2/14A-b A-b
3/14R-b T-b
4/14
5/14
6/14
7/14R-b R-b A-b
8/14
9/14R-b
10/14R-b
11/14A-b
12/14
13/14
14/14A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux IRQ interfaces.

DRM provides IRQ helpers for setting up, receiving and removing IRQ handlers. It's an abstraction over plain Linux functions. The code is mid-layerish with several callbacks to hook into the rsp drivers. Old UMS driver have their interrupts enabled via ioctl, so these abstractions makes some sense. Modern KMS manage all their interrupts internally. Using the DRM helpers adds indirection without benefits.

Most KMS drivers already use Linux IRQ functions instead of DRM's abstraction layer. Patches 1 to 12 convert the remaining ones. The patches also resolve a bug for devices without assigned interrupt number. DRM helpers don't test for IRQ_NOTCONNECTED, so drivers do not detect if the device has no interrupt assigned.

Patch 13 removes an unused function.

Patch 14 moves the DRM IRQ helpers behind CONFIG_DRM_LEGACY. Only the old non-KMS drivers still use the functionality.

v2:
* drop IRQ_NOTCONNECTED test from atmel-hlcdc (Sam)
* use devm_request_irq() in atmel-hlcdc (Sam)
* unify variable names in arm/hlcdc (Sam)

Thomas Zimmermann (14):
drm/amdgpu: Convert to Linux IRQ interfaces drm/arm/hdlcd: Convert to Linux IRQ interfaces drm/atmel-hlcdc: Convert to Linux IRQ interfaces drm/fsl-dcu: Convert to Linux IRQ interfaces drm/gma500: Convert to Linux IRQ interfaces drm/kmb: Convert to Linux IRQ interfaces drm/msm: Convert to Linux IRQ interfaces drm/mxsfb: Convert to Linux IRQ interfaces drm/radeon: Convert to Linux IRQ interfaces drm/tidss: Convert to Linux IRQ interfaces drm/tilcdc: Convert to Linux IRQ interfaces drm/vc4: Convert to Linux IRQ interfaces
drm: Remove unused devm_drm_irq_install()
drm: IRQ midlayer is now legacy

 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c      |   1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c      |  21 ++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h      |   2 +-
 drivers/gpu/drm/arm/hdlcd_drv.c              | 174 ++++++++++---------
 drivers/gpu/drm/arm/hdlcd_drv.h              |   1 +
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c |  80 +++++----
 drivers/gpu/drm/drm_irq.c                    |  95 +---------
 drivers/gpu/drm/drm_legacy_misc.c            |   3 +-
 drivers/gpu/drm/drm_vblank.c                 |   8 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c    |  78 +++++----
 drivers/gpu/drm/gma500/power.c               |   1 +
 drivers/gpu/drm/gma500/psb_drv.c             |   8 +-
 drivers/gpu/drm/gma500/psb_drv.h             |   5 -
 drivers/gpu/drm/gma500/psb_irq.c             |  26 ++-
 drivers/gpu/drm/gma500/psb_irq.h             |   4 +-
 drivers/gpu/drm/i810/i810_dma.c              |   3 +-
 drivers/gpu/drm/kmb/kmb_drv.c                |  26 ++-
 drivers/gpu/drm/mga/mga_dma.c                |   2 +-
 drivers/gpu/drm/mga/mga_drv.h                |   1 -
 drivers/gpu/drm/msm/msm_drv.c                | 113 +++++++-----
 drivers/gpu/drm/msm/msm_kms.h                |   2 +-
 drivers/gpu/drm/mxsfb/mxsfb_drv.c            |  81 +++++----
 drivers/gpu/drm/mxsfb/mxsfb_drv.h            |   2 +
 drivers/gpu/drm/r128/r128_cce.c              |   3 +-
 drivers/gpu/drm/radeon/radeon_drv.c          |   4 -
 drivers/gpu/drm/radeon/radeon_irq_kms.c      |  44 ++++-
 drivers/gpu/drm/radeon/radeon_kms.h          |   4 -
 drivers/gpu/drm/tidss/tidss_drv.c            |  15 +-
 drivers/gpu/drm/tidss/tidss_drv.h            |   2 +
 drivers/gpu/drm/tidss/tidss_irq.c            |  27 ++-
 drivers/gpu/drm/tidss/tidss_irq.h            |   4 +-
 drivers/gpu/drm/tilcdc/tilcdc_drv.c          |  51 ++++--
 drivers/gpu/drm/tilcdc/tilcdc_drv.h          |   3 +
 drivers/gpu/drm/vc4/vc4_drv.c                |   4 -
 drivers/gpu/drm/vc4/vc4_drv.h                |   8 +-
 drivers/gpu/drm/vc4/vc4_irq.c                |  48 +++--
 drivers/gpu/drm/vc4/vc4_v3d.c                |  17 +-
 drivers/gpu/drm/via/via_mm.c                 |   3 +-
 include/drm/drm_device.h                     |  18 +-
 include/drm/drm_drv.h                        |  44 +----
 include/drm/drm_irq.h                        |  32 ----
 include/drm/drm_legacy.h                     |   3 +
 42 files changed, 567 insertions(+), 504 deletions(-)
 delete mode 100644 include/drm/drm_irq.h

base-commit: c9d6903562aa335593daf44b4a1edeaef6bf9206
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: c3f32630e1d2de2eb74316c930578847d4b83fb3
prerequisite-patch-id: b32ca0abfc255601f8a5052d3b88be09527dabcb
prerequisite-patch-id: 22a3f264168bacb04ef65306b32b86be8dc982ef
prerequisite-patch-id: 095a0acb604eb02956e1a7e53da41371c64eb813
prerequisite-patch-id: 7a2417d5d8d453204bd94aa873e3faae812f26fc --
2.32.0