drm/panel: atna33xc20: Fix the Samsung ATNA33XC20 panel
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 2 repliesIn review
- v16 patches 3 repliesSuperseded
Changes in v2 from the cover letter
- Added Fixes tag as requested by Sam.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | drm/dp: Don't zero PWMGEN_BIT_COUNT when driver_pwm_freq_hz not specifieddrivers/ | +6 | 0 replies | |
| 2/6 | drm/bridge: ti-sn65dsi86: Fix power off sequencedrivers/ | +7 | 0 replies | |
| 3/6 | drm/bridge: ti-sn65dsi86: Add some 100 us delaysdrivers/ | +6 | 0 replies | |
| 4/6 | Revert "drm/panel-simple: Add Samsung ATNA33XC20"drivers/ | +0 | 0 replies | |
| 5/6 | Revert "drm/panel-simple: Support for delays between GPIO & regulator"drivers/ | +0 | 0 replies | |
| 6/6 | drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 paneldrivers/ drivers/ drivers/ | +379 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Sean Paul | Robert Foss |
|---|---|---|
| 1/6 | R-b | |
| 2/6 | R-b | A-b |
| 3/6 | R-b | A-b |
| 4/6 | R-b | |
| 5/6 | R-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] drm/panel: atna33xc20: Fix the Samsung ATNA33XC20 panel
The overall goal of this series is to make the Samsung ATNA33XC20 panel work more properly. As part of this, we have:
* A bugfix for the recently abstracted DP AUX backlight code.
* A bugfix for the sequencing of the ti-sn65dsi86 bridge driver.
* Removal of the panel from panel-simple and moving it to its own driver.
If the bugfixes look good but the rest of the series needs work then those could land early on their own. There's no real compile time dependency on the bugfixes, things are just glitchier without them.
NOTE: this series will (slightly) conflict with my other recent series making eDP panels probable [1]. I'll re-post that one atop this one. It should be noted that the fact that the Samsung ATNA33XC20 needs its own panel driver means that it _can't_ handled as a probed driver. I think this is fine, at least for now. I don't think it would be easy to make a unified design with this panel and other panels given that it's an AMOLED panel and has a whole bunch of different components on board.
As discussed in IRC, the only difference in v2 is the addition of a "Fixes" tag to patch #3 and the collection of Reviews/Acks from Sean and Robert.
If people feel that this is ready to land today then I can help land it (please let me know). Otherwise I'm happy for someone else to actually do the commit next week (I'm on vacation) or I can take it when I get back.
[1] https://lore.kernel.org/r/[email protected]/
Changes in v2:
- Added Fixes tag as requested by Sam.
Douglas Anderson (6):
drm/dp: Don't zero PWMGEN_BIT_COUNT when driver_pwm_freq_hz not
specified
drm/bridge: ti-sn65dsi86: Fix power off sequence drm/bridge: ti-sn65dsi86: Add some 100 us delays
Revert "drm/panel-simple: Add Samsung ATNA33XC20"
Revert "drm/panel-simple: Support for delays between GPIO & regulator" drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 17 +- drivers/gpu/drm/drm_dp_helper.c | 10 +- drivers/gpu/drm/panel/Kconfig | 12 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-samsung-atna33xc20.c | 366 ++++++++++++++++++ drivers/gpu/drm/panel/panel-simple.c | 61 --- 6 files changed, 398 insertions(+), 69 deletions(-) create mode 100644 drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
Signature · 1 line
2.32.0.554.ge1b32706d8-goog