Skip to content

x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes

James Morse lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 29 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20x86/resctrl: Kill off alloc_enabledarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/pseudo_lock.c +2 more+3 -132 replies
2/20x86/resctrl: Merge mon_capable and mon_enabledarch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c arch/x86/kernel/cpu/resctrl/rdtgroup.c +1 more+6 -112 replies
3/20x86/resctrl: Add domain online callback for resctrl workarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/rdtgroup.c +1 more+67 -542 replies
4/20x86/resctrl: Add domain offline callback for resctrl workarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/rdtgroup.c +1 more+37 -292 replies
5/20x86/resctrl: Create mba_sc configuration in the rdt_domainarch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/rdtgroup.c include/linux/resctrl.h+82 -14 replies
6/20x86/resctrl: Switch over to the resctrl mbps_val listarch/x86/kernel/cpu/resctrl/ctrlmondata.c arch/x86/kernel/cpu/resctrl/monitor.c+31 -244 replies
7/20x86/resctrl: Remove architecture copy of mbps_valarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/rdtgroup.c+6 -202 replies
8/20x86/resctrl: Remove set_mba_sc()s control array re-initialisationarch/x86/kernel/cpu/resctrl/rdtgroup.c+0 -60 replies
9/20x86/resctrl: Abstract and use supports_mba_mbps()arch/x86/kernel/cpu/resctrl/rdtgroup.c+14 -54 replies
10/20x86/resctrl: Allow update_mba_bw() to update controls directlyarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/ctrlmondata.c arch/x86/kernel/cpu/resctrl/internal.h +2 more+34 -111 reply
11/20x86/resctrl: Calculate bandwidth from the total bytes counterarch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c+12 -72 replies
12/20x86/recstrl: Add per-rmid arch private storage for overflow and chunksarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h+42 -02 replies
13/20x86/recstrl: Allow per-rmid arch private storage to be resetarch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c include/linux/resctrl.h+59 -202 replies
14/20x86/resctrl: Abstract __rmid_read()arch/x86/kernel/cpu/resctrl/ctrlmondata.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c +1 more+31 -200 replies
15/20x86/resctrl: Pass the required parameters into resctrl_arch_rmid_read()arch/x86/kernel/cpu/resctrl/monitor.c include/linux/resctrl.h+32 -160 replies
16/20x86/resctrl: Move mbm_overflow_count() into resctrl_arch_rmid_read()arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c+23 -210 replies
17/20x86/resctrl: Move get_corrected_mbm_count() into resctrl_arch_rmid_read()arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c+8 -110 replies
18/20x86/resctrl: Rename and change the units of resctrl_cqm_thresholdarch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c arch/x86/kernel/cpu/resctrl/rdtgroup.c +1 more+20 -260 replies
19/20x86/resctrl: Add resctrl_rmid_realloc_limit to abstract x86's boot_cpu_dataarch/x86/kernel/cpu/resctrl/monitor.c arch/x86/kernel/cpu/resctrl/rdtgroup.c include/linux/resctrl.h+9 -30 replies
20/20x86/resctrl: Make resctrl_arch_rmid_read() return values in bytesarch/x86/kernel/cpu/resctrl/ctrlmondata.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c +1 more+14 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 00/20] x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes

Hi folks,

This series builds on v7 of "x86/resctrl: Merge the CDP resources", available from [0] or [1]

The aim of this series is to insert a split between the parts of the monitor code that the architecture must implement, and those that are part of the resctrl filesystem. The eventual aim is to move all filesystem parts out to live in /fs/resctrl, so that resctrl can be wired up for MPAM.

What's MPAM? See the cover letter of a previous series. [1]

The series adds domain online/offline callbacks to allow the filesystem to manage some of its structures itself, then moves all the 'mba_sc' behaviour to be part of the filesystem.
This means another architecture doesn't need to provide an mbps_val array. As its all software, the resctrl filesystem should be able to do this without any help from the architecture code.

Finally __rmid_read() is refactored to be the API call that the architecture provides to read a counter value. All the hardware specific overflow detection, scaling and value correction should occur behind this helper.

This series is based on v5.14-rc1, and can be retrieved from:
git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/resctrl_monitors_in_bytes/v1

[0] git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/resctrl_merge_cdp/v7
[1] https://lore.kernel.org/lkml/[email protected]/

Thanks,

James Morse (20):
x86/resctrl: Kill off alloc_enabled
x86/resctrl: Merge mon_capable and mon_enabled x86/resctrl: Add domain online callback for resctrl work x86/resctrl: Add domain offline callback for resctrl work x86/resctrl: Create mba_sc configuration in the rdt_domain x86/resctrl: Switch over to the resctrl mbps_val list x86/resctrl: Remove architecture copy of mbps_val x86/resctrl: Remove set_mba_sc()s control array re-initialisation x86/resctrl: Abstract and use supports_mba_mbps() x86/resctrl: Allow update_mba_bw() to update controls directly x86/resctrl: Calculate bandwidth from the total bytes counter x86/recstrl: Add per-rmid arch private storage for overflow and chunks x86/recstrl: Allow per-rmid arch private storage to be reset x86/resctrl: Abstract __rmid_read()
x86/resctrl: Pass the required parameters into
resctrl_arch_rmid_read()
x86/resctrl: Move mbm_overflow_count() into resctrl_arch_rmid_read() x86/resctrl: Move get_corrected_mbm_count() into
resctrl_arch_rmid_read()
x86/resctrl: Rename and change the units of resctrl_cqm_threshold x86/resctrl: Add resctrl_rmid_realloc_limit to abstract x86's
boot_cpu_data
x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes

 arch/x86/kernel/cpu/resctrl/core.c        |  96 +++-------
 arch/x86/kernel/cpu/resctrl/ctrlmondata.c |  76 +++++---
 arch/x86/kernel/cpu/resctrl/internal.h    |  62 +++----
 arch/x86/kernel/cpu/resctrl/monitor.c     | 190 +++++++++++--------
 arch/x86/kernel/cpu/resctrl/pseudo_lock.c |   2 +-
 arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 217 ++++++++++++++++++----
 include/linux/resctrl.h                   |  69 ++++++-
 7 files changed, 462 insertions(+), 250 deletions(-)
Signature · 1 line
2.30.2