Skip to content

Reduce usage of timestamp macros

Pali Rohár u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 45 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11Remove #include <timestamp.h> from files which do not need itarch/m68k/cpu/mcf5445x/start.S net/cdp.c+0 -42 replies
2/11Remove #include <version.h> from files which do not need itarch/arm/mach-rockchip/px30-board-tpl.c arch/nios2/cpu/start.S arch/x86/lib/acpi_table.c +5 more+0 -82 replies
3/11efi_loader: Use directly version_string variablelib/efi_loader/efi_tcg2.c+2 -33 replies
4/11version: Move version_string[] from version.h to version_string.hboard/ge/b1x5v2/b1x5v2.c board/ge/bx50v3/bx50v3.c board/ge/mx53ppd/mx53ppd.c +8 more+17 -122 replies
5/11m68k: mcf: Remove overloading version_stringarch/m68k/cpu/mcf5227x/start.S arch/m68k/cpu/mcf523x/start.S arch/m68k/cpu/mcf52x2/start.S +3 more+0 -381 reply
6/11version: Put version_string[] variable into section .text_version_stringcmd/version.c+1 -112 replies
7/11powerpc: mpc: Put U-Boot version string at correct place by linker scriptarch/powerpc/cpu/mpc83xx/start.S arch/powerpc/cpu/mpc83xx/u-boot.lds arch/powerpc/cpu/mpc85xx/start.S +5 more+28 -189 replies
8/11version: Do not make version_string[] variable as a weakcmd/version.c+1 -12 replies
9/11x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug logarch/x86/cpu/quark/mrc.c+1 -33 replies
10/11version: Remove global macro U_BOOT_VERSION_STRING from version.hcmd/version.c doc/develop/version.rst include/version.h+15 -122 replies
11/11Remove including timestamp.h in version.harch/arm/mach-rockchip/tpl.c board/work-microwave/work_92105/work_92105_display.c cmd/version.c +3 more+11 -315 replies

Reviews trailers per patch

9 of 11 patches have a Reviewed-by or Acked-by.

PatchTom RiniSimon GlassBin MengIlias Apalodimas
1/11R-b
2/11R-b
3/11A-b
4/11R-b
5/11
6/11R-b
7/11
8/11R-b
9/11R-b R-b
10/11R-b
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/11] Reduce usage of timestamp macros

Including timestamp.h (either directly or transitionally) cause build system to recompile binaries at every 'make' run. This has disadvantage in U-Boot development as for every small change 'make' recompiles lot of other irrelevant files which were not touched / changed.

This patch series eliminate transitional / indirect usage of timestamp.h by removing unneeded inclusion of header files, moving timestamp values from macros to global variables, etc...

After these patches, U-Boot tools are not recompiled by every 'make' run, which decrease time for incremental U-Boot recompilation.

Please test these patches, specially m68k and powerpc parts as I do not have any of these boards.

Patch series depend on this patch (now marked as accepted):
http://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Pali Rohár (11):
Remove #include <timestamp.h> from files which do not need it Remove #include <version.h> from files which do not need it
efi_loader: Use directly version_string variable
version: Move version_string[] from version.h to version_string.h
m68k: mcf: Remove overloading version_string
version: Put version_string[] variable into section
.text_version_string
powerpc: mpc: Put U-Boot version string at correct place by linker
script
version: Do not make version_string[] variable as a weak
x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log
version: Remove global macro U_BOOT_VERSION_STRING from version.h Remove including timestamp.h in version.h

 arch/arm/mach-rockchip/px30-board-tpl.c       |  1 -
 arch/arm/mach-rockchip/tpl.c                  |  4 ++++
 arch/m68k/cpu/mcf5227x/start.S                |  6 ------
 arch/m68k/cpu/mcf523x/start.S                 |  6 ------
 arch/m68k/cpu/mcf52x2/start.S                 |  6 ------
 arch/m68k/cpu/mcf530x/start.S                 |  8 -------
 arch/m68k/cpu/mcf532x/start.S                 |  6 ------
 arch/m68k/cpu/mcf5445x/start.S                |  7 -------
 arch/nios2/cpu/start.S                        |  1 -
 arch/powerpc/cpu/mpc83xx/start.S              | 10 +++------
 arch/powerpc/cpu/mpc83xx/u-boot.lds           |  3 +++
 arch/powerpc/cpu/mpc85xx/start.S              | 10 ++++-----
 arch/powerpc/cpu/mpc85xx/u-boot-nand.lds      |  4 ++++
 arch/powerpc/cpu/mpc85xx/u-boot-spl.lds       |  4 ++++
 arch/powerpc/cpu/mpc85xx/u-boot.lds           |  4 ++++
 arch/powerpc/cpu/mpc8xx/start.S               |  9 ++++----
 arch/x86/cpu/quark/mrc.c                      |  4 +---
 arch/x86/lib/acpi_table.c                     |  1 -
 board/atmel/sama5d2_ptc_ek/sama5d2_ptc_ek.c   |  1 -
 board/cssi/MCR3000/u-boot.lds                 |  2 ++
 board/ge/b1x5v2/b1x5v2.c                      |  2 +-
 board/ge/bx50v3/bx50v3.c                      |  2 +-
 board/ge/mx53ppd/mx53ppd.c                    |  2 +-
 board/l+g/vinco/vinco.c                       |  1 -
 board/renesas/grpeach/lowlevel_init.S         |  1 -
 .../work_92105/work_92105_display.c           |  1 +
 cmd/version.c                                 |  7 ++++++-
 common/main.c                                 |  2 +-
 common/spl/spl.c                              |  4 ++++
 doc/develop/version.rst                       | 21 +++++++++++--------
 drivers/rtc/emul_rtc.c                        |  2 +-
 drivers/usb/gadget/f_rockusb.c                |  1 -
 drivers/video/cfb_console.c                   |  3 +--
 include/configs/bcmstb.h                      |  1 -
 include/version.h                             |  8 -------
 include/version_string.h                      |  8 +++++++
 lib/display_options.c                         |  2 +-
 lib/efi_loader/efi_tcg2.c                     |  7 +++----
 net/cdp.c                                     |  3 ---
 test/print_ut.c                               |  2 +-
 40 files changed, 75 insertions(+), 102 deletions(-)
 create mode 100644 include/version_string.h
Signature · 1 line
2.20.1