Skip to content

Provide offset-adjusted framebuffer mappings

Thomas Zimmermann dri-devel linux-hyperv virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/gem: Provide offset-adjusted framebuffer BO mappingsdrivers/gpu/drm/drm_gem_atomic_helper.c drivers/gpu/drm/drm_gem_framebuffer_helper.c drivers/gpu/drm/gud/gud_pipe.c +3 more+29 -51 reply
2/11drm/ast: Use offset-adjusted shadow-plane mappingsdrivers/gpu/drm/ast/ast_mode.c+1 -10 replies
3/11drm/gud: Get offset-adjusted mapping from drm_gem_fb_vmap()drivers/gpu/drm/gud/gud_pipe.c+3 -20 replies
4/11drm/hyperv: Use offset-adjusted shadow-plane mappingsdrivers/gpu/drm/hyperv/hyperv_drm_modeset.c+2 -20 replies
5/11drm/mgag200: Use offset-adjusted shadow-plane mappingsdrivers/gpu/drm/mgag200/mgag200_mode.c+2 -20 replies
6/11drm/cirrus: Use offset-adjusted shadow-plane mappingsdrivers/gpu/drm/tiny/cirrus.c+2 -20 replies
7/11drm/gm12u320: Use offset-adjusted shadow-plane mappingsdrivers/gpu/drm/tiny/gm12u320.c+2 -20 replies
8/11drm/simpledrm: Use offset-adjusted shadow-plane mappingdrivers/gpu/drm/tiny/simpledrm.c+2 -20 replies
9/11drm/udl: Use offset-adjusted shadow-plane mappingdrivers/gpu/drm/udl/udl_modeset.c+2 -20 replies
10/11drm/vbox: Use offset-adjusted shadow-plane mappingsdrivers/gpu/drm/vboxvideo/vbox_mode.c+1 -10 replies
11/11drm/vkms: Use offset-adjusted shadow-plane mappings and outputdrivers/gpu/drm/vkms/vkms_composer.c drivers/gpu/drm/vkms/vkms_drv.h drivers/gpu/drm/vkms/vkms_plane.c +1 more+4 -30 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSam Ravnborg
SeriesA-b
1/11R-b
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] Provide offset-adjusted framebuffer mappings

A framebuffer's offsets field might be non-zero to make the BO data start at the specified offset within the BO's memory. Handle this case in drm_gem_fb_vmap() and update all callers. So far, many drivers ignore the offsets, which can lead to visual artifacts.

Patch 1 adds an optional argument to drm_gem_fb_vmap() to return the offset-adjusted data address for use with shadow-buffered planes.

Patches 3 and 11 convert gud and vkms, which are the other callers of drm_gem_fb_vmap(). For gud, it's just a cleanup. Vkms will handle the framebuffer offsets correctly for its input and output framebuffers.

The other patches convert users of shadow-buffered planes to use the data address. After conversion, each driver will use the correct data for non-zero offsets.

Thomas Zimmermann (11):
drm/gem: Provide offset-adjusted framebuffer BO mappings drm/ast: Use offset-adjusted shadow-plane mappings drm/gud: Get offset-adjusted mapping from drm_gem_fb_vmap() drm/hyperv: Use offset-adjusted shadow-plane mappings drm/mgag200: Use offset-adjusted shadow-plane mappings drm/cirrus: Use offset-adjusted shadow-plane mappings drm/gm12u320: Use offset-adjusted shadow-plane mappings drm/simpledrm: Use offset-adjusted shadow-plane mapping drm/udl: Use offset-adjusted shadow-plane mapping drm/vbox: Use offset-adjusted shadow-plane mappings drm/vkms: Use offset-adjusted shadow-plane mappings and output

 drivers/gpu/drm/ast/ast_mode.c               |  2 +-
 drivers/gpu/drm/drm_gem_atomic_helper.c      |  2 +-
 drivers/gpu/drm/drm_gem_framebuffer_helper.c | 17 ++++++++++++++++-
 drivers/gpu/drm/gud/gud_pipe.c               |  5 +++--
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c  |  4 ++--
 drivers/gpu/drm/mgag200/mgag200_mode.c       |  4 ++--
 drivers/gpu/drm/tiny/cirrus.c                |  4 ++--
 drivers/gpu/drm/tiny/gm12u320.c              |  4 ++--
 drivers/gpu/drm/tiny/simpledrm.c             |  4 ++--
 drivers/gpu/drm/udl/udl_modeset.c            |  4 ++--
 drivers/gpu/drm/vboxvideo/vbox_mode.c        |  2 +-
 drivers/gpu/drm/vkms/vkms_composer.c         |  2 +-
 drivers/gpu/drm/vkms/vkms_drv.h              |  1 +
 drivers/gpu/drm/vkms/vkms_plane.c            |  2 +-
 drivers/gpu/drm/vkms/vkms_writeback.c        |  2 +-
 include/drm/drm_gem_atomic_helper.h          |  8 ++++++++
 include/drm/drm_gem_framebuffer_helper.h     |  3 ++-
 17 files changed, 48 insertions(+), 22 deletions(-)

--
2.32.0