Skip to content

Performance optimization for no fsnotify marks

Amir Goldstein linux-fsdevel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v14 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Rebase on 5.14-rc5 + pidfd patches
- Added RVB
- Helper to get connector's sb (Matthew)
- Fix deadlock bug on umount (Jan)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fsnotify: replace igrab() with ihold() on attach connectorfs/notify/mark.c+5 -20 replies
2/4fsnotify: count s_fsnotify_inode_refs for attached connectorsfs/notify/mark.c+18 -110 replies
3/4fsnotify: count all objects with attached connectorsfs/notify/fsnotify.c fs/notify/fsnotify.h fs/notify/mark.c +1 more+41 -83 replies
4/4fsnotify: optimize the case of no marks of any typeinclude/linux/fsnotify.h+9 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMatthew Bobrowski
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Performance optimization for no fsnotify marks

Hi Jan,

Following v2 addresses review comments from v1 [1]

[1] https://lore.kernel.org/linux-fsdevel/[email protected]/

Changes since v1:
- Rebase on 5.14-rc5 + pidfd patches
- Added RVB
- Helper to get connector's sb (Matthew)
- Fix deadlock bug on umount (Jan)

Amir Goldstein (4):
fsnotify: replace igrab() with ihold() on attach connector
fsnotify: count s_fsnotify_inode_refs for attached connectors
fsnotify: count all objects with attached connectors
fsnotify: optimize the case of no marks of any type

 fs/notify/fsnotify.c     |  6 ++---
 fs/notify/fsnotify.h     | 15 ++++++++++++
 fs/notify/mark.c         | 52 ++++++++++++++++++++++++++++++----------
 include/linux/fs.h       |  4 ++--
 include/linux/fsnotify.h |  9 +++++++
 5 files changed, 69 insertions(+), 17 deletions(-)
Signature · 1 line
2.32.0