staging: r8188eu: Fix clang warnings
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 1 replyIn review
- v14 patches 5 repliesSuperseded
Changes in v2 from the cover letter
* Rebase on staging-testing and fix conflict in patch 2.
* Drop patch 1 as it has already been fixed with commit 1c10f2b95cc1 ("staging: r8188eu: Remove all calls to _rtw_spinlock_free()") and follow-ups.
* Pick up Nick's reviewed-by tag for patches 1 and 2.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | staging: r8188eu: Remove unnecessary parenthesesdrivers/ drivers/ drivers/ +2 more | +6 | 0 replies | |
| 2/3 | staging: r8188eu: Remove self assignment in get_rx_power_val_by_reg()drivers/ | +0 | 0 replies | |
| 3/3 | staging: r8188eu: Remove pointless NULL check in rtw_check_join_candidate()drivers/ | +1 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Nick Desaulniers |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] staging: r8188eu: Fix clang warnings
This series cleans up all of the clang warnings that I noticed with x86_64 allmodconfig on the current staging-testing. This has been build tested with both clang and gcc with x86_64 allmodconfig.
v1 -> v2:
* Rebase on staging-testing and fix conflict in patch 2.
* Drop patch 1 as it has already been fixed with commit 1c10f2b95cc1 ("staging: r8188eu: Remove all calls to _rtw_spinlock_free()") and follow-ups.
* Pick up Nick's reviewed-by tag for patches 1 and 2.
Nathan Chancellor (3):
staging: r8188eu: Remove unnecessary parentheses
staging: r8188eu: Remove self assignment in get_rx_power_val_by_reg()
staging: r8188eu: Remove pointless NULL check in
rtw_check_join_candidate()
drivers/staging/r8188eu/core/rtw_mlme.c | 2 +- drivers/staging/r8188eu/core/rtw_pwrctrl.c | 2 +- drivers/staging/r8188eu/core/rtw_security.c | 4 ++-- drivers/staging/r8188eu/core/rtw_wlan_util.c | 2 +- drivers/staging/r8188eu/hal/odm.c | 2 +- drivers/staging/r8188eu/hal/rtl8188e_rf6052.c | 2 -- drivers/staging/r8188eu/hal/usb_halinit.c | 2 +- 7 files changed, 7 insertions(+), 9 deletions(-)
base-commit: d48401b8609ff19db0f461759ac6b5210cd81288
Signature · 1 line
2.33.0.rc0