Skip to content

ARC atomics update

Vineet Gupta linux-arch linux-snps-arc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11ARC: atomics: disintegrate headerarch/arc/include/asm/atomic-llsc.h arch/arc/include/asm/atomic-spinlock.h arch/arc/include/asm/atomic.h +1 more+461 -4240 replies
2/11ARC: atomic: !LLSC: remove hack in atomic_set() for for UParch/arc/include/asm/atomic-spinlock.h+4 -130 replies
3/11ARC: atomic: !LLSC: use int data type consistentlyarch/arc/include/asm/atomic-spinlock.h+2 -20 replies
4/11ARC: atomic64: LLSC: elide unused atomic_{and,or,xor,andnot}_returnarch/arc/include/asm/atomic64-arcv2.h+6 -00 replies
5/11ARC: atomics: implement relaxed variantsarch/arc/include/asm/atomic-llsc.h arch/arc/include/asm/atomic64-arcv2.h+26 -300 replies
6/11ARC: switch to generic bitopsarch/arc/include/asm/bitops.h arch/arc/include/asm/smp.h arch/arc/kernel/smp.c+2 -1980 replies
7/11ARC: bitops: fls/ffs to take int (vs long) per asm-generic definesarch/arc/include/asm/bitops.h+2 -20 replies
8/11ARC: xchg: !LLSC: remove UP micro-optimization/hackarch/arc/include/asm/cmpxchg.h+1 -110 replies
9/11ARC: cmpxchg/xchg: rewrite as macros to make type safearch/arc/include/asm/cmpxchg.h+117 -920 replies
10/11ARC: cmpxchg/xchg: implement relaxed variants (LLSC config only)arch/arc/include/asm/cmpxchg.h+2 -90 replies
11/11ARC: atomic_cmpxchg/atomic_xchg: implement relaxed variantsarch/arc/include/asm/atomic.h arch/arc/include/asm/cmpxchg.h+27 -230 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPeter Zijlstra (Intel)Will Deacon
SeriesA-b A-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] ARC atomics update

Hi,

This series contains long due update to ARC atomics, discussed back in 2018 [1] and [2]. I had them for arc64 port and decided to post them here for some review and inclusion, after Mark's rework.

The main changes are use of relaxed atomics and generic bitops. Latter does cause some cogen bloat on ARC due to signed args but that can be reviewd seperately consider cross-arch impact.

The changes survive glibc testsuite with no regressions whatsoever.

Please review and provide any feedback.

Thx,
-Vineet

[1] https://lore.kernel.org/r/[email protected]
[2] https://lore.kernel.org/r/[email protected]

Vineet Gupta (10):
ARC: atomics: disintegrate header
ARC: atomic: !LLSC: remove hack in atomic_set() for for UP
ARC: atomic: !LLSC: use int data type consistently
ARC: atomic64: LLSC: elide unused atomic_{and,or,xor,andnot}_return
ARC: atomics: implement relaxed variants
ARC: bitops: fls/ffs to take int (vs long) per asm-generic defines
ARC: xchg: !LLSC: remove UP micro-optimization/hack
ARC: cmpxchg/xchg: rewrite as macros to make type safe
ARC: cmpxchg/xchg: implement relaxed variants (LLSC config only)
ARC: atomic_cmpxchg/atomic_xchg: implement relaxed variants

Will Deacon (1):
ARC: switch to generic bitops

 arch/arc/include/asm/atomic-llsc.h     |  97 ++++++
 arch/arc/include/asm/atomic-spinlock.h | 102 ++++++
 arch/arc/include/asm/atomic.h          | 444 ++-----------------------
 arch/arc/include/asm/atomic64-arcv2.h  | 250 ++++++++++++++
 arch/arc/include/asm/bitops.h          | 188 +----------
 arch/arc/include/asm/cmpxchg.h         | 233 ++++++-------
 arch/arc/include/asm/smp.h             |  14 -
 arch/arc/kernel/smp.c                  |   2 -
 8 files changed, 588 insertions(+), 742 deletions(-)
 create mode 100644 arch/arc/include/asm/atomic-llsc.h
 create mode 100644 arch/arc/include/asm/atomic-spinlock.h
 create mode 100644 arch/arc/include/asm/atomic64-arcv2.h
Signature · 1 line
2.25.1