Re-add SELinux checks for unit install operations
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | selinux: add function name to audit datasrc/ src/ | +19 | 0 replies | |
| 2/7 | selinux: improve debug log formatsrc/ | +2 | 0 replies | |
| 3/7 | selinux: mark _mac_selinux_generic_access_check with leading underscoresrc/ src/ | +9 | 0 replies | |
| 4/7 | core: add support for MAC checks on unit install operationssrc/ src/ src/ +8 more | +225 | 0 replies | |
| 5/7 | core: implement the sd-bus generic callback for SELinuxsrc/ src/ src/ +5 more | +168 | 0 replies | |
| 6/7 | core: avoid bypasses in D-BUS SELinux filtersrc/ | +19 | 0 replies | |
| 7/7 | core: tweak job_type_to_access_method SELinux permissionssrc/ | +11 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH SYSTEMD 0/7] Re-add SELinux checks for unit install operations
The checks (permission verbs) in question are enable for the operations enable, reenable, link and unmask and disable for the operations disable and mask; those SELinux permissions exist in the the reference and fedora SELinux policy.
These checks were dropped with v225 (see [1]) due to incomplete and missing infrastructure in the unit handling code.
In addition the operations preset and revert are checked with the (also already existing) SELinux permission reload.
(In the future I'd like to separate them into a new permission modify? together with calls to the standard D-Bus interfaces at org.freedesktop.DBus.Properties.Set.)
Job actions JOB_RELOAD_OR_START and JOB_VERIFY_ACTIVE are now checked with the permission start instead of reload.
The D-Bus filter now falls back to an instance check in case no unit can be decoded (e.g. the job has finished or the unit does not exist).
Reduced proposal of [2]/[3]
Closes: [4]
[1]: https://github.com/systemd/systemd/pull/1044
[2]: https://github.com/systemd/systemd/pull/10023
[3]: https://lore.kernel.org/selinux/[email protected]/
[4]: https://github.com/systemd/systemd/issues/1050
Christian Göttsche (7):
selinux: add function name to audit data
selinux: improve debug log format
selinux: mark _mac_selinux_generic_access_check with leading
underscore
core: add support for MAC checks on unit install operations
core: implement the sd-bus generic callback for SELinux
core: avoid bypasses in D-BUS SELinux filter
core: tweak job_type_to_access_method SELinux permissions
src/core/dbus-callbackdata.h | 15 +++ src/core/dbus-manager.c | 70 +++++++--- src/core/dbus.c | 44 +++---- src/core/job.c | 14 +- src/core/manager.c | 9 +- src/core/manager.h | 1 + src/core/selinux-access.c | 75 +++++++++-- src/core/selinux-access.h | 17 ++- src/shared/install.c | 160 ++++++++++++++++++++--- src/shared/install.h | 44 +++++-- src/systemctl/systemctl-add-dependency.c | 2 +- src/systemctl/systemctl-enable.c | 16 +-- src/systemctl/systemctl-is-enabled.c | 2 +- src/systemctl/systemctl-preset-all.c | 2 +- src/test/test-install-root.c | 88 ++++++------- src/test/test-install.c | 38 +++--- 16 files changed, 437 insertions(+), 160 deletions(-) create mode 100644 src/core/dbus-callbackdata.h
--
2.32.0