Skip to content

net: ethernet: ti: cpsw/emac: switch to use skb_put_padto()

Grygorii Strashko linux-omap lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net: ethernet: ti: cpsw: switch to use skb_put_padto()drivers/net/ethernet/ti/cpsw.c+1 -10 repliesApplied
2/3net: ethernet: ti: davinci_emac: switch to use skb_put_padto()drivers/net/ethernet/ti/davinci_emac.c+1 -10 repliesApplied
3/3net: ethernet: ti: davinci_cpdma: drop frame paddingdrivers/net/ethernet/ti/cpsw_priv.c drivers/net/ethernet/ti/davinci_cpdma.c drivers/net/ethernet/ti/davinci_cpdma.h +1 more+0 -80 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/3] net: ethernet: ti: cpsw/emac: switch to use skb_put_padto()

hi

Now frame padding in TI TI CPSW/EMAC is implemented in a bit of entangled way as frame SKB padded in drivers (without skb->len) while frame length fixed in CPDMA. Things became even more confusing hence CPSW switcdev driver need to perform min TX frame length correction in switch mode [1].

To avoid further confusion, make xmit path more clear and linear, and avoid updating CPDMA configuration interface for min TX frame length correction (which is not CPDMA job in general) this series switches TI CPSW/EMAC drivers to skb_put_padto() instead of skb_padto() in their xmit path, so skb->len also got updated properly and then removes TX frame length fixup from CPDMA code.

[1] https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/

Grygorii Strashko (3):
net: ethernet: ti: cpsw: switch to use skb_put_padto()
net: ethernet: ti: davinci_emac: switch to use skb_put_padto()
net: ethernet: ti: davinci_cpdma: drop frame padding

 drivers/net/ethernet/ti/cpsw.c          | 2 +-
 drivers/net/ethernet/ti/cpsw_priv.c     | 1 -
 drivers/net/ethernet/ti/davinci_cpdma.c | 5 -----
 drivers/net/ethernet/ti/davinci_cpdma.h | 1 -
 drivers/net/ethernet/ti/davinci_emac.c  | 3 +--
 5 files changed, 2 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1