Skip to content

iio: potentiometer: Add driver support for AD5110

Mugilraj Dhavachelvan linux-devicetree linux-iio lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 11 repliesSuperseded
  3. v12 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- Drop Redundant blank lines
- Add missed prefix name
- Add comma to non terminator line
- Add missed error code return when ret < 0
- Explanation for msleep(20)
- Change to IIO_DEVICE_ATTR_RW()
- Remove comma for terminator line
- Drop data->cfg dead code since I'm using probe_new()

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: iio: potentiometer: Add AD5110 in trivial-devicesDocumentation/devicetree/bindings/trivial-devices.yaml+2 -00 replies
2/2iio: potentiometer: Add driver support for AD5110MAINTAINERS drivers/iio/potentiometer/Kconfig drivers/iio/potentiometer/Makefile +1 more+362 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRob HerringAndy Shevchenko
1/2A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] iio: potentiometer: Add driver support for AD5110

Add dt-bindings and driver support for AD5110, a Nonvolatile Digital Potentiometer.

Changes since v2:
- Drop Redundant blank lines
- Add missed prefix name
- Add comma to non terminator line
- Add missed error code return when ret < 0
- Explanation for msleep(20)
- Change to IIO_DEVICE_ATTR_RW()
- Remove comma for terminator line
- Drop data->cfg dead code since I'm using probe_new()

Changes since v1:
- Drop 'shared_by_type' since it's a single channel
- Add error check for i2c read/write data bytes
- Simplified calculation for tolerance
- Add shift for eeprom wiper pos read
- Change new custom ABI to existing ABI
- Allow top-scale mode by writting max_pos to val

Mugilraj Dhavachelvan (2):
dt-bindings: iio: potentiometer: Add AD5110 in trivial-devices
iio: potentiometer: Add driver support for AD5110

 .../devicetree/bindings/trivial-devices.yaml  |   2 +
 MAINTAINERS                                   |   6 +
 drivers/iio/potentiometer/Kconfig             |  10 +
 drivers/iio/potentiometer/Makefile            |   1 +
 drivers/iio/potentiometer/ad5110.c            | 345 ++++++++++++++++++
 5 files changed, 364 insertions(+)
 create mode 100644 drivers/iio/potentiometer/ad5110.c
Signature · 1 line
2.25.1