Skip to content

RFC txhash: Make hash rethink configurable and change the default

Tom Herbert netdev oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3txhash: Make rethinking txhash behavior configurable via sysctlinclude/net/netns/core.h include/net/sock.h include/uapi/linux/socket.h +4 more+50 -110 replies
2/3txhash: Add socket option to control TX hash rethink behaviorarch/alpha/include/uapi/asm/socket.h arch/mips/include/uapi/asm/socket.h arch/parisc/include/uapi/asm/socket.h +4 more+33 -20 replies
3/3txhash: Change default rethink behavior to be less aggressivenet/core/net_namespace.c+2 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH net-next 0/3] txhash: Make hash rethink configurable and change the default

Alexander Azimov performed some nice analysis of the feature in Linux stack where the IPv6 flow label is changed when the stack detects a connection is failing. The idea of the algorithm is to try to find a better path. His reults are quite impressive, and show that this form of source routing can work effectively.

Alex raised an issue in that if the server endpoint is an IP anycast address, the connection might break if the flow label changes routing of packets on the connection. Anycast is known to be susceptible to route changes, not just those caused be flow label. The concern is that flow label modulation might increases the chances that anycast connections might break, especially if the rethink occurs after just one RTO which is the current behavior.

This patch set makes the rethink behavior granular and configurable. It allows control of when to do the hash rethink: upon negative advice, at RTO in SYN state, at RTO when not in SYN state. The behavior can be configured by sysctl and by a socket option.

This patch set the defautl rethink behavior to be to do a rethink only on negative advice. This is reverts back to the original behavior of the hash rethink mechanism. This less aggressive with the intent of mitigating potentail breakages when anycast addresses are present. For those users that are benefitting from changing the hash at the first RTO, they would retain that behavior by setting the sysctl. *** BLURB HERE ***

Tom Herbert (3):
txhash: Make rethinking txhash behavior configurable via sysctl
txhash: Add socket option to control TX hash rethink behavior
txhash: Change default rethink behavior to be less aggressive

 arch/alpha/include/uapi/asm/socket.h  |  2 ++
 arch/mips/include/uapi/asm/socket.h   |  2 ++
 arch/parisc/include/uapi/asm/socket.h |  2 ++
 arch/sparc/include/uapi/asm/socket.h  |  3 ++-
 include/net/netns/core.h              |  2 ++
 include/net/sock.h                    | 32 +++++++++++++++++++--------
 include/uapi/asm-generic/socket.h     |  2 ++
 include/uapi/linux/socket.h           | 13 +++++++++++
 net/core/net_namespace.c              |  4 ++++
 net/core/sock.c                       | 16 ++++++++++++++
 net/core/sysctl_net_core.c            |  7 ++++++
 net/ipv4/tcp_input.c                  |  2 +-
 net/ipv4/tcp_timer.c                  |  5 ++++-
 13 files changed, 80 insertions(+), 12 deletions(-)
Signature · 1 line
2.25.1