Skip to content

ASoC: cs42l42: Series of bugfixes and improvements

Richard Fitzgerald alsa-devel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12ASoC: cs42l42: Use PLL for SCLK > 12.188MHzsound/soc/codecs/cs42l42.c+18 -230 replies
2/12ASoC: cs42l42: Don't claim to support 192ksound/soc/codecs/cs42l42.c+3 -30 replies
3/12ASoC: cs42l42: Always configure both ASP TX channelssound/soc/codecs/cs42l42.c+4 -50 replies
4/12ASoC: cs42l42: Don't reconfigure the PLL while it is runningsound/soc/codecs/cs42l42.c+5 -16 replies
5/12ASoC: cs42l42: Set correct SRC MCLKsound/soc/codecs/cs42l42.c sound/soc/codecs/cs42l42.h+40 -210 replies
6/12ASoC: cs42l42: Mark OSC_SWITCH_STATUS register volatilesound/soc/codecs/cs42l42.c+1 -00 replies
7/12ASoC: cs42l42: Allow time for HP/ADC to power-up after enablesound/soc/codecs/cs42l42.c sound/soc/codecs/cs42l42.h+31 -20 replies
8/12ASoC: cs42l42: Prevent NULL pointer deref in interrupt handlersound/soc/codecs/cs42l42.c sound/soc/codecs/cs42l42.h+9 -190 replies
9/12ASoC: cs42l42: Remove runtime_suspend/runtime_resume callbackssound/soc/codecs/cs42l42.c+0 -440 replies
10/12ASoC: cs42l42: Remove redundant pll_divout membersound/soc/codecs/cs42l42.c sound/soc/codecs/cs42l42.h+3 -70 replies
11/12ASoC: cs42l42: Add HP Volume Scale controlsound/soc/codecs/cs42l42.c+12 -130 replies
12/12ASoC: cs42l42: Add control for audio slow-start switchsound/soc/codecs/cs42l42.c sound/soc/codecs/cs42l42.h+35 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] ASoC: cs42l42: Series of bugfixes and improvements

Various bugfixes and improvements to the cs42l42 codec driver.

Clocking bugfixes:
- Remove any use of MCLK > 12.288 MHz because it isn't possible to switch between the low and high frequency ranges on-the-fly

- Prevent the PLL configuration being written while the PLL is running
- Correctly set the MCLK for the sample rate converters

ASP bugfixes:
- Ensure the TX (capture) ASP is properly configured when recording mono audio.

Other bugfixes:
- Prevent NULL pointer deref if there is an interrupt before soc component probe

Code cleanup:
- Remove the unused runtime suspend/resume functions.
- Remove some code made redundant by an earlier patch

Improvement:
- Add ALSA control for HP path attenuation. Previously this was always set to -6dB with no way for the user to configure it.

- Add ALSA control to disable the soft volume ramp at the start of audio.

Richard Fitzgerald (12):
ASoC: cs42l42: Use PLL for SCLK > 12.188MHz
ASoC: cs42l42: Don't claim to support 192k
ASoC: cs42l42: Always configure both ASP TX channels
ASoC: cs42l42: Don't reconfigure the PLL while it is running
ASoC: cs42l42: Set correct SRC MCLK
ASoC: cs42l42: Mark OSC_SWITCH_STATUS register volatile
ASoC: cs42l42: Allow time for HP/ADC to power-up after enable
ASoC: cs42l42: Prevent NULL pointer deref in interrupt handler
ASoC: cs42l42: Remove runtime_suspend/runtime_resume callbacks
ASoC: cs42l42: Remove redundant pll_divout member
ASoC: cs42l42: Add HP Volume Scale control
ASoC: cs42l42: Add control for audio slow-start switch

 sound/soc/codecs/cs42l42.c | 281 ++++++++++++++++++++++++---------------------
 sound/soc/codecs/cs42l42.h |   9 +-
 2 files changed, 156 insertions(+), 134 deletions(-)
Signature · 1 line
2.11.0