Skip to content

net: ipa: use runtime PM reference counting

Alex Elder lkml netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net: ipa: have ipa_clock_get() return a valuedrivers/net/ipa/ipa_clock.c drivers/net/ipa/ipa_clock.h drivers/net/ipa/ipa_interrupt.c +4 more+99 -590 replies
2/7net: ipa: disable clock in suspenddrivers/net/ipa/ipa_clock.c+3 -80 replies
3/7net: ipa: resume in ipa_clock_get()drivers/net/ipa/ipa_clock.c+37 -260 replies
4/7net: ipa: use runtime PM coredrivers/net/ipa/ipa_clock.c+38 -370 replies
5/7net: ipa: get rid of extra clock referencedrivers/net/ipa/ipa_main.c+0 -110 replies
6/7net: ipa: kill IPA clock reference countdrivers/net/ipa/ipa_clock.c+6 -710 replies
7/7net: ipa: kill ipa_clock_get_additional()drivers/net/ipa/ipa_clock.c drivers/net/ipa/ipa_clock.h drivers/net/ipa/ipa_smp2p.c+4 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/7] net: ipa: use runtime PM reference counting

This series does further rework of the IPA clock code so that we rely on some of the core runtime power management code (including its referencing counting) instead.

The first patch makes ipa_clock_get() act like pm_runtime_get_sync().

The second patch makes system suspend occur regardless of the current reference count value, which is again more like how the runtime PM core code behaves.

The third patch creates functions to encapsulate all hardware suspend and resume activity. The fourth uses those functions as the ->runtime_suspend and ->runtime_resume power callbacks. With that in place, ipa_clock_get() and ipa_clock_put() are changed to use runtime PM get and put functions when needed.

The fifth patch eliminates an extra clock reference previously used to control system suspend. The sixth eliminates the "IPA clock" reference count and mutex.

The final patch replaces the one call to ipa_clock_get_additional() with a call to pm_runtime_get_if_active(), making the former unnecessary.

-Alec

Alex Elder (7):
net: ipa: have ipa_clock_get() return a value
net: ipa: disable clock in suspend
net: ipa: resume in ipa_clock_get()
net: ipa: use runtime PM core
net: ipa: get rid of extra clock reference
net: ipa: kill IPA clock reference count
net: ipa: kill ipa_clock_get_additional()

 drivers/net/ipa/ipa_clock.c     | 165 +++++++++++---------------------
 drivers/net/ipa/ipa_clock.h     |  18 ++--
 drivers/net/ipa/ipa_interrupt.c |   9 +-
 drivers/net/ipa/ipa_main.c      |  35 +++----
 drivers/net/ipa/ipa_modem.c     |  15 ++-
 drivers/net/ipa/ipa_smp2p.c     |  33 ++++---
 drivers/net/ipa/ipa_uc.c        |  12 ++-
 7 files changed, 121 insertions(+), 166 deletions(-)
Signature · 1 line
2.27.0