drm/i915/hdcp: HDCP2.2 MST dock fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 10 repliesIn review
- v53 patches 2 repliesSuperseded
- v43 patches 3 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 5 replies | Superseded | |
| v2 | 3 patches | 0 replies | Superseded | |
| v1 | 3 patches | 0 replies | Superseded |
Changes in v6 from the cover letter
- rename intel_set_stream_types() to intel_hdcp_prepare_streams() (Anshuman)
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg()drivers/ | +4 | 2 replies | |
| 2/3 | drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_Listdrivers/ | +16 | 2 replies | |
| 3/3 | drm/i915/hdcp: reuse rx_info for mst stream type1 capability checkdrivers/ drivers/ drivers/ | +38 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Anshuman Gupta | Ramalingam C | Suraj K |
|---|---|---|---|
| 1/3 | A-b | R-b | T-b |
| 2/3 | R-b | R-b | T-b |
| 3/3 | R-b | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Intel-gfx] [PATCH v6 0/3] drm/i915/hdcp: HDCP2.2 MST dock fixes
Fixes to get HDCP2.2 over MST working on MST docking stations with certain behaviors that cause the current flow to fail. Tested with Dell WD-19 and Lenovo ThinkPad USB Type-C Dock Gen 2.
These fixes should make the flow more robust to handle behaviors that as far as I can tell are unclear in the HDCP spec:
RxInfo contains repeater topology information needed for MST. The behavior on these docks is that this can only be read during RepeaterAuth_Send_ReceiverID_List when the RxStatus READY bit is set otherwise the dock will return NACK. It seems these docks treat reading this range at any other time as invalid when the READY bit isn't set possibly because it could be stale. The HDCP spec also states the READY bit is cleared after RxInfo is read.
These fixes address this behavior by only reading RxInfo once during the AKE flow and reusing that data.
Changes since v5:
- rename intel_set_stream_types() to intel_hdcp_prepare_streams() (Anshuman)
Changes since v4:
- move topology_type1_capable to intel_digital_port and rename it as hdcp_mst_type1_capable (Anshuman)
- make a helper function intel_set_stream_types() to set stream types in hdcp2_authenticate_and_encrypt() (Anshuman)
- break on failure to set stream types and retry instead of returning
- remove no longer used declaration for streams_type1_capable()
Changes since v3:
- Don't change the offset define for Send_ReceiverID_List When reading, update message offset to account for RxInfo being read
Changes since v2:
- Remove no longer used variables in _intel_hdcp2_enable()
Changes since v1:
- Fix subject line for 3/3
Juston Li (3):
drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg() drm/i915/hdcp: read RxInfo once when reading
RepeaterAuth_Send_ReceiverID_List
drm/i915/hdcp: reuse rx_info for mst stream type1 capability check
.../drm/i915/display/intel_display_types.h | 6 +- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 78 +++++-------------- drivers/gpu/drm/i915/display/intel_hdcp.c | 64 ++++++++------- 3 files changed, 58 insertions(+), 90 deletions(-)
Signature · 1 line
2.31.1